You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Pavel Moravec (JIRA)" <ji...@apache.org> on 2012/04/25 11:08:03 UTC

[jira] [Created] (QPID-3974) replication exchange msgDrop and byteDrop to increase when duplicate messages detected

Pavel Moravec created QPID-3974:
-----------------------------------

             Summary: replication exchange msgDrop and byteDrop to increase when duplicate messages detected
                 Key: QPID-3974
                 URL: https://issues.apache.org/jira/browse/QPID-3974
             Project: Qpid
          Issue Type: Bug
          Components: C++ Broker
    Affects Versions: 0.14
            Reporter: Pavel Moravec
            Priority: Trivial


Description of problem:
When replication exchange detects duplicated messages, it 1) discards them, and
2) as for any other message, it increases msgIn and byteIn counters. But
msgDrop and byteDrop counters are not updated, though the messages were
discarded.


Version-Release number of selected component (if applicable):
any (incl. 0.14)


How reproducible:
100%


Steps to Reproduce:
1. Setup queue state replication, like
https://cwiki.apache.org/qpid/queue-state-replication.html. 
2. Produce 3 messages to the queue-a on the source broker.
3. Restart source broker.
4. Produce another 5 messages to the queue-a on the source broker.


Actual results:
Destination broker (replication exchange in particular) drops the messages
(though these are not duplicates of previously sent - new BZ to be open for
that). Replication exchange increases msgIn and byteIn counters but does not
increase msgDrop and byteDrop counters.


Expected results:
msgDrop and byteDrop counters are also increased.


Additional info:
Patch to be proposed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[jira] [Updated] (QPID-3974) replication exchange msgDrop and byteDrop to increase when duplicate messages detected

Posted by "Pavel Moravec (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-3974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pavel Moravec updated QPID-3974:
--------------------------------

    Attachment: ReplicationDuplMsgIncrement.patch

Patch proposal.

When isDuplicate(args) is called and returns true, mgmtExchange->inc_msgDrops and mgmtExchange->inc_msgBytes is called (if it is set up).
                
> replication exchange msgDrop and byteDrop to increase when duplicate messages detected
> --------------------------------------------------------------------------------------
>
>                 Key: QPID-3974
>                 URL: https://issues.apache.org/jira/browse/QPID-3974
>             Project: Qpid
>          Issue Type: Bug
>          Components: C++ Broker
>    Affects Versions: 0.14
>            Reporter: Pavel Moravec
>            Priority: Trivial
>              Labels: patch
>         Attachments: ReplicationDuplMsgIncrement.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Description of problem:
> When replication exchange detects duplicated messages, it 1) discards them, and
> 2) as for any other message, it increases msgIn and byteIn counters. But
> msgDrop and byteDrop counters are not updated, though the messages were
> discarded.
> Version-Release number of selected component (if applicable):
> any (incl. 0.14)
> How reproducible:
> 100%
> Steps to Reproduce:
> 1. Setup queue state replication, like
> https://cwiki.apache.org/qpid/queue-state-replication.html. 
> 2. Produce 5 messages to the queue-a on the source broker.
> 3. Restart source broker.
> 4. Produce another 3 messages to the queue-a on the source broker.
> Actual results:
> Destination broker (replication exchange in particular) drops the messages
> (though these are not duplicates of previously sent - new BZ to be open for
> that). Replication exchange increases msgIn and byteIn counters but does not
> increase msgDrop and byteDrop counters.
> Expected results:
> msgDrop and byteDrop counters are also increased.
> Additional info:
> Patch to be proposed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[jira] [Updated] (QPID-3974) replication exchange msgDrop and byteDrop to increase when duplicate messages detected

Posted by "Pavel Moravec (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-3974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pavel Moravec updated QPID-3974:
--------------------------------

    Description: 
Description of problem:
When replication exchange detects duplicated messages, it 1) discards them, and
2) as for any other message, it increases msgIn and byteIn counters. But
msgDrop and byteDrop counters are not updated, though the messages were
discarded.


Version-Release number of selected component (if applicable):
any (incl. 0.14)


How reproducible:
100%


Steps to Reproduce:
1. Setup queue state replication, like
https://cwiki.apache.org/qpid/queue-state-replication.html. 
2. Produce 5 messages to the queue-a on the source broker.
3. Restart source broker.
4. Produce another 3 messages to the queue-a on the source broker.


Actual results:
Destination broker (replication exchange in particular) drops the messages
(though these are not duplicates of previously sent - new BZ to be open for
that). Replication exchange increases msgIn and byteIn counters but does not
increase msgDrop and byteDrop counters.


Expected results:
msgDrop and byteDrop counters are also increased.


Additional info:
Patch to be proposed.

  was:
Description of problem:
When replication exchange detects duplicated messages, it 1) discards them, and
2) as for any other message, it increases msgIn and byteIn counters. But
msgDrop and byteDrop counters are not updated, though the messages were
discarded.


Version-Release number of selected component (if applicable):
any (incl. 0.14)


How reproducible:
100%


Steps to Reproduce:
1. Setup queue state replication, like
https://cwiki.apache.org/qpid/queue-state-replication.html. 
2. Produce 3 messages to the queue-a on the source broker.
3. Restart source broker.
4. Produce another 5 messages to the queue-a on the source broker.


Actual results:
Destination broker (replication exchange in particular) drops the messages
(though these are not duplicates of previously sent - new BZ to be open for
that). Replication exchange increases msgIn and byteIn counters but does not
increase msgDrop and byteDrop counters.


Expected results:
msgDrop and byteDrop counters are also increased.


Additional info:
Patch to be proposed.

    
> replication exchange msgDrop and byteDrop to increase when duplicate messages detected
> --------------------------------------------------------------------------------------
>
>                 Key: QPID-3974
>                 URL: https://issues.apache.org/jira/browse/QPID-3974
>             Project: Qpid
>          Issue Type: Bug
>          Components: C++ Broker
>    Affects Versions: 0.14
>            Reporter: Pavel Moravec
>            Priority: Trivial
>              Labels: patch
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Description of problem:
> When replication exchange detects duplicated messages, it 1) discards them, and
> 2) as for any other message, it increases msgIn and byteIn counters. But
> msgDrop and byteDrop counters are not updated, though the messages were
> discarded.
> Version-Release number of selected component (if applicable):
> any (incl. 0.14)
> How reproducible:
> 100%
> Steps to Reproduce:
> 1. Setup queue state replication, like
> https://cwiki.apache.org/qpid/queue-state-replication.html. 
> 2. Produce 5 messages to the queue-a on the source broker.
> 3. Restart source broker.
> 4. Produce another 3 messages to the queue-a on the source broker.
> Actual results:
> Destination broker (replication exchange in particular) drops the messages
> (though these are not duplicates of previously sent - new BZ to be open for
> that). Replication exchange increases msgIn and byteIn counters but does not
> increase msgDrop and byteDrop counters.
> Expected results:
> msgDrop and byteDrop counters are also increased.
> Additional info:
> Patch to be proposed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[jira] [Resolved] (QPID-3974) replication exchange msgDrop and byteDrop to increase when duplicate messages detected

Posted by "Gordon Sim (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-3974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gordon Sim resolved QPID-3974.
------------------------------

       Resolution: Fixed
    Fix Version/s: 0.17
         Assignee: Gordon Sim

Thanks Pavel!
                
> replication exchange msgDrop and byteDrop to increase when duplicate messages detected
> --------------------------------------------------------------------------------------
>
>                 Key: QPID-3974
>                 URL: https://issues.apache.org/jira/browse/QPID-3974
>             Project: Qpid
>          Issue Type: Bug
>          Components: C++ Broker
>    Affects Versions: 0.14
>            Reporter: Pavel Moravec
>            Assignee: Gordon Sim
>            Priority: Trivial
>              Labels: patch
>             Fix For: 0.17
>
>         Attachments: ReplicationDuplMsgIncrement.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Description of problem:
> When replication exchange detects duplicated messages, it 1) discards them, and
> 2) as for any other message, it increases msgIn and byteIn counters. But
> msgDrop and byteDrop counters are not updated, though the messages were
> discarded.
> Version-Release number of selected component (if applicable):
> any (incl. 0.14)
> How reproducible:
> 100%
> Steps to Reproduce:
> 1. Setup queue state replication, like
> https://cwiki.apache.org/qpid/queue-state-replication.html. 
> 2. Produce 5 messages to the queue-a on the source broker.
> 3. Restart source broker.
> 4. Produce another 3 messages to the queue-a on the source broker.
> Actual results:
> Destination broker (replication exchange in particular) drops the messages
> (though these are not duplicates of previously sent - new BZ to be open for
> that). Replication exchange increases msgIn and byteIn counters but does not
> increase msgDrop and byteDrop counters.
> Expected results:
> msgDrop and byteDrop counters are also increased.
> Additional info:
> Patch to be proposed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org