You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/09/07 20:50:42 UTC
[GitHub] [airflow] vincbeck opened a new pull request, #26221: Remove log group from AWS batch system test
vincbeck opened a new pull request, #26221:
URL: https://github.com/apache/airflow/pull/26221
Whenever a new batch job is executed, a new Cloudwatch log stream is created. We should remove this log stream as part of the test as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pankajkoti commented on a diff in pull request #26221: Remove log group from AWS batch system test
Posted by GitBox <gi...@apache.org>.
pankajkoti commented on code in PR #26221:
URL: https://github.com/apache/airflow/pull/26221#discussion_r969264838
##########
tests/system/providers/amazon/aws/example_batch.py:
##########
@@ -15,6 +15,7 @@
# specific language governing permissions and limitations
# under the License.
from datetime import datetime
+from typing import List, Optional, Tuple
Review Comment:
Can you try using `__future__.annotations` like in PR: https://github.com/apache/airflow/pull/26290/files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #26221: Remove log group from AWS batch system test
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #26221:
URL: https://github.com/apache/airflow/pull/26221
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] vincbeck commented on a diff in pull request #26221: Remove log group from AWS batch system test
Posted by GitBox <gi...@apache.org>.
vincbeck commented on code in PR #26221:
URL: https://github.com/apache/airflow/pull/26221#discussion_r971273303
##########
tests/system/providers/amazon/aws/example_batch.py:
##########
@@ -15,6 +15,7 @@
# specific language governing permissions and limitations
# under the License.
from datetime import datetime
+from typing import List, Optional, Tuple
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #26221: Remove log group from AWS batch system test
Posted by GitBox <gi...@apache.org>.
potiuk commented on code in PR #26221:
URL: https://github.com/apache/airflow/pull/26221#discussion_r969390011
##########
tests/system/providers/amazon/aws/example_batch.py:
##########
@@ -15,6 +15,7 @@
# specific language governing permissions and limitations
# under the License.
from datetime import datetime
+from typing import List, Optional, Tuple
Review Comment:
I think this might be better done after I merge it (today :))
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org