[GitHub] [flink] dianfu commented on a change in pull request #13525: [FLINK-19447][hbase] Run HBase 2.2 integration test only if hadoop version is between 2.8.0 - 3.0.3

[GitBox <gi...@apache.org>]

dianfu commented on a change in pull request #13525:
URL: https://github.com/apache/flink/pull/13525#discussion_r497865775



##########
File path: flink-connectors/flink-connector-hbase-2.2/pom.xml
##########
@@ -45,6 +45,9 @@ under the License.
 				<artifactId>maven-surefire-plugin</artifactId>
 				<version>2.19.1</version>
 				<configuration>
+					<systemPropertyVariables>

Review comment:
       I guess this change is not necessary?

##########
File path: flink-connectors/flink-connector-hbase-2.2/src/test/java/org/apache/flink/connector/hbase2/util/HBaseTestingClusterAutoStarter.java
##########
@@ -119,6 +123,9 @@ private static void initialize(Configuration c) {
 
 	@BeforeClass
 	public static void setUp() throws Exception {
+		// HBase 2.2.3 HBaseTestingUtility works with only a certain range of hadoop versions
+		String hadoopVersion = System.getProperty("hadoop.version");
+		Assume.assumeTrue(HADOOP_VERSION_RANGE.contains(hadoopVersion));

Review comment:
       There is a utility org.apache.hadoop.util.VersionUtil provided in hadoop for comparing version. What about making use of it?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org