You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Josh Soref <js...@gmail.com> on 2017/01/09 08:51:51 UTC
hello
Hi,
I have a series of spelling fixes for Apache Tomcat [1].
If someone could suggest a preferred way to receive them, I'm happy to
split them up.
Some changes are more interesting than others (the change to KEYS is
interesting).
[1] https://github.com/jsoref/tomcat/commits/spelling
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: hello
Posted by Josh Soref <js...@gmail.com>.
I can drop that, but please note that the spelling is listed as corrected in the MIT key server. I really wonder how tomcat managed to corrupt it.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: hello
Posted by Violeta Georgieva <mi...@gmail.com>.
2017-01-09 14:23 GMT+02:00 Josh Soref <js...@gmail.com>:
>
>
https://github.com/jsoref/tomcat/commit/7c6bc40ac289ee7e7c9655c69a529f18afb5b92f
Let's not touch the KEYS file
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
Re: hello
Posted by Violeta Georgieva <mi...@gmail.com>.
Jean-Frederic,
2017-01-09 14:23 GMT+02:00 Josh Soref <js...@gmail.com>:
>
>
https://github.com/jsoref/tomcat/commit/7c6bc40ac289ee7e7c9655c69a529f18afb5b92f
Can you take a look at this change? It's about a spelling mistake in your
email address in the KEYS file.
Thanks a lot,
Violeta
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
Re: hello
Posted by Josh Soref <js...@gmail.com>.
https://github.com/jsoref/tomcat/commit/7c6bc40ac289ee7e7c9655c69a529f18afb5b92f
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: hello
Posted by Violeta Georgieva <mi...@gmail.com>.
2017-01-09 10:51 GMT+02:00 Josh Soref <js...@gmail.com>:
>
> Hi,
> I have a series of spelling fixes for Apache Tomcat [1].
>
I reviewed these changes. Please see the comments.
When you are ready squash the commits and make PR. I'll commit the changes.
> If someone could suggest a preferred way to receive them, I'm happy to
> split them up.
>
> Some changes are more interesting than others (the change to KEYS is
> interesting).
I didn't see any changes to KEYS.
>
> [1] https://github.com/jsoref/tomcat/commits/spelling
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
Re: hello
Posted by Violeta Georgieva <mi...@gmail.com>.
2017-01-09 11:23 GMT+02:00 Josh Soref <js...@gmail.com>:
>
> I can certainly squash. The reason I personally retain splits by
misspelled word is that it's easier to rebase / resolve conflicts when I
can see what word was misspelled.
>
> Typically large projects prefer to have my changes split into a couple of
patches/PRs instead of as a single commit.
>
Yes that's true. I also prefer separate patches.
But in this case this is just a spelling correction and I think we can use
a single commit.
> As a quick review, you can do diff -r trunk -r spelling or similar to see
the world.
>
> [1] https://github.com/xbmc/xbmc/pull/11346
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
Re: hello
Posted by Josh Soref <js...@gmail.com>.
I can certainly squash. The reason I personally retain splits by misspelled word is that it's easier to rebase / resolve conflicts when I can see what word was misspelled.
Typically large projects prefer to have my changes split into a couple of patches/PRs instead of as a single commit.
As a quick review, you can do diff -r trunk -r spelling or similar to see the world.
[1] https://github.com/xbmc/xbmc/pull/11346
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: hello
Posted by Violeta Georgieva <vi...@apache.org>.
Hi Josh,
2017-01-09 11:11 GMT+02:00 Mark Thomas <ma...@apache.org>:
>
> On 09/01/2017 08:51, Josh Soref wrote:
> > Hi,
> > I have a series of spelling fixes for Apache Tomcat [1].
> >
> > If someone could suggest a preferred way to receive them, I'm happy to
> > split them up.
>
> Pull request or patch file attached to a new Bugzilla issue is fine.
I saw that you have separate changes for every spelling fix.
May be it is better to squash them and then make PR.
Regards,
Violeta
> Mark
>
>
> >
> > Some changes are more interesting than others (the change to KEYS is
> > interesting).
> >
> > [1] https://github.com/jsoref/tomcat/commits/spelling
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> > For additional commands, e-mail: dev-help@tomcat.apache.org
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
Re: hello
Posted by Violeta Georgieva <mi...@gmail.com>.
Josh,
2017-01-09 11:38 GMT+02:00 Mark Thomas <ma...@apache.org>:
>
> On 09/01/2017 09:35, Violeta Georgieva wrote:
> > Mark,
> >
> > 2017-01-09 11:11 GMT+02:00 Mark Thomas <ma...@apache.org>:
> >>
> >> On 09/01/2017 08:51, Josh Soref wrote:
> >>> Hi,
> >>> I have a series of spelling fixes for Apache Tomcat [1].
> >>>
> >>> If someone could suggest a preferred way to receive them, I'm happy to
> >>> split them up.
> >>
> >> Pull request or patch file attached to a new Bugzilla issue is fine.
> >
> > Some of the fixes are in DBCP2 code [1]
> > Should we fix our copy of DBCP2? I think it's better this to be changed
> > directly in DBCP2 code.
>
> I agree. DBCP2 fixes should be applied to Commons and then we'll pick
> them up when up next update.
Please review this document
https://github.com/apache/tomcat/blob/trunk/MERGE.txt
We reuse code from other Apache projects
Violeta
> Mark
>
> >
> > [1]
> >
https://github.com/jsoref/tomcat/commit/6c686154f8a780733bc14546056ef588c34d20b9
> >
> >> Mark
> >>
> >>
> >>>
> >>> Some changes are more interesting than others (the change to KEYS is
> >>> interesting).
> >>>
> >>> [1] https://github.com/jsoref/tomcat/commits/spelling
> >>>
> >>> ---------------------------------------------------------------------
> >>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> >>> For additional commands, e-mail: dev-help@tomcat.apache.org
> >>>
> >>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> >> For additional commands, e-mail: dev-help@tomcat.apache.org
> >>
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
Re: hello
Posted by Mark Thomas <ma...@apache.org>.
On 09/01/2017 09:35, Violeta Georgieva wrote:
> Mark,
>
> 2017-01-09 11:11 GMT+02:00 Mark Thomas <ma...@apache.org>:
>>
>> On 09/01/2017 08:51, Josh Soref wrote:
>>> Hi,
>>> I have a series of spelling fixes for Apache Tomcat [1].
>>>
>>> If someone could suggest a preferred way to receive them, I'm happy to
>>> split them up.
>>
>> Pull request or patch file attached to a new Bugzilla issue is fine.
>
> Some of the fixes are in DBCP2 code [1]
> Should we fix our copy of DBCP2? I think it's better this to be changed
> directly in DBCP2 code.
I agree. DBCP2 fixes should be applied to Commons and then we'll pick
them up when up next update.
Mark
>
> [1]
> https://github.com/jsoref/tomcat/commit/6c686154f8a780733bc14546056ef588c34d20b9
>
>> Mark
>>
>>
>>>
>>> Some changes are more interesting than others (the change to KEYS is
>>> interesting).
>>>
>>> [1] https://github.com/jsoref/tomcat/commits/spelling
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: hello
Posted by Violeta Georgieva <mi...@gmail.com>.
Mark,
2017-01-09 11:11 GMT+02:00 Mark Thomas <ma...@apache.org>:
>
> On 09/01/2017 08:51, Josh Soref wrote:
> > Hi,
> > I have a series of spelling fixes for Apache Tomcat [1].
> >
> > If someone could suggest a preferred way to receive them, I'm happy to
> > split them up.
>
> Pull request or patch file attached to a new Bugzilla issue is fine.
Some of the fixes are in DBCP2 code [1]
Should we fix our copy of DBCP2? I think it's better this to be changed
directly in DBCP2 code.
[1]
https://github.com/jsoref/tomcat/commit/6c686154f8a780733bc14546056ef588c34d20b9
> Mark
>
>
> >
> > Some changes are more interesting than others (the change to KEYS is
> > interesting).
> >
> > [1] https://github.com/jsoref/tomcat/commits/spelling
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> > For additional commands, e-mail: dev-help@tomcat.apache.org
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
Re: hello
Posted by Mark Thomas <ma...@apache.org>.
On 09/01/2017 08:51, Josh Soref wrote:
> Hi,
> I have a series of spelling fixes for Apache Tomcat [1].
>
> If someone could suggest a preferred way to receive them, I'm happy to
> split them up.
Pull request or patch file attached to a new Bugzilla issue is fine.
Mark
>
> Some changes are more interesting than others (the change to KEYS is
> interesting).
>
> [1] https://github.com/jsoref/tomcat/commits/spelling
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: hello
Posted by Violeta Georgieva <vi...@apache.org>.
Hi,
2017-01-09 10:51 GMT+02:00 Josh Soref <js...@gmail.com>:
>
> Hi,
> I have a series of spelling fixes for Apache Tomcat [1].
>
> If someone could suggest a preferred way to receive them, I'm happy to
> split them up.
>
> Some changes are more interesting than others (the change to KEYS is
> interesting).
>
> [1] https://github.com/jsoref/tomcat/commits/spelling
I'll take a look.
Regards,
Violeta
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>