You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by nabarun nag <nn...@pivotal.io> on 2016/08/04 21:45:22 UTC
Re: Review Request 50615: GEODE-1676: Multiple Not Equals in query
with Compact Range Index returns incorrect results
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50615/#review144832
-----------------------------------------------------------
Ship it!
Ship It!
- nabarun nag
On July 29, 2016, 9:16 p.m., Jason Huynh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50615/
> -----------------------------------------------------------
>
> (Updated July 29, 2016, 9:16 p.m.)
>
>
> Review request for geode, anilkumar gingade and nabarun nag.
>
>
> Repository: geode
>
>
> Description
> -------
>
> The keysToRemove set was being removed from during iteration of the index. This is as expected, however a copy of the keysToRemove should be made first because the same set will be passed to the next bucket. We would end up removing from the original set and as we continued the query to the next bucket, it would eventually be an empty set.
>
> PdxString and Strings were not being properly compared in TypeUtils (which is used by CompactRangeIndexes, among others)
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/cache/query/internal/index/MemoryIndexStore.java 83f8c02
> geode-core/src/main/java/com/gemstone/gemfire/cache/query/internal/types/TypeUtils.java 14c798f
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/dunit/CompactRangeIndexQueryDUnitTest.java PRE-CREATION
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/internal/types/TypeUtilTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/50615/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jason Huynh
>
>