You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/05/04 12:35:58 UTC

[GitHub] [tvm] manupa-arm commented on a diff in pull request #11091: [AOT] Enable A-Normal Form in the AOT executor

manupa-arm commented on code in PR #11091:
URL: https://github.com/apache/tvm/pull/11091#discussion_r864773919


##########
src/relay/backend/aot_executor_codegen.cc:
##########
@@ -215,11 +217,21 @@ class AOTOnDemandAllocator : public transform::DeviceAwareExprVisitor {
    * \return The corresponding token.
    */
   StorageInfo GetStorage(const Expr& expr) {
+    Expr true_expr = expr;
+
+    // Don't get storage for let nodes.
+    while (const auto* let_node = true_expr.as<LetNode>()) {

Review Comment:
   Won't we achieve the same effect by using something from here ? : 
   https://github.com/apache/tvm/blob/f0854ae456a98581d7cc4004fc848f73879e5c3e/src/relay/transforms/device_aware_visitors.h#L247-L258
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org