You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "wangyum (via GitHub)" <gi...@apache.org> on 2023/02/09 09:51:42 UTC
[GitHub] [spark] wangyum commented on a diff in pull request #39908: [SPARK-42360][SQL] Transform LeftOuter join with IsNull filter on right side to Anti join
wangyum commented on code in PR #39908:
URL: https://github.com/apache/spark/pull/39908#discussion_r1101214387
##########
sql/core/src/test/resources/tpcds-plan-stability/approved-plans-v2_7/q78.sf100/simplified.txt:
##########
@@ -17,36 +17,35 @@ TakeOrderedAndProject [ss_sold_year,ss_item_sk,ss_customer_sk,ss_qty,ss_wc,ss_sp
Project [ss_item_sk,ss_customer_sk,ss_quantity,ss_wholesale_cost,ss_sales_price,d_year]
BroadcastHashJoin [ss_sold_date_sk,d_date_sk]
Project [ss_item_sk,ss_customer_sk,ss_quantity,ss_wholesale_cost,ss_sales_price,ss_sold_date_sk]
- Filter [sr_ticket_number]
- SortMergeJoin [ss_ticket_number,ss_item_sk,sr_ticket_number,sr_item_sk]
- InputAdapter
- WholeStageCodegen (2)
- Sort [ss_ticket_number,ss_item_sk]
- InputAdapter
- Exchange [ss_ticket_number,ss_item_sk] #2
- WholeStageCodegen (1)
- Filter [ss_item_sk,ss_customer_sk]
+ SortMergeJoin [ss_ticket_number,ss_item_sk,sr_ticket_number,sr_item_sk]
Review Comment:
Do you have the benchmark number if active this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org