You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by tzulitai <gi...@git.apache.org> on 2018/05/09 06:35:24 UTC

[GitHub] flink pull request #5969: [FLINK-9074] [e2e] Add e2e for resuming from exter...

GitHub user tzulitai opened a pull request:

    https://github.com/apache/flink/pull/5969

    [FLINK-9074] [e2e] Add e2e for resuming from externalized checkpoints

    ## What is the purpose of the change
    
    This PR adds an end-to-end test for resuming from externalized, retained checkpoints.
    
    The test does the following:
    - Runs the general purpose DataStream job, with externalized checkpoints enabled
    - Waits until the job has at least 1 completed checkpoints, AND has processed at least 200 records
    - Cancel the job
    - Make sure that there is exactly 1 externalized checkpoint available
    - Restore from that, wait for another 200 records to be processed to verify that exactly-once isn't violated
    
    ## Brief change log
    
    - Allow general purpose job to be configured for externalized checkpoints
    - Add new e2e test script `test_resume_externalized_checkpoint.sh`
    
    ## Verifying this change
    
    This PR adds a new test, `test_resume_externalized_checkpoint.sh`.
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (yes / **no**)
      - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tzulitai/flink FLINK-9074

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5969.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5969
    
----
commit bb8dce7622d83d4c2214013de24193ffa47a1e75
Author: Tzu-Li (Gordon) Tai <tz...@...>
Date:   2018-05-09T03:40:24Z

    [FLINK-9074] [e2e] Allow configuring externalized checkpoints for the general purpose DataStream job

commit 91e7f911739a094d58051a7b620a4564fd7f6067
Author: Tzu-Li (Gordon) Tai <tz...@...>
Date:   2018-05-09T04:17:25Z

    [FLINK-9074] [e2e] Add e2e test for resuming jobs from retained checkpoints

----


---

[GitHub] flink issue #5969: [FLINK-9074] [e2e] Add e2e for resuming from externalized...

Posted by tzulitai <gi...@git.apache.org>.
Github user tzulitai commented on the issue:

    https://github.com/apache/flink/pull/5969
  
    Thanks a lot for the review @fhueske.
    Will merge this!


---

[GitHub] flink issue #5969: [FLINK-9074] [e2e] Add e2e for resuming from externalized...

Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the issue:

    https://github.com/apache/flink/pull/5969
  
    thanks for the PR @tzulitai.
    The new e2e tests passed on my machine. The changes look good as well.
    +1 to merge


---

[GitHub] flink pull request #5969: [FLINK-9074] [e2e] Add e2e for resuming from exter...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/5969


---