[jira] [Commented] (GEODE-2707) Remove TXLockToken

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-2707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16054431#comment-16054431 ] 

ASF GitHub Bot commented on GEODE-2707:
---------------------------------------

GitHub user YehEmily opened a pull request:

    https://github.com/apache/geode/pull/592

    GEODE-2707: Removing TXLockToken

    [View the JIRA ticket here.](https://issues.apache.org/jira/browse/GEODE-2707)
    
    It seems that there are no other classes that use the `TXLockToken` class, so it was safely removed. It's also an internal class, so it doesn't seem likely that the removal of this class will break any backwards compatibility.
    
    **_Precheckin status: In progress_**
    
    Thank you for submitting a contribution to Apache Geode.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    - [ ] Does `gradlew build` run cleanly?
    
    - [ ] Have you written or updated unit tests to verify your changes?
    
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and
    submit an update to your PR as soon as possible. If you need help, please send an
    email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/YehEmily/geode GEODE-2707

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/592.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #592
    
----
commit e51f2047136ea4cdaa09c22a3cc06290e7dd0a01
Author: YehEmily <em...@gmail.com>
Date:   2017-06-19T17:36:53Z

    GEODE-2707: Removing TXLockToken (it doesn't appear to be used anywhere, although I still need to check for backwards compatibility issues)

----


> Remove TXLockToken
> ------------------
>
>                 Key: GEODE-2707
>                 URL: https://issues.apache.org/jira/browse/GEODE-2707
>             Project: Geode
>          Issue Type: Task
>          Components: distributed lock service
>            Reporter: Galen O'Sullivan
>            Assignee: Emily Yeh
>            Priority: Trivial
>
> The {{TXLockToken}} class doesn't seem to actually be used anywhere in the source. Look into the history and remove it if it's no longer needed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)