You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by zj...@apache.org on 2020/02/28 01:33:30 UTC
[zeppelin] branch master updated: [ZEPPELIN-4640]. Save note after
saving interpreter binding setting
This is an automated email from the ASF dual-hosted git repository.
zjffdu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/zeppelin.git
The following commit(s) were added to refs/heads/master by this push:
new a9a34cd [ZEPPELIN-4640]. Save note after saving interpreter binding setting
a9a34cd is described below
commit a9a34cdd54665ac57f20a4defd8f5555ba7b6611
Author: Jeff Zhang <zj...@apache.org>
AuthorDate: Tue Feb 25 14:23:04 2020 +0800
[ZEPPELIN-4640]. Save note after saving interpreter binding setting
### What is this PR for?
This is a trivial PR which just add one line of code to save note after saving interpreter binding setting.
### What type of PR is it?
[Bug Fix ]
### Todos
* [ ] - Task
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-4640
### How should this be tested?
* Tested manually
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
Author: Jeff Zhang <zj...@apache.org>
Closes #3659 from zjffdu/ZEPPELIN-4640 and squashes the following commits:
848e515dc [Jeff Zhang] [ZEPPELIN-4640]. Save note after saving interpreter binding setting
---
.../src/main/java/org/apache/zeppelin/socket/NotebookServer.java | 2 ++
1 file changed, 2 insertions(+)
diff --git a/zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java b/zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java
index fab5c8c..d29ab4f 100644
--- a/zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java
+++ b/zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java
@@ -552,6 +552,8 @@ public class NotebookServer extends WebSocketServlet
new TypeToken<ArrayList<String>>() {}.getType());
if (!settingIdList.isEmpty()) {
note.setDefaultInterpreterGroup(settingIdList.get(0));
+ getNotebook().saveNote(note,
+ new AuthenticationInfo(fromMessage.principal, fromMessage.roles, fromMessage.ticket));
}
List<InterpreterSetting> bindedSettings = note.getBindedInterpreterSettings();
for (InterpreterSetting setting : bindedSettings) {