You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by zjffdu <gi...@git.apache.org> on 2018/03/06 01:55:23 UTC

[GitHub] zeppelin pull request #2836: ZEPPELIN-3291. Throw exception instead of retur...

GitHub user zjffdu opened a pull request:

    https://github.com/apache/zeppelin/pull/2836

    ZEPPELIN-3291. Throw exception instead of return null for InterpreterFactory.getInterpreter

    
    ### What is this PR for?
    Minor code refactoring to throw exception when no interpreter is found
    
    
    ### What type of PR is it?
    [Refactoring]
    
    ### Todos
    * [ ] - Task
    
    ### What is the Jira issue?
    * https://issues.apache.org/jira/browse/ZEPPELIN-3291
    
    ### How should this be tested?
    * CI pass
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-3291

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2836.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2836
    
----
commit bee319ccc069df3a76f27996d5447bf112da15ba
Author: Jeff Zhang <zj...@...>
Date:   2018-03-05T04:58:19Z

    ZEPPELIN-3291. Throw exception instead of return null for InterpreterFactory.getInterpreter

----


---

[GitHub] zeppelin issue #2836: ZEPPELIN-3291. Throw exception instead of return null ...

Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:

    https://github.com/apache/zeppelin/pull/2836
  
    hey @zjffdu thanks for making all these improvements, could we make sure there is at least one review before merging?
    @Leemoonsoo 


---

[GitHub] zeppelin pull request #2836: ZEPPELIN-3291. Throw exception instead of retur...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/2836


---