You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by "rymarm (via GitHub)" <gi...@apache.org> on 2023/08/07 18:32:37 UTC

[PR] DRILL-8449: fix typo in width property in FreeMarker templates (drill)

rymarm opened a new pull request, #2818:
URL: https://github.com/apache/drill/pull/2818

   # [DRILL-8449](https://issues.apache.org/jira/browse/DRILL-8449): Typo in FreeMarker templates
   
   ## Description
   
   CSS-based properties use a colon(`:`) to assign values. The `result.ftl` and `options.ftl` have the property `width` with an equal sign(`=`) instead of a colon(`:`).
   
   This typo makes a query result table has an incorrect display.
   
   Steps to reproduce:
   1. Execute example query: `select full_name from cp.`employee.json` limit 1`;
   2. Push the "Column visibility" button, toggle "full_name" column visibility off, and turn it back on.
   
   
   ## Documentation
   None requerid
   
   ## Testing
   Visual test of UI
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] DRILL-8449: fix typo in width property in FreeMarker templates (drill)

Posted by "cgivre (via GitHub)" <gi...@apache.org>.
cgivre commented on PR #2818:
URL: https://github.com/apache/drill/pull/2818#issuecomment-1668420106

   Thanks @rymarm 
   I'll merge once the CI passes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] DRILL-8449: fix typo in width property in FreeMarker templates (drill)

Posted by "cgivre (via GitHub)" <gi...@apache.org>.
cgivre merged PR #2818:
URL: https://github.com/apache/drill/pull/2818


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org