You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Martin Grigorov (JIRA)" <ji...@apache.org> on 2010/12/18 19:04:03 UTC

[jira] Commented: (WICKET-3263) Allow AjaxRequestTarget.IListeners to be Registered at the WebApplication Level

    [ https://issues.apache.org/jira/browse/WICKET-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12972841#action_12972841 ] 

Martin Grigorov commented on WICKET-3263:
-----------------------------------------

I don't like that now we have both #newAjaxRequestTarget(Page) and setAjaxRequestTargetProvider().
AjaxRequestTarget is not quite extendable. I think #newAjaxRequestTarget() is public just because it is called from another package (org.apache.wicket.ajax.AbstractDefaultAjaxBehavior.onRequest()).

I suggest to either leave it as it is now + the listeners, or to extract interface IAjaxRequestHandler that extends IRequestHandler and AjaxRequestTarget is the default impl + the provider and listeners.

> Allow AjaxRequestTarget.IListeners to be Registered at the WebApplication Level
> -------------------------------------------------------------------------------
>
>                 Key: WICKET-3263
>                 URL: https://issues.apache.org/jira/browse/WICKET-3263
>             Project: Wicket
>          Issue Type: New Feature
>          Components: wicket
>    Affects Versions: 1.5-M3
>            Reporter: James Carman
>         Attachments: WICKET-3263.patch
>
>
> Right now, in order to register an AjaxRequestTarget.IListener, you have to override WebApplication.newAjaxRequestTarget(Page p).  That does make Wicket very "pluggable."  What if multiple frameworks need to add in that hook?  So, why not allow a global, application-level, registry of those listeners.  Each AjaxRequestTarget would have those listeners added to it.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.