You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/05/22 06:19:01 UTC
[GitHub] [incubator-superset] john-bodley opened a new pull request #9883: style(mypy): Enforcing typing for superset.models
john-bodley opened a new pull request #9883:
URL: https://github.com/apache/incubator-superset/pull/9883
### SUMMARY
Adding `mypy` type enforcement to the `superset.models` module.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
CI.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9883: style(mypy): Enforcing typing for superset.models
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9883:
URL: https://github.com/apache/incubator-superset/pull/9883#issuecomment-632512253
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9883?src=pr&el=h1) Report
> Merging [#9883](https://codecov.io/gh/apache/incubator-superset/pull/9883?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/3e8e441bfcb5b188840d3d08265073db1f67d1a6&el=desc) will **decrease** coverage by `0.28%`.
> The diff coverage is `92.74%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9883?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9883 +/- ##
==========================================
- Coverage 71.24% 70.95% -0.29%
==========================================
Files 584 184 -400
Lines 30790 17947 -12843
Branches 3238 0 -3238
==========================================
- Hits 21936 12735 -9201
+ Misses 8744 5212 -3532
+ Partials 110 0 -110
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `70.95% <92.74%> (-0.43%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9883?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/tags.py](https://codecov.io/gh/apache/incubator-superset/pull/9883/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3RhZ3MucHk=) | `61.20% <80.95%> (-1.18%)` | :arrow_down: |
| [superset/models/helpers.py](https://codecov.io/gh/apache/incubator-superset/pull/9883/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2hlbHBlcnMucHk=) | `88.78% <89.13%> (+0.11%)` | :arrow_up: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9883/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.41% <100.00%> (-0.19%)` | :arrow_down: |
| [superset/legacy.py](https://codecov.io/gh/apache/incubator-superset/pull/9883/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbGVnYWN5LnB5) | `100.00% <100.00%> (ø)` | |
| [superset/models/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/9883/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Fubm90YXRpb25zLnB5) | `92.59% <100.00%> (+0.28%)` | :arrow_up: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9883/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `83.96% <100.00%> (-2.34%)` | :arrow_down: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/9883/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `88.59% <100.00%> (+0.10%)` | :arrow_up: |
| [superset/models/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/9883/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NjaGVkdWxlcy5weQ==) | `89.58% <100.00%> (ø)` | |
| [superset/models/slice.py](https://codecov.io/gh/apache/incubator-superset/pull/9883/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NsaWNlLnB5) | `83.95% <100.00%> (+0.17%)` | :arrow_up: |
| [superset/models/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/9883/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF9sYWIucHk=) | `92.50% <100.00%> (+0.12%)` | :arrow_up: |
| ... and [440 more](https://codecov.io/gh/apache/incubator-superset/pull/9883/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9883?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9883?src=pr&el=footer). Last update [3e8e441...0f1c33d](https://codecov.io/gh/apache/incubator-superset/pull/9883?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9883: style(mypy): Enforcing typing for superset.models
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9883:
URL: https://github.com/apache/incubator-superset/pull/9883#issuecomment-632512253
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9883?src=pr&el=h1) Report
> Merging [#9883](https://codecov.io/gh/apache/incubator-superset/pull/9883?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/3e8e441bfcb5b188840d3d08265073db1f67d1a6&el=desc) will **decrease** coverage by `5.06%`.
> The diff coverage is `92.74%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9883?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9883 +/- ##
==========================================
- Coverage 71.24% 66.18% -5.07%
==========================================
Files 584 584
Lines 30790 30664 -126
Branches 3238 3238
==========================================
- Hits 21936 20294 -1642
- Misses 8744 10183 +1439
- Partials 110 187 +77
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.44% <ø> (ø)` | |
| #python | `70.95% <92.74%> (-0.43%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9883?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/tags.py](https://codecov.io/gh/apache/incubator-superset/pull/9883/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3RhZ3MucHk=) | `61.20% <80.95%> (-1.18%)` | :arrow_down: |
| [superset/models/helpers.py](https://codecov.io/gh/apache/incubator-superset/pull/9883/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2hlbHBlcnMucHk=) | `88.78% <89.13%> (+0.11%)` | :arrow_up: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9883/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.41% <100.00%> (-0.19%)` | :arrow_down: |
| [superset/legacy.py](https://codecov.io/gh/apache/incubator-superset/pull/9883/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbGVnYWN5LnB5) | `100.00% <100.00%> (ø)` | |
| [superset/models/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/9883/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Fubm90YXRpb25zLnB5) | `92.59% <100.00%> (+0.28%)` | :arrow_up: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9883/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `83.96% <100.00%> (-2.34%)` | :arrow_down: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/9883/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `88.59% <100.00%> (+0.10%)` | :arrow_up: |
| [superset/models/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/9883/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NjaGVkdWxlcy5weQ==) | `89.58% <100.00%> (ø)` | |
| [superset/models/slice.py](https://codecov.io/gh/apache/incubator-superset/pull/9883/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NsaWNlLnB5) | `83.95% <100.00%> (+0.17%)` | :arrow_up: |
| [superset/models/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/9883/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF9sYWIucHk=) | `92.50% <100.00%> (+0.12%)` | :arrow_up: |
| ... and [188 more](https://codecov.io/gh/apache/incubator-superset/pull/9883/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9883?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9883?src=pr&el=footer). Last update [3e8e441...0f1c33d](https://codecov.io/gh/apache/incubator-superset/pull/9883?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter commented on pull request #9883: style(mypy): Enforcing typing for superset.models
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #9883:
URL: https://github.com/apache/incubator-superset/pull/9883#issuecomment-632512253
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9883?src=pr&el=h1) Report
> Merging [#9883](https://codecov.io/gh/apache/incubator-superset/pull/9883?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/3e8e441bfcb5b188840d3d08265073db1f67d1a6&el=desc) will **decrease** coverage by `11.80%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9883?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9883 +/- ##
===========================================
- Coverage 71.24% 59.44% -11.81%
===========================================
Files 584 400 -184
Lines 30790 12717 -18073
Branches 3238 3234 -4
===========================================
- Hits 21936 7559 -14377
+ Misses 8744 4971 -3773
- Partials 110 187 +77
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.44% <ø> (ø)` | |
| #python | `?` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9883?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9883/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9883/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9883/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9883/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9883/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9883/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/9883/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9883/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/9883/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/9883/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [309 more](https://codecov.io/gh/apache/incubator-superset/pull/9883/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9883?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9883?src=pr&el=footer). Last update [3e8e441...0f1c33d](https://codecov.io/gh/apache/incubator-superset/pull/9883?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] john-bodley merged pull request #9883: style(mypy): Enforcing typing for superset.models
Posted by GitBox <gi...@apache.org>.
john-bodley merged pull request #9883:
URL: https://github.com/apache/incubator-superset/pull/9883
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9883: style(mypy): Enforcing typing for superset.models
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9883:
URL: https://github.com/apache/incubator-superset/pull/9883#issuecomment-632512253
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9883?src=pr&el=h1) Report
> Merging [#9883](https://codecov.io/gh/apache/incubator-superset/pull/9883?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/3e8e441bfcb5b188840d3d08265073db1f67d1a6&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `92.74%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9883?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9883 +/- ##
==========================================
+ Coverage 71.24% 71.25% +0.01%
==========================================
Files 584 584
Lines 30790 30809 +19
Branches 3238 3238
==========================================
+ Hits 21936 21953 +17
- Misses 8744 8746 +2
Partials 110 110
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.83% <ø> (+<0.01%)` | :arrow_up: |
| #javascript | `59.44% <ø> (ø)` | |
| #python | `71.40% <92.74%> (+0.01%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9883?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/tags.py](https://codecov.io/gh/apache/incubator-superset/pull/9883/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3RhZ3MucHk=) | `61.20% <80.95%> (-1.18%)` | :arrow_down: |
| [superset/models/helpers.py](https://codecov.io/gh/apache/incubator-superset/pull/9883/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2hlbHBlcnMucHk=) | `88.78% <89.13%> (+0.11%)` | :arrow_up: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9883/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.60% <100.00%> (ø)` | |
| [superset/legacy.py](https://codecov.io/gh/apache/incubator-superset/pull/9883/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbGVnYWN5LnB5) | `100.00% <100.00%> (ø)` | |
| [superset/models/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/9883/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Fubm90YXRpb25zLnB5) | `92.59% <100.00%> (+0.28%)` | :arrow_up: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9883/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `86.29% <100.00%> (ø)` | |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/9883/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `88.59% <100.00%> (+0.10%)` | :arrow_up: |
| [superset/models/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/9883/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NjaGVkdWxlcy5weQ==) | `89.58% <100.00%> (ø)` | |
| [superset/models/slice.py](https://codecov.io/gh/apache/incubator-superset/pull/9883/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NsaWNlLnB5) | `83.95% <100.00%> (+0.17%)` | :arrow_up: |
| [superset/models/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/9883/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF9sYWIucHk=) | `92.50% <100.00%> (+0.12%)` | :arrow_up: |
| ... and [11 more](https://codecov.io/gh/apache/incubator-superset/pull/9883/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9883?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9883?src=pr&el=footer). Last update [3e8e441...0f1c33d](https://codecov.io/gh/apache/incubator-superset/pull/9883?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9883: style(mypy): Enforcing typing for superset.models
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9883:
URL: https://github.com/apache/incubator-superset/pull/9883#issuecomment-632512253
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9883?src=pr&el=h1) Report
> Merging [#9883](https://codecov.io/gh/apache/incubator-superset/pull/9883?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/3e8e441bfcb5b188840d3d08265073db1f67d1a6&el=desc) will **decrease** coverage by `0.18%`.
> The diff coverage is `92.74%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9883?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9883 +/- ##
==========================================
- Coverage 71.24% 71.05% -0.19%
==========================================
Files 584 584
Lines 30790 30809 +19
Branches 3238 3238
==========================================
- Hits 21936 21892 -44
- Misses 8744 8800 +56
- Partials 110 117 +7
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.06% <ø> (-0.77%)` | :arrow_down: |
| #javascript | `59.44% <ø> (ø)` | |
| #python | `71.40% <92.74%> (+0.01%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9883?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/tags.py](https://codecov.io/gh/apache/incubator-superset/pull/9883/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3RhZ3MucHk=) | `61.20% <80.95%> (-1.18%)` | :arrow_down: |
| [superset/models/helpers.py](https://codecov.io/gh/apache/incubator-superset/pull/9883/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2hlbHBlcnMucHk=) | `88.78% <89.13%> (+0.11%)` | :arrow_up: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9883/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.60% <100.00%> (ø)` | |
| [superset/legacy.py](https://codecov.io/gh/apache/incubator-superset/pull/9883/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbGVnYWN5LnB5) | `100.00% <100.00%> (ø)` | |
| [superset/models/annotations.py](https://codecov.io/gh/apache/incubator-superset/pull/9883/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Fubm90YXRpb25zLnB5) | `92.59% <100.00%> (+0.28%)` | :arrow_up: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9883/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `86.29% <100.00%> (ø)` | |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/9883/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `88.59% <100.00%> (+0.10%)` | :arrow_up: |
| [superset/models/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/9883/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NjaGVkdWxlcy5weQ==) | `89.58% <100.00%> (ø)` | |
| [superset/models/slice.py](https://codecov.io/gh/apache/incubator-superset/pull/9883/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NsaWNlLnB5) | `83.95% <100.00%> (+0.17%)` | :arrow_up: |
| [superset/models/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/9883/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF9sYWIucHk=) | `92.50% <100.00%> (+0.12%)` | :arrow_up: |
| ... and [20 more](https://codecov.io/gh/apache/incubator-superset/pull/9883/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9883?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9883?src=pr&el=footer). Last update [3e8e441...0f1c33d](https://codecov.io/gh/apache/incubator-superset/pull/9883?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org