You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Maxim Khutornenko <ma...@apache.org> on 2016/04/12 00:56:23 UTC
Review Request 46057: Renaming ResourceType.getName()
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46057/
-----------------------------------------------------------
Review request for Aurora and Zameer Manji.
Repository: aurora
Description
-------
Renaming getName() to getMesosName() to clearly state its meaning.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java dd9e12bdf9a11f357c9536dc5107e3fca35b3fb6
src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorSettings.java 78e7be93617da582afea8f22a5e9a9ba77d53e4b
src/main/java/org/apache/aurora/scheduler/mesos/TestExecutorSettings.java 1d252bbbe0a1124a9ef8f13cf412e99984b2da1a
src/main/java/org/apache/aurora/scheduler/resources/AcceptedOffer.java 6a5237f2151a4e9a8a551c1e3a2f72f899ad4df9
src/main/java/org/apache/aurora/scheduler/resources/ResourceSlot.java 43696d2fe044489f3daaeb9048282de52f939435
src/main/java/org/apache/aurora/scheduler/resources/ResourceType.java 5900ccb4d865db3cbd69e16b199e0123170d80f9
src/main/java/org/apache/aurora/scheduler/resources/Resources.java 46b31f0315df6fdb6a02f3c9f54591030843d6f9
src/test/java/org/apache/aurora/scheduler/app/local/simulator/ClusterSimulatorModule.java 48a665f960dc202136af1f1cb6c37a0697b9563b
src/test/java/org/apache/aurora/scheduler/mesos/Offers.java a7fb4b014815d36fc254d0051cb5561e3f6d0039
src/test/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilterTest.java 073987759e7d7481bb74cb32f2dd47a3d38a6f2a
src/test/java/org/apache/aurora/scheduler/resources/AcceptedOfferTest.java 319ffea017529c03f19a723d99e9eb971660a576
src/test/java/org/apache/aurora/scheduler/resources/ResourceSlotTest.java 8d5a143a0e8b57a1515defa92cce4d68f1d47963
src/test/java/org/apache/aurora/scheduler/resources/ResourcesTest.java bc2700c1b876dfee4df038b769dc6a39e4699117
src/test/java/org/apache/aurora/scheduler/stats/AsyncStatsModuleTest.java c23efed552c122657352f2b79192f302034a6221
Diff: https://reviews.apache.org/r/46057/diff/
Testing
-------
Thanks,
Maxim Khutornenko
Re: Review Request 46057: Renaming ResourceType.getName()
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46057/#review128290
-----------------------------------------------------------
Ship it!
Master (46ce98d) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On April 11, 2016, 10:56 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46057/
> -----------------------------------------------------------
>
> (Updated April 11, 2016, 10:56 p.m.)
>
>
> Review request for Aurora and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Renaming getName() to getMesosName() to clearly state its meaning.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java dd9e12bdf9a11f357c9536dc5107e3fca35b3fb6
> src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorSettings.java 78e7be93617da582afea8f22a5e9a9ba77d53e4b
> src/main/java/org/apache/aurora/scheduler/mesos/TestExecutorSettings.java 1d252bbbe0a1124a9ef8f13cf412e99984b2da1a
> src/main/java/org/apache/aurora/scheduler/resources/AcceptedOffer.java 6a5237f2151a4e9a8a551c1e3a2f72f899ad4df9
> src/main/java/org/apache/aurora/scheduler/resources/ResourceSlot.java 43696d2fe044489f3daaeb9048282de52f939435
> src/main/java/org/apache/aurora/scheduler/resources/ResourceType.java 5900ccb4d865db3cbd69e16b199e0123170d80f9
> src/main/java/org/apache/aurora/scheduler/resources/Resources.java 46b31f0315df6fdb6a02f3c9f54591030843d6f9
> src/test/java/org/apache/aurora/scheduler/app/local/simulator/ClusterSimulatorModule.java 48a665f960dc202136af1f1cb6c37a0697b9563b
> src/test/java/org/apache/aurora/scheduler/mesos/Offers.java a7fb4b014815d36fc254d0051cb5561e3f6d0039
> src/test/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilterTest.java 073987759e7d7481bb74cb32f2dd47a3d38a6f2a
> src/test/java/org/apache/aurora/scheduler/resources/AcceptedOfferTest.java 319ffea017529c03f19a723d99e9eb971660a576
> src/test/java/org/apache/aurora/scheduler/resources/ResourceSlotTest.java 8d5a143a0e8b57a1515defa92cce4d68f1d47963
> src/test/java/org/apache/aurora/scheduler/resources/ResourcesTest.java bc2700c1b876dfee4df038b769dc6a39e4699117
> src/test/java/org/apache/aurora/scheduler/stats/AsyncStatsModuleTest.java c23efed552c122657352f2b79192f302034a6221
>
> Diff: https://reviews.apache.org/r/46057/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 46057: Renaming ResourceType.getName()
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46057/#review128279
-----------------------------------------------------------
Ship it!
Ship It!
- Zameer Manji
On April 11, 2016, 3:56 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46057/
> -----------------------------------------------------------
>
> (Updated April 11, 2016, 3:56 p.m.)
>
>
> Review request for Aurora and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Renaming getName() to getMesosName() to clearly state its meaning.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java dd9e12bdf9a11f357c9536dc5107e3fca35b3fb6
> src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorSettings.java 78e7be93617da582afea8f22a5e9a9ba77d53e4b
> src/main/java/org/apache/aurora/scheduler/mesos/TestExecutorSettings.java 1d252bbbe0a1124a9ef8f13cf412e99984b2da1a
> src/main/java/org/apache/aurora/scheduler/resources/AcceptedOffer.java 6a5237f2151a4e9a8a551c1e3a2f72f899ad4df9
> src/main/java/org/apache/aurora/scheduler/resources/ResourceSlot.java 43696d2fe044489f3daaeb9048282de52f939435
> src/main/java/org/apache/aurora/scheduler/resources/ResourceType.java 5900ccb4d865db3cbd69e16b199e0123170d80f9
> src/main/java/org/apache/aurora/scheduler/resources/Resources.java 46b31f0315df6fdb6a02f3c9f54591030843d6f9
> src/test/java/org/apache/aurora/scheduler/app/local/simulator/ClusterSimulatorModule.java 48a665f960dc202136af1f1cb6c37a0697b9563b
> src/test/java/org/apache/aurora/scheduler/mesos/Offers.java a7fb4b014815d36fc254d0051cb5561e3f6d0039
> src/test/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilterTest.java 073987759e7d7481bb74cb32f2dd47a3d38a6f2a
> src/test/java/org/apache/aurora/scheduler/resources/AcceptedOfferTest.java 319ffea017529c03f19a723d99e9eb971660a576
> src/test/java/org/apache/aurora/scheduler/resources/ResourceSlotTest.java 8d5a143a0e8b57a1515defa92cce4d68f1d47963
> src/test/java/org/apache/aurora/scheduler/resources/ResourcesTest.java bc2700c1b876dfee4df038b769dc6a39e4699117
> src/test/java/org/apache/aurora/scheduler/stats/AsyncStatsModuleTest.java c23efed552c122657352f2b79192f302034a6221
>
> Diff: https://reviews.apache.org/r/46057/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Maxim Khutornenko
>
>