[GitHub] [storm] Ethanlm commented on pull request #3319: [STORM-3683] Check if JVM options used for launching worker are valid.

[GitBox <gi...@apache.org>]

Ethanlm commented on pull request #3319:
URL: https://github.com/apache/storm/pull/3319#issuecomment-687191521


   > I think a good reason to catching this early (i.e. at submission time) is that the cycle time for error detection is longer.
    
   It is not hard to find out that jvm didn't launch because of jvm option issue, GC option, profiler option or other options, since they are in the logs.
   
   But if this feature is really desired, I would suggest to move to Nimbus code. Doing it in `Nimbus.submitTopologyWithOpts` is still at submission time and users will see the exception from console log. But doing it on `StormSubmitter` side won't be able to detect the issue because it doesn't use daemonConf. 
   
   Another advantage of doing it at `Nimbus.submitTopologyWithOpts`  is we can avoid code duplication and we can restrict the scope of the code related to launching a worker. Because the code to launch the worker is purely server-side, it would be better to not expose it to client.
   
   But after moving it to Nimbus code, we need to deal with nimbusConf vs supervisorConf issue (although it is a less serious problem)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org