You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "Doug Cutting (JIRA)" <ji...@apache.org> on 2009/12/14 19:39:19 UTC
[jira] Created: (AVRO-255) schema namespace should be lexically
scoped
schema namespace should be lexically scoped
-------------------------------------------
Key: AVRO-255
URL: https://issues.apache.org/jira/browse/AVRO-255
Project: Avro
Issue Type: Bug
Components: java
Reporter: Doug Cutting
Assignee: Doug Cutting
Fix For: 1.3.0
If a nested schema specifies a different namespace, then schemas nested within it should inherit that namespace rather than the top-level namespace. This permits textual inclusion of schemas within schemas.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AVRO-255) schema namespace should be lexically
scoped
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Doug Cutting updated AVRO-255:
------------------------------
Attachment: AVRO-255.patch
Here's a patch that fixes this.
> schema namespace should be lexically scoped
> -------------------------------------------
>
> Key: AVRO-255
> URL: https://issues.apache.org/jira/browse/AVRO-255
> Project: Avro
> Issue Type: Bug
> Components: java
> Reporter: Doug Cutting
> Assignee: Doug Cutting
> Fix For: 1.3.0
>
> Attachments: AVRO-255.patch
>
>
> If a nested schema specifies a different namespace, then schemas nested within it should inherit that namespace rather than the top-level namespace. This permits textual inclusion of schemas within schemas.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (AVRO-255) schema namespace should be lexically
scoped
Posted by "Philip Zeyliger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12791503#action_12791503 ]
Philip Zeyliger commented on AVRO-255:
--------------------------------------
bq. Does that make sense?
Yes.
> schema namespace should be lexically scoped
> -------------------------------------------
>
> Key: AVRO-255
> URL: https://issues.apache.org/jira/browse/AVRO-255
> Project: Avro
> Issue Type: Bug
> Components: java
> Reporter: Doug Cutting
> Assignee: Doug Cutting
> Fix For: 1.3.0
>
> Attachments: AVRO-255.patch
>
>
> If a nested schema specifies a different namespace, then schemas nested within it should inherit that namespace rather than the top-level namespace. This permits textual inclusion of schemas within schemas.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (AVRO-255) schema namespace should be lexically
scoped
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12790882#action_12790882 ]
Doug Cutting commented on AVRO-255:
-----------------------------------
> your test doesn't use the fact that the schema "x" has a field "f".
The test means to check that the text '{"type": "record", "name": "X", "fields": []}' can be embedded twice in a single schema and inherit different namespaces and hence define different records. The fields are otherwise not of interest. Does that make sense?
> schema namespace should be lexically scoped
> -------------------------------------------
>
> Key: AVRO-255
> URL: https://issues.apache.org/jira/browse/AVRO-255
> Project: Avro
> Issue Type: Bug
> Components: java
> Reporter: Doug Cutting
> Assignee: Doug Cutting
> Fix For: 1.3.0
>
> Attachments: AVRO-255.patch
>
>
> If a nested schema specifies a different namespace, then schemas nested within it should inherit that namespace rather than the top-level namespace. This permits textual inclusion of schemas within schemas.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (AVRO-255) schema namespace should be lexically
scoped
Posted by "Philip Zeyliger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12790518#action_12790518 ]
Philip Zeyliger commented on AVRO-255:
--------------------------------------
+1, but your test doesn't use the fact that the schema "x" has a field "f". Did you mean to write an assertion about x.f?
> schema namespace should be lexically scoped
> -------------------------------------------
>
> Key: AVRO-255
> URL: https://issues.apache.org/jira/browse/AVRO-255
> Project: Avro
> Issue Type: Bug
> Components: java
> Reporter: Doug Cutting
> Assignee: Doug Cutting
> Fix For: 1.3.0
>
> Attachments: AVRO-255.patch
>
>
> If a nested schema specifies a different namespace, then schemas nested within it should inherit that namespace rather than the top-level namespace. This permits textual inclusion of schemas within schemas.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AVRO-255) schema namespace should be lexically
scoped
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Doug Cutting updated AVRO-255:
------------------------------
Status: Patch Available (was: Open)
> schema namespace should be lexically scoped
> -------------------------------------------
>
> Key: AVRO-255
> URL: https://issues.apache.org/jira/browse/AVRO-255
> Project: Avro
> Issue Type: Bug
> Components: java
> Reporter: Doug Cutting
> Assignee: Doug Cutting
> Fix For: 1.3.0
>
> Attachments: AVRO-255.patch
>
>
> If a nested schema specifies a different namespace, then schemas nested within it should inherit that namespace rather than the top-level namespace. This permits textual inclusion of schemas within schemas.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AVRO-255) schema namespace should be lexically
scoped
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Doug Cutting updated AVRO-255:
------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
I just committed this.
> schema namespace should be lexically scoped
> -------------------------------------------
>
> Key: AVRO-255
> URL: https://issues.apache.org/jira/browse/AVRO-255
> Project: Avro
> Issue Type: Bug
> Components: java
> Reporter: Doug Cutting
> Assignee: Doug Cutting
> Fix For: 1.3.0
>
> Attachments: AVRO-255.patch
>
>
> If a nested schema specifies a different namespace, then schemas nested within it should inherit that namespace rather than the top-level namespace. This permits textual inclusion of schemas within schemas.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.