You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "flycash (GitHub)" <gi...@apache.org> on 2020/02/03 13:19:00 UTC
[GitHub] [dubbo-go] flycash opened pull request #350: Refactor:
remove context from URL.
<!-- Thanks for sending a pull request!
-->
**What this PR does**:
The baseURL contains field ctx which is context.Context and **never be used**.
According to the context's doc, the best practice is using the context.Context as method's parameter. So I remove this ctx.
[ Full content available at: https://github.com/apache/dubbo-go/pull/350 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks closed pull request #350: Refactor:
remove context from URL.
Posted by "AlexStocks (GitHub)" <gi...@apache.org>.
[ pull request closed by AlexStocks ]
[ Full content available at: https://github.com/apache/dubbo-go/pull/350 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org