[GitHub] [dubbo] owen200008 commented on a diff in pull request #10380: Module config no support unexport

[GitBox <gi...@apache.org>]

owen200008 commented on code in PR #10380:
URL: https://github.com/apache/dubbo/pull/10380#discussion_r932094904


##########
dubbo-config/dubbo-config-spring/src/main/java/org/apache/dubbo/config/spring/ServiceBean.java:
##########
@@ -104,6 +104,13 @@ public void afterPropertiesSet() throws Exception {
         moduleModel.getDeployer().setPending();
     }
 
+    @Override
+    public void unexport() {
+        ModuleModel moduleModel = DubboBeanUtils.getModuleModel(applicationContext);
+        moduleModel.getConfigManager().removeConfig(this);

Review Comment:
   it only destroy call



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org