You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/11 22:03:43 UTC

[GitHub] [superset] ktmud opened a new issue #12422: [Dashboard][Native Filter] Field select in forever loading state when Datasource is not selected

ktmud opened a new issue #12422:
URL: https://github.com/apache/superset/issues/12422


   ## Screenshot
   
   In the new native filter
   
   "FIELD" in forever loading state when "DATASOURCE" is not selected:
   
   ![image](https://user-images.githubusercontent.com/335541/104243353-498dac80-5415-11eb-8261-de792cac80f0.png)
   
   BTW, we should probably rename "DATASOURCE" to "Dataset".
   
   Some other potential TODOs:
   
   1. Automatically select the main datasource in the dashboard
   2. Limit the datasource select to only those used in the dashboard (debatable)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] simcha90 edited a comment on issue #12422: [Dashboard][Native Filter] Field select in forever loading state when Datasource is not selected

Posted by GitBox <gi...@apache.org>.
simcha90 edited a comment on issue #12422:
URL: https://github.com/apache/superset/issues/12422#issuecomment-826308449


   We can't load fields of dataset if there is no dataset selected, some other thoughts:
   About 2. There is can be charts and filters from different datasets, why need limit to 1?
   
   But may be it good point to implement item 1., but how we can know what is main dataset of dahsboard?
   
   ![image](https://user-images.githubusercontent.com/56388545/115991754-90716d80-a5d2-11eb-93ed-f0505c74051c.png)
   
   Like take here ☝️ first one? @ktmud @amitmiran137 @junlincc 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] simcha90 edited a comment on issue #12422: [Dashboard][Native Filter] Field select in forever loading state when Datasource is not selected

Posted by GitBox <gi...@apache.org>.
simcha90 edited a comment on issue #12422:
URL: https://github.com/apache/superset/issues/12422#issuecomment-826308449






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] simcha90 commented on issue #12422: [Dashboard][Native Filter] Field select in forever loading state when Datasource is not selected

Posted by GitBox <gi...@apache.org>.
simcha90 commented on issue #12422:
URL: https://github.com/apache/superset/issues/12422#issuecomment-826308449


   We can't load fields of dataset if there is no dataset selected, some other thoughts:
   About 2. There is can be charts and filters from different datasets, why need limit to 1?
   
   But may be it good to implement item 1., but how we can now what is main dataset of dahsboard?
   
   ![image](https://user-images.githubusercontent.com/56388545/115991754-90716d80-a5d2-11eb-93ed-f0505c74051c.png)
   
   Like take here ☝️ first one?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] amitmiran137 closed issue #12422: [Dashboard][Native Filter] Field select in forever loading state when Datasource is not selected

Posted by GitBox <gi...@apache.org>.
amitmiran137 closed issue #12422:
URL: https://github.com/apache/superset/issues/12422


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] simcha90 commented on issue #12422: [Dashboard][Native Filter] Field select in forever loading state when Datasource is not selected

Posted by GitBox <gi...@apache.org>.
simcha90 commented on issue #12422:
URL: https://github.com/apache/superset/issues/12422#issuecomment-826308449


   We can't load fields of dataset if there is no dataset selected, some other thoughts:
   About 2. There is can be charts and filters from different datasets, why need limit to 1?
   
   But may be it good to implement item 1., but how we can now what is main dataset of dahsboard?
   
   ![image](https://user-images.githubusercontent.com/56388545/115991754-90716d80-a5d2-11eb-93ed-f0505c74051c.png)
   
   Like take here ☝️ first one?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] junlincc commented on issue #12422: [Dashboard][Native Filter] Field select in forever loading state when Datasource is not selected

Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #12422:
URL: https://github.com/apache/superset/issues/12422#issuecomment-758299668


   man!! i'm still in Explore and you already started on the Dashboard!!! @ktmud  😈


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] stale[bot] commented on issue #12422: [Dashboard][Native Filter] Field select in forever loading state when Datasource is not selected

Posted by GitBox <gi...@apache.org>.
stale[bot] commented on issue #12422:
URL: https://github.com/apache/superset/issues/12422#issuecomment-868936099


   This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue `.pinned` to prevent stale bot from closing the issue.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] simcha90 edited a comment on issue #12422: [Dashboard][Native Filter] Field select in forever loading state when Datasource is not selected

Posted by GitBox <gi...@apache.org>.
simcha90 edited a comment on issue #12422:
URL: https://github.com/apache/superset/issues/12422#issuecomment-826308449


   We can't load fields of dataset if there is no dataset selected, some other thoughts:
   About 2. There is can be charts and filters from different datasets, why need limit to 1?
   
   But may be it good to implement item 1., but how we can now what is main dataset of dahsboard?
   
   ![image](https://user-images.githubusercontent.com/56388545/115991754-90716d80-a5d2-11eb-93ed-f0505c74051c.png)
   
   Like take here ☝️ first one? @ktmud @amitmiran137 @junlincc 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org