[GitHub] [incubator-druid] ccaominh commented on a change in pull request #9021: Allow startup scripts to specify java home

[GitBox <gi...@apache.org>]

ccaominh commented on a change in pull request #9021: Allow startup scripts to specify java home
URL: https://github.com/apache/incubator-druid/pull/9021#discussion_r357408219
 
 

 ##########
 File path: examples/bin/java-util
 ##########
 @@ -0,0 +1,39 @@
+#!/bin/bash
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+#######################################
+# A utility script to search for java. The order in which we look for java
+# goes from most specific to least specific, i.e.
+#     ${DRUID_JAVA_HOME}
+#     ${JAVA_HOME}
+#     ${PATH}
+# Arguments:
+#   None
+# Returns:
+#   The bin folder of java if it exists, otherwise an empty string
+#######################################
+get_java_bin() {
 
 Review comment:
   Consider renaming "bin" to something like "bin_dir". "bin" could be interpreted to mean the directory or the binary executable. (similar comment for the JAVA_BIN variables).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org