You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by iilyak <gi...@git.apache.org> on 2015/06/26 20:48:49 UTC
[GitHub] couchdb-couch-epi pull request: Add couch_epi:is_configured
GitHub user iilyak opened a pull request:
https://github.com/apache/couchdb-couch-epi/pull/2
Add couch_epi:is_configured
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/iilyak/couchdb-couch-epi add-is_configured
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-couch-epi/pull/2.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2
----
commit 3ca7b1423181caf0bef422bc5c72c962178b60d6
Author: ILYA Khlopotov <ii...@ca.ibm.com>
Date: 2015-06-26T18:47:38Z
Add couch_epi:is_configured
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch-epi pull request: Add couch_epi:is_configured
Posted by rnewson <gi...@git.apache.org>.
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb-couch-epi/pull/2#issuecomment-125987775
+1 after squash.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch-epi pull request: Add couch_epi:is_configured
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on a diff in the pull request:
https://github.com/apache/couchdb-couch-epi/pull/2#discussion_r34421707
--- Diff: src/couch_epi_functions_gen.erl ---
@@ -309,6 +309,11 @@ remove_from_definitions(Defs, Source) ->
{[], Defs}
end.
+-spec modules(Handle :: atom(), Function :: atom(), Arity :: pos_integer()) ->
+ boolean().
--- End diff --
Return type is not boolean() here - it's a list which returned by [`couch_epi_codegen:scan/1`](https://github.com/apache/couchdb-couch-epi/blob/master/src/couch_epi_codegen.erl#L36) which is called by [`providers/4`](https://github.com/iilyak/couchdb-couch-epi/blob/add-is_configured/src/couch_epi_functions_gen.erl#L295-L302) (and /2,3 as well).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch-epi pull request: Add couch_epi:is_configured
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb-couch-epi/pull/2
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch-epi pull request: Add couch_epi:is_configured
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-couch-epi/pull/2#issuecomment-125988283
agree (:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch-epi pull request: Add couch_epi:is_configured
Posted by iilyak <gi...@git.apache.org>.
Github user iilyak commented on the pull request:
https://github.com/apache/couchdb-couch-epi/pull/2#issuecomment-125991630
The PR has been squashed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---