You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rojas <al...@mesosphere.io> on 2015/06/15 11:24:28 UTC
Re: Review Request 35354: Smaller fixes in libprocess firewall
initialization
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35354/
-----------------------------------------------------------
(Updated June 15, 2015, 11:24 a.m.)
Review request for mesos, Ben Mahler and Till Toenshoff.
Changes
-------
till's comments.
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/master/main.cpp 1c33e3bf7baae45b1671f9566b4993f39d9f1294
src/messages/flags.hpp 41be419ba5593a600aa0c6c411210fa4faa829a8
src/slave/main.cpp c379243e01919a5ab30bb9dea1b738665ba4e746
Diff: https://reviews.apache.org/r/35354/diff/
Testing
-------
Manual checks && make check
Thanks,
Alexander Rojas
Re: Review Request 35354: Smaller fixes in libprocess firewall
initialization
Posted by Till Toenshoff <to...@me.com>.
> On June 22, 2015, 10:21 p.m., Ben Mahler wrote:
> > Till, will you be able to help Alex get these committed? If not, I'm happy to help out.
Sry for the delay, we had some holiday / sick-day slowdown here :). Comitted them now.
- Till
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35354/#review88865
-----------------------------------------------------------
On June 24, 2015, 3:06 p.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35354/
> -----------------------------------------------------------
>
> (Updated June 24, 2015, 3:06 p.m.)
>
>
> Review request for mesos, Ben Mahler and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/main.cpp 1c33e3bf7baae45b1671f9566b4993f39d9f1294
> src/messages/flags.hpp 41be419ba5593a600aa0c6c411210fa4faa829a8
> src/slave/main.cpp c379243e01919a5ab30bb9dea1b738665ba4e746
>
> Diff: https://reviews.apache.org/r/35354/diff/
>
>
> Testing
> -------
>
> Manual checks && make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 35354: Smaller fixes in libprocess firewall
initialization
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35354/#review88865
-----------------------------------------------------------
Till, will you be able to help Alex get these committed? If not, I'm happy to help out.
- Ben Mahler
On June 15, 2015, 9:24 a.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35354/
> -----------------------------------------------------------
>
> (Updated June 15, 2015, 9:24 a.m.)
>
>
> Review request for mesos, Ben Mahler and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/main.cpp 1c33e3bf7baae45b1671f9566b4993f39d9f1294
> src/messages/flags.hpp 41be419ba5593a600aa0c6c411210fa4faa829a8
> src/slave/main.cpp c379243e01919a5ab30bb9dea1b738665ba4e746
>
> Diff: https://reviews.apache.org/r/35354/diff/
>
>
> Testing
> -------
>
> Manual checks && make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 35354: Smaller fixes in libprocess firewall
initialization
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35354/
-----------------------------------------------------------
(Updated June 24, 2015, 5:06 p.m.)
Review request for mesos, Ben Mahler and Till Toenshoff.
Changes
-------
Till's comments.
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/master/main.cpp 1c33e3bf7baae45b1671f9566b4993f39d9f1294
src/messages/flags.hpp 41be419ba5593a600aa0c6c411210fa4faa829a8
src/slave/main.cpp c379243e01919a5ab30bb9dea1b738665ba4e746
Diff: https://reviews.apache.org/r/35354/diff/
Testing
-------
Manual checks && make check
Thanks,
Alexander Rojas
Re: Review Request 35354: Smaller fixes in libprocess firewall
initialization
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35354/#review89164
-----------------------------------------------------------
Ship it!
src/slave/main.cpp (line 68)
<https://reviews.apache.org/r/35354/#comment141767>
Add a `using process::Owned` please. I really wonder which header is doing this so it compiles without the `using`.
- Till Toenshoff
On June 15, 2015, 9:24 a.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35354/
> -----------------------------------------------------------
>
> (Updated June 15, 2015, 9:24 a.m.)
>
>
> Review request for mesos, Ben Mahler and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/main.cpp 1c33e3bf7baae45b1671f9566b4993f39d9f1294
> src/messages/flags.hpp 41be419ba5593a600aa0c6c411210fa4faa829a8
> src/slave/main.cpp c379243e01919a5ab30bb9dea1b738665ba4e746
>
> Diff: https://reviews.apache.org/r/35354/diff/
>
>
> Testing
> -------
>
> Manual checks && make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 35354: Smaller fixes in libprocess firewall
initialization
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35354/#review87912
-----------------------------------------------------------
Patch looks great!
Reviews applied: [35353, 35354]
All tests passed.
- Mesos ReviewBot
On June 15, 2015, 9:24 a.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35354/
> -----------------------------------------------------------
>
> (Updated June 15, 2015, 9:24 a.m.)
>
>
> Review request for mesos, Ben Mahler and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/main.cpp 1c33e3bf7baae45b1671f9566b4993f39d9f1294
> src/messages/flags.hpp 41be419ba5593a600aa0c6c411210fa4faa829a8
> src/slave/main.cpp c379243e01919a5ab30bb9dea1b738665ba4e746
>
> Diff: https://reviews.apache.org/r/35354/diff/
>
>
> Testing
> -------
>
> Manual checks && make check
>
>
> Thanks,
>
> Alexander Rojas
>
>