You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@opendal.apache.org by "Xuanwo (via GitHub)" <gi...@apache.org> on 2023/05/25 11:39:34 UTC

[GitHub] [incubator-opendal] Xuanwo commented on a diff in pull request #2323: refactor(core): Implement RFC-2299 for list_with

Xuanwo commented on code in PR #2323:
URL: https://github.com/apache/incubator-opendal/pull/2323#discussion_r1205388479


##########
core/src/types/operator/operator.rs:
##########
@@ -1393,28 +1402,38 @@ impl Operator {
     /// # Ok(())
     /// # }
     /// ```
-    pub async fn scan(&self, path: &str) -> Result<Lister> {

Review Comment:
   Hi, we don't need to change like this. Call list_with() like list is enough.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org