You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@streams.apache.org by rbnks <gi...@git.apache.org> on 2014/08/27 14:00:15 UTC
[GitHub] incubator-streams pull request: Streams 159
GitHub user rbnks opened a pull request:
https://github.com/apache/incubator-streams/pull/76
Streams 159
Add facebook page feed provider and fixed serializer to match twitter serializer fields
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rbnks/incubator-streams STREAMS-159
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-streams/pull/76.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #76
----
commit dca647510984d189904674511b41fa1d4889b788
Author: Ryan Ebanks <ry...@raveldata.com>
Date: 2014-08-19T16:11:26Z
Merge pull request #3 from apache/master
Apache master merge 2014/08/19
commit e7b90335de261f2f2537a3ae94095da06ce4b592
Author: Ryan Ebanks <re...@informations-macbook-pro-3.local>
Date: 2014-08-27T11:51:56Z
Updated facebook provider to have page feed provider and fixed serializer for posts
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: Streams 159
Posted by rbnks <gi...@git.apache.org>.
Github user rbnks commented on a diff in the pull request:
https://github.com/apache/incubator-streams/pull/76#discussion_r17057776
--- Diff: streams-contrib/streams-provider-facebook/metadata/facebook_post.mup ---
@@ -0,0 +1,694 @@
+{
--- End diff --
I agree. The mindmup tool may not be the best choice for documentation. However, I am not an expert in the tool and it may be possible to use it in a better manner.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: Streams 159
Posted by rbnks <gi...@git.apache.org>.
Github user rbnks commented on a diff in the pull request:
https://github.com/apache/incubator-streams/pull/76#discussion_r16991097
--- Diff: streams-contrib/streams-provider-facebook/metadata/facebook_post.mup ---
@@ -0,0 +1,694 @@
+{
--- End diff --
I believe I am. I think I just left it off the mindmup docs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: Streams 159
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-streams/pull/76
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: Streams 159
Posted by mfranklin <gi...@git.apache.org>.
Github user mfranklin commented on a diff in the pull request:
https://github.com/apache/incubator-streams/pull/76#discussion_r17048015
--- Diff: streams-contrib/streams-provider-facebook/metadata/facebook_post.mup ---
@@ -0,0 +1,694 @@
+{
--- End diff --
OK. I think it would be nice to indicate that somehow, but not sure that tool allows for it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: Streams 159
Posted by rbnks <gi...@git.apache.org>.
Github user rbnks commented on a diff in the pull request:
https://github.com/apache/incubator-streams/pull/76#discussion_r16795352
--- Diff: streams-contrib/streams-provider-facebook/src/main/java/org/apache/streams/facebook/api/FacebookPostActivitySerializer.java ---
@@ -76,6 +80,16 @@ public Activity deserialize(Post post) throws ActivitySerializerException {
parseObject(activity, mapper.convertValue(post, ObjectNode.class));
fixObjectId(activity);
fixContentFromSummary(activity);
+ activity.setVerb("post");
+ List<String> links = Lists.newLinkedList();
+ links.add(post.getLink());
+ activity.setLinks(links);
+ ensureExtensions(activity).put("facebook", post);
--- End diff --
Yes. I usually just always do it to be safe.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: Streams 159
Posted by rbnks <gi...@git.apache.org>.
Github user rbnks commented on the pull request:
https://github.com/apache/incubator-streams/pull/76#issuecomment-54171267
Responded to feedback comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: Streams 159
Posted by robdouglas <gi...@git.apache.org>.
Github user robdouglas commented on a diff in the pull request:
https://github.com/apache/incubator-streams/pull/76#discussion_r16794637
--- Diff: streams-contrib/streams-provider-facebook/src/main/java/org/apache/streams/facebook/api/FacebookPostActivitySerializer.java ---
@@ -76,6 +80,16 @@ public Activity deserialize(Post post) throws ActivitySerializerException {
parseObject(activity, mapper.convertValue(post, ObjectNode.class));
fixObjectId(activity);
fixContentFromSummary(activity);
+ activity.setVerb("post");
+ List<String> links = Lists.newLinkedList();
+ links.add(post.getLink());
+ activity.setLinks(links);
+ ensureExtensions(activity).put("facebook", post);
--- End diff --
don't you only need to call ensureExtensions once?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: Streams 159
Posted by rbnks <gi...@git.apache.org>.
Github user rbnks commented on a diff in the pull request:
https://github.com/apache/incubator-streams/pull/76#discussion_r16995167
--- Diff: streams-contrib/streams-provider-facebook/metadata/facebook_post.mup ---
@@ -0,0 +1,694 @@
+{
--- End diff --
The answer to this is I am, but facebook doesn't include a like count number. You have to count the number of people in the likes data array to get that count.
In the documentation I have only mapped the fields that are exact copies of fields from the facebook api. If data had to be generated or determined from the facebook json, I didn't put it in the mapping as it is not mapped from facebook, but rather calculated from the facebook api response.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: Streams 159
Posted by mfranklin <gi...@git.apache.org>.
Github user mfranklin commented on a diff in the pull request:
https://github.com/apache/incubator-streams/pull/76#discussion_r16984089
--- Diff: streams-contrib/streams-provider-facebook/metadata/facebook_post.mup ---
@@ -0,0 +1,694 @@
+{
--- End diff --
Are you not mapping likes to extensions.likes.count? Also, what are the verbs and actor data mapped from?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---