You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/03/22 09:46:54 UTC

[GitHub] [incubator-mxnet] bartekkuncer opened a new pull request #20070: Fix oneDNN feature name in MxNET

bartekkuncer opened a new pull request #20070:
URL: https://github.com/apache/incubator-mxnet/pull/20070


   ## Description ##
   Solves https://github.com/apache/incubator-mxnet/issues/20069.
   
   ## Checklist ##
   ### Changes ###
   - [ ] Changed MxNET feature name from MKLDNN to ONEDNN
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] EnricoMi commented on pull request #20070: Fix oneDNN feature name in MxNET

Posted by GitBox <gi...@apache.org>.
EnricoMi commented on pull request #20070:
URL: https://github.com/apache/incubator-mxnet/pull/20070#issuecomment-804002403


   @bartekkuncer looks good, thanks!
   
   There are still plenty of `MKLDNN` occurrences in docs and sources. This renaming is really touching everything.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20070: Fix oneDNN feature name in MxNET

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20070:
URL: https://github.com/apache/incubator-mxnet/pull/20070#issuecomment-803923199


   Hey @bartekkuncer , Thanks for submitting the PR 
   All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands: 
   - To trigger all jobs: @mxnet-bot run ci [all] 
   - To trigger specific jobs: @mxnet-bot run ci [job1, job2] 
   *** 
   **CI supported jobs**: [miscellaneous, unix-cpu, windows-cpu, centos-cpu, clang, centos-gpu, unix-gpu, edge, windows-gpu, website, sanity]
   *** 
   _Note_: 
    Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin. 
   All CI tests must pass before the PR can be merged. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #20070: Fix oneDNN feature name in MxNET

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #20070:
URL: https://github.com/apache/incubator-mxnet/pull/20070#issuecomment-804005351


   > There are still plenty of `MKLDNN` occurrences in docs and sources. This renaming is really touching everything.
   
   @EnricoMi That is true, therefore as of now we wanted to stick to changing only major build and runtime flag names and as soon as oneDNN will update its API from dnnl we will try to unify all the names on master to oneDNN to avoid further confusion.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] bartekkuncer commented on pull request #20070: Fix oneDNN feature name in MxNET

Posted by GitBox <gi...@apache.org>.
bartekkuncer commented on pull request #20070:
URL: https://github.com/apache/incubator-mxnet/pull/20070#issuecomment-805739390


   @leezu @szha Please help with the merge :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] szha merged pull request #20070: Fix oneDNN feature name in MxNET

Posted by GitBox <gi...@apache.org>.
szha merged pull request #20070:
URL: https://github.com/apache/incubator-mxnet/pull/20070


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org