You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/07/30 21:34:19 UTC

[GitHub] [pulsar] bharanic-dev opened a new pull request #11522: [Issue 11521] [managed-ledger] Fix NPE in managed-ledger read callback.

bharanic-dev opened a new pull request #11522:
URL: https://github.com/apache/pulsar/pull/11522


   Fixes #11521 
   
   ### Motivation
   
   Under certain circumstances, NPE exception is seen in broker logs.
   
   ### Modifications
   
   From code inspection, there appears to be a race condition between the execution of following line (which is executed asynchronously):
   
   https://github.com/apache/pulsar/blob/3cd4f368abd93c229d69f77049edc95b5c1a3071/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/OpReadEntry.java#L97
   
   and the following line:
   
   https://github.com/apache/pulsar/blob/3cd4f368abd93c229d69f77049edc95b5c1a3071/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/OpReadEntry.java#L127
   
   Fix is to remove the extraneous call to recycle().
   
   ### Verifying this change
   
   - [x] Make sure that the change passes the CI checks.
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ### Documentation
   
   This is a bug fix, there is no documentation impact.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] bharanic-dev closed pull request #11522: [Issue 11521] [managed-ledger] Fix NPE in managed-ledger read callback.

Posted by GitBox <gi...@apache.org>.
bharanic-dev closed pull request #11522:
URL: https://github.com/apache/pulsar/pull/11522


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org