You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "amaliujia (via GitHub)" <gi...@apache.org> on 2023/04/24 15:35:30 UTC
[GitHub] [spark] amaliujia opened a new pull request, #40931: [SPARK-43265] Move Error framework to a common utils module
amaliujia opened a new pull request, #40931:
URL: https://github.com/apache/spark/pull/40931
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Move Error framework to a common utils module so that we can share it between Spark and Spark Connect without introducing heavy dependencies on Spark Connect module.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Reduce Dependencies on Spark Connect.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Error framework is internally API so this should be fine.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
Existing UT.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on pull request #40931: [SPARK-43265] Move Error framework to a common utils module
Posted by "amaliujia (via GitHub)" <gi...@apache.org>.
amaliujia commented on PR #40931:
URL: https://github.com/apache/spark/pull/40931#issuecomment-1521157761
`continuous-integration/appveyor/pr` seems to be stuck.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on pull request #40931: [SPARK-43265] Move Error framework to a common utils module
Posted by "amaliujia (via GitHub)" <gi...@apache.org>.
amaliujia commented on PR #40931:
URL: https://github.com/apache/spark/pull/40931#issuecomment-1522857821
@LuciferYang thank you!
@cloud-fan then probably it goes back to what I did last time. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on a diff in pull request #40931: [SPARK-43265] Move Error framework to a common utils module
Posted by "amaliujia (via GitHub)" <gi...@apache.org>.
amaliujia commented on code in PR #40931:
URL: https://github.com/apache/spark/pull/40931#discussion_r1176017207
##########
project/MimaExcludes.scala:
##########
@@ -66,6 +66,12 @@ object MimaExcludes {
ProblemFilters.exclude[Problem]("org.sparkproject.spark_core.protobuf.*"),
ProblemFilters.exclude[Problem]("org.apache.spark.status.protobuf.StoreTypes*"),
+ // SPARK-43265: Move Error framework to a common utils module
+ ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.QueryContext"),
+ ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.SparkException"),
+ ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.SparkException$"),
+ ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.SparkThrowable"),
Review Comment:
I don't think I renamed the package name.
This throws from spark-core? Unless spark-core builds the iber jar and this checks the uber jar otherwise it should throw?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on a diff in pull request #40931: [SPARK-43265] Move Error framework to a common utils module
Posted by "amaliujia (via GitHub)" <gi...@apache.org>.
amaliujia commented on code in PR #40931:
URL: https://github.com/apache/spark/pull/40931#discussion_r1176936721
##########
common/utils/src/main/scala/org/apache/spark/JsonProtocol.scala:
##########
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark
+
+import java.io.ByteArrayOutputStream
+import java.nio.charset.StandardCharsets
+
+import com.fasterxml.jackson.core.{JsonEncoding, JsonGenerator}
+import com.fasterxml.jackson.databind.{DeserializationFeature, ObjectMapper}
+import com.fasterxml.jackson.module.scala.DefaultScalaModule
+
+
+private[spark] object JsonProtocolUtil {
Review Comment:
Not sure if I fully understand this idea. Tried to address it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on pull request #40931: [SPARK-43265] Move Error framework to a common utils module
Posted by "amaliujia (via GitHub)" <gi...@apache.org>.
amaliujia commented on PR #40931:
URL: https://github.com/apache/spark/pull/40931#issuecomment-1520990871
ok looks like we also have compatibility checks on Spark-core
```
[error] spark-core: Failed binary compatibility check against org.apache.spark:spark-core_2.12:3.4.0! Found 4 potential problems (filtered 4036)
[error] * interface org.apache.spark.QueryContext does not have a correspondent in current version
[error] filter with: ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.QueryContext")
[error] * class org.apache.spark.SparkException does not have a correspondent in current version
[error] filter with: ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.SparkException")
[error] * object org.apache.spark.SparkException does not have a correspondent in current version
[error] filter with: ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.SparkException$")
[error] * interface org.apache.spark.SparkThrowable does not have a correspondent in current version
[error] filter with: ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.SparkThrowable")
```
Are we ok to update the check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on a diff in pull request #40931: [SPARK-43265] Move Error framework to a common utils module
Posted by "amaliujia (via GitHub)" <gi...@apache.org>.
amaliujia commented on code in PR #40931:
URL: https://github.com/apache/spark/pull/40931#discussion_r1176958568
##########
project/MimaExcludes.scala:
##########
@@ -66,6 +66,12 @@ object MimaExcludes {
ProblemFilters.exclude[Problem]("org.sparkproject.spark_core.protobuf.*"),
ProblemFilters.exclude[Problem]("org.apache.spark.status.protobuf.StoreTypes*"),
+ // SPARK-43265: Move Error framework to a common utils module
+ ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.QueryContext"),
+ ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.SparkException"),
+ ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.SparkException$"),
+ ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.SparkThrowable"),
Review Comment:
First all I am thinking existing Mima check just compile the `core` and compare it with previous 3.4.0 so we are moving out classes thus seeing the report is expected.
If we want to do a step further to say even after moving the classes, we can still check the compatibility between core 3.4.0 and `core+common-utils`, probably we can follow what `CheckConnectJvmClientCompatibility` does:
1. Pre-run a command to compile a jar that include both `core` and `common-util` (not sure if SBT can do this. The least is we can unzip jar files and re-zip the combined one).
2. The new suite locates the jar from 1., and then also find the 3.4.0 jar.
3. Then the suite compare two jars.
However I am not sure if we want to go to this path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on a diff in pull request #40931: [SPARK-43265] Move Error framework to a common utils module
Posted by "amaliujia (via GitHub)" <gi...@apache.org>.
amaliujia commented on code in PR #40931:
URL: https://github.com/apache/spark/pull/40931#discussion_r1175520012
##########
common/utils/src/main/scala/org/apache/spark/SparkThrowableHelper.scala:
##########
@@ -34,7 +33,7 @@ private[spark] object ErrorMessageFormat extends Enumeration {
*/
private[spark] object SparkThrowableHelper {
val errorReader = new ErrorClassesJsonReader(
- Seq(Utils.getSparkClassLoader.getResource("error/error-classes.json")))
+ Seq(getClass.getClassLoader.getResource("error/error-classes.json")))
Review Comment:
Yes Utils is a bit big and I need to tackle that separately with a strategy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] hvanhovell closed pull request #40931: [SPARK-43265] Move Error framework to a common utils module
Posted by "hvanhovell (via GitHub)" <gi...@apache.org>.
hvanhovell closed pull request #40931: [SPARK-43265] Move Error framework to a common utils module
URL: https://github.com/apache/spark/pull/40931
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #40931: [SPARK-43265] Move Error framework to a common utils module
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #40931:
URL: https://github.com/apache/spark/pull/40931#discussion_r1176019274
##########
common/utils/src/main/scala/org/apache/spark/SparkException.scala:
##########
@@ -18,14 +18,13 @@
package org.apache.spark
import java.io.FileNotFoundException
+import java.nio.file.FileAlreadyExistsException
import java.sql.{SQLException, SQLFeatureNotSupportedException}
import java.time.DateTimeException
import java.util.ConcurrentModificationException
import scala.collection.JavaConverters._
-import org.apache.hadoop.fs.FileAlreadyExistsException
Review Comment:
is this a breaking change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] hvanhovell commented on a diff in pull request #40931: [SPARK-43265] Move Error framework to a common utils module
Posted by "hvanhovell (via GitHub)" <gi...@apache.org>.
hvanhovell commented on code in PR #40931:
URL: https://github.com/apache/spark/pull/40931#discussion_r1175496791
##########
common/utils/src/main/scala/org/apache/spark/SparkThrowableHelper.scala:
##########
@@ -34,7 +33,7 @@ private[spark] object ErrorMessageFormat extends Enumeration {
*/
private[spark] object SparkThrowableHelper {
val errorReader = new ErrorClassesJsonReader(
- Seq(Utils.getSparkClassLoader.getResource("error/error-classes.json")))
+ Seq(getClass.getClassLoader.getResource("error/error-classes.json")))
Review Comment:
We should move part of the `Utils` as well. We should do that in a follow-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #40931: [SPARK-43265] Move Error framework to a common utils module
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #40931:
URL: https://github.com/apache/spark/pull/40931#discussion_r1176015036
##########
project/MimaExcludes.scala:
##########
@@ -66,6 +66,12 @@ object MimaExcludes {
ProblemFilters.exclude[Problem]("org.sparkproject.spark_core.protobuf.*"),
ProblemFilters.exclude[Problem]("org.apache.spark.status.protobuf.StoreTypes*"),
+ // SPARK-43265: Move Error framework to a common utils module
+ ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.QueryContext"),
+ ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.SparkException"),
+ ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.SparkException$"),
+ ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.SparkThrowable"),
Review Comment:
Did we rename the package? Otherwise it should be still binary compatible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #40931: [SPARK-43265] Move Error framework to a common utils module
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #40931:
URL: https://github.com/apache/spark/pull/40931#issuecomment-1522820195
> @amaliujia @cloud-fan
>
> https://github.com/apache/spark/blob/b461cdea92ea08ce39bb3c9d733f0af7c56abf8d/project/SparkBuild.scala#L404-L407
>
> should add `commonUtils` to this Seq now due to 3.4.0 no `common-utils` module:
>
> ```
> [error] sbt.librarymanagement.ResolveException: Error downloading org.apache.spark:spark-common-utils_2.12:3.4.0
> [error] Not found
> [error] Not found
> [error] not found: /Users/yangjie01/.ivy2/local/org.apache.spark/spark-common-utils_2.12/3.4.0/ivys/ivy.xml
> [error] not found: https://repo1.maven.org/maven2/org/apache/spark/spark-common-utils_2.12/3.4.0/spark-common-utils_2.12-3.4.0.pom
> [error] at lmcoursier.CoursierDependencyResolution.unresolvedWarningOrThrow(CoursierDependencyResolution.scala:344)
> [error] at lmcoursier.CoursierDependencyResolution.$anonfun$update$38(CoursierDependencyResolution.scala:313)
> [error] at scala.util.Either$LeftProjection.map(Either.scala:573)
> [error] at lmcoursier.CoursierDependencyResolution.update(CoursierDependencyResolution.scala:313)
> [error] at sbt.librarymanagement.DependencyResolution.update(DependencyResolution.scala:60)
> [error] at sbt.internal.LibraryManagement$.resolve$1(LibraryManagement.scala:59)
> [error] at sbt.internal.LibraryManagement$.$anonfun$cachedUpdate$12(LibraryManagement.scala:133)
> [error] at sbt.util.Tracked$.$anonfun$lastOutput$1(Tracked.scala:73)
> [error] at sbt.internal.LibraryManagement$.$anonfun$cachedUpdate$20(LibraryManagement.scala:146)
> [error] at scala.util.control.Exception$Catch.apply(Exception.scala:228)
> [error] at sbt.internal.LibraryManagement$.$anonfun$cachedUpdate$11(LibraryManagement.scala:146)
> [error] at sbt.internal.LibraryManagement$.$anonfun$cachedUpdate$11$adapted(LibraryManagement.scala:127)
> [error] at sbt.util.Tracked$.$anonfun$inputChangedW$1(Tracked.scala:219)
> [error] at sbt.internal.LibraryManagement$.cachedUpdate(LibraryManagement.scala:160)
> [error] at sbt.Classpaths$.$anonfun$updateTask0$1(Defaults.scala:3687)
> [error] at scala.Function1.$anonfun$compose$1(Function1.scala:49)
> [error] at sbt.internal.util.$tilde$greater.$anonfun$$u2219$1(TypeFunctions.scala:62)
> [error] at sbt.std.Transform$$anon$4.work(Transform.scala:68)
> [error] at sbt.Execute.$anonfun$submit$2(Execute.scala:282)
> [error] at sbt.internal.util.ErrorHandling$.wideConvert(ErrorHandling.scala:23)
> [error] at sbt.Execute.work(Execute.scala:291)
> [error] at sbt.Execute.$anonfun$submit$1(Execute.scala:282)
> [error] at sbt.ConcurrentRestrictions$$anon$4.$anonfun$submitValid$1(ConcurrentRestrictions.scala:265)
> [error] at sbt.CompletionService$$anon$2.call(CompletionService.scala:64)
> [error] at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> [error] at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> [error] at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> [error] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> [error] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> [error] at java.lang.Thread.run(Thread.java:750)
> [error] (oldDeps / update) sbt.librarymanagement.ResolveException: Error downloading org.apache.spark:spark-common-utils_2.12:3.4.0
> [error] Not found
> [error] Not found
> [error] not found: /Users/yangjie01/.ivy2/local/org.apache.spark/spark-common-utils_2.12/3.4.0/ivys/ivy.xml
> [error] not found: https://repo1.maven.org/maven2/org/apache/spark/spark-common-utils_2.12/3.4.0/spark-common-utils_2.12-3.4.0.pom
> ```
with this change and rebase the code, then run the mima check:
```
[warn] multiple main classes detected: run 'show discoveredMainClasses' to see the list
[info] spark-examples: mimaPreviousArtifacts not set, not analyzing binary compatibility
[error] spark-core: Failed binary compatibility check against org.apache.spark:spark-core_2.12:3.4.0! Found 4 potential problems (filtered 4035)
[error] * interface org.apache.spark.QueryContext does not have a correspondent in current version
[error] filter with: ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.QueryContext")
[error] * class org.apache.spark.SparkException does not have a correspondent in current version
[error] filter with: ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.SparkException")
[error] * object org.apache.spark.SparkException does not have a correspondent in current version
[error] filter with: ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.SparkException$")
[error] * interface org.apache.spark.SparkThrowable does not have a correspondent in current version
[error] filter with: ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.SparkThrowable")
[error] java.lang.RuntimeException: Failed binary compatibility check against org.apache.spark:spark-core_2.12:3.4.0! Found 4 potential problems (filtered 4035)
[error] at scala.sys.package$.error(package.scala:30)
[error] at com.typesafe.tools.mima.plugin.SbtMima$.reportModuleErrors(SbtMima.scala:89)
[error] at com.typesafe.tools.mima.plugin.MimaPlugin$.$anonfun$projectSettings$2(MimaPlugin.scala:36)
[error] at com.typesafe.tools.mima.plugin.MimaPlugin$.$anonfun$projectSettings$2$adapted(MimaPlugin.scala:26)
[error] at scala.collection.Iterator.foreach(Iterator.scala:943)
[error] at scala.collection.Iterator.foreach$(Iterator.scala:943)
[error] at scala.collection.AbstractIterator.foreach(Iterator.scala:1431)
[error] at com.typesafe.tools.mima.plugin.MimaPlugin$.$anonfun$projectSettings$1(MimaPlugin.scala:26)
[error] at com.typesafe.tools.mima.plugin.MimaPlugin$.$anonfun$projectSettings$1$adapted(MimaPlugin.scala:25)
[error] at scala.Function1.$anonfun$compose$1(Function1.scala:49)
[error] at sbt.internal.util.$tilde$greater.$anonfun$$u2219$1(TypeFunctions.scala:62)
[error] at sbt.std.Transform$$anon$4.work(Transform.scala:68)
[error] at sbt.Execute.$anonfun$submit$2(Execute.scala:282)
[error] at sbt.internal.util.ErrorHandling$.wideConvert(ErrorHandling.scala:23)
[error] at sbt.Execute.work(Execute.scala:291)
[error] at sbt.Execute.$anonfun$submit$1(Execute.scala:282)
[error] at sbt.ConcurrentRestrictions$$anon$4.$anonfun$submitValid$1(ConcurrentRestrictions.scala:265)
[error] at sbt.CompletionService$$anon$2.call(CompletionService.scala:64)
[error] at java.util.concurrent.FutureTask.run(FutureTask.java:266)
[error] at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
[error] at java.util.concurrent.FutureTask.run(FutureTask.java:266)
[error] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
[error] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
[error] at java.lang.Thread.run(Thread.java:750)
[error] (core / mimaReportBinaryIssues) Failed binary compatibility check against org.apache.spark:spark-core_2.12:3.4.0! Found 4 potential problems (filtered 4035)
[error] Total time: 92 s (01:32), completed 2023-4-26 13:46:13
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] hvanhovell commented on pull request #40931: [SPARK-43265] Move Error framework to a common utils module
Posted by "hvanhovell (via GitHub)" <gi...@apache.org>.
hvanhovell commented on PR #40931:
URL: https://github.com/apache/spark/pull/40931#issuecomment-1524376979
Merging to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on pull request #40931: [SPARK-43265] Move Error framework to a common utils module
Posted by "amaliujia (via GitHub)" <gi...@apache.org>.
amaliujia commented on PR #40931:
URL: https://github.com/apache/spark/pull/40931#issuecomment-1520666866
This PR fails on
```
Error: running /home/runner/work/spark/spark/dev/mima -Phadoop-3 -Pdocker-integration-tests -Pyarn -Pkubernetes -Pspark-ganglia-lgpl -Pmesos -Pconnect -Phive -Phadoop-cloud -Pkinesis-asl -Phive-thriftserver -Pvolcano ; received return code 1
```
but there is no error messages about how to fix. I run this locally which output nothing as well.
Stuck on mima stuff now,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on a diff in pull request #40931: [SPARK-43265] Move Error framework to a common utils module
Posted by "amaliujia (via GitHub)" <gi...@apache.org>.
amaliujia commented on code in PR #40931:
URL: https://github.com/apache/spark/pull/40931#discussion_r1176017207
##########
project/MimaExcludes.scala:
##########
@@ -66,6 +66,12 @@ object MimaExcludes {
ProblemFilters.exclude[Problem]("org.sparkproject.spark_core.protobuf.*"),
ProblemFilters.exclude[Problem]("org.apache.spark.status.protobuf.StoreTypes*"),
+ // SPARK-43265: Move Error framework to a common utils module
+ ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.QueryContext"),
+ ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.SparkException"),
+ ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.SparkException$"),
+ ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.SparkThrowable"),
Review Comment:
I don't think I renamed the package name.
This throws from spark-core? Unless spark-core builds the uber jar and this checks the uber jar otherwise it should throw?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #40931: [SPARK-43265] Move Error framework to a common utils module
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #40931:
URL: https://github.com/apache/spark/pull/40931#issuecomment-1522775572
Hi @LuciferYang , do you have any idea why mima fails for this PR? The error message says nothing. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #40931: [SPARK-43265] Move Error framework to a common utils module
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #40931:
URL: https://github.com/apache/spark/pull/40931#issuecomment-1522815901
@amaliujia @cloud-fan
https://github.com/apache/spark/blob/b461cdea92ea08ce39bb3c9d733f0af7c56abf8d/project/SparkBuild.scala#L405
should add `commonUtils` to this Seq now due to 3.4.0 no `common-utils` module:
```
[error] sbt.librarymanagement.ResolveException: Error downloading org.apache.spark:spark-common-utils_2.12:3.4.0
[error] Not found
[error] Not found
[error] not found: /Users/yangjie01/.ivy2/local/org.apache.spark/spark-common-utils_2.12/3.4.0/ivys/ivy.xml
[error] not found: https://repo1.maven.org/maven2/org/apache/spark/spark-common-utils_2.12/3.4.0/spark-common-utils_2.12-3.4.0.pom
[error] at lmcoursier.CoursierDependencyResolution.unresolvedWarningOrThrow(CoursierDependencyResolution.scala:344)
[error] at lmcoursier.CoursierDependencyResolution.$anonfun$update$38(CoursierDependencyResolution.scala:313)
[error] at scala.util.Either$LeftProjection.map(Either.scala:573)
[error] at lmcoursier.CoursierDependencyResolution.update(CoursierDependencyResolution.scala:313)
[error] at sbt.librarymanagement.DependencyResolution.update(DependencyResolution.scala:60)
[error] at sbt.internal.LibraryManagement$.resolve$1(LibraryManagement.scala:59)
[error] at sbt.internal.LibraryManagement$.$anonfun$cachedUpdate$12(LibraryManagement.scala:133)
[error] at sbt.util.Tracked$.$anonfun$lastOutput$1(Tracked.scala:73)
[error] at sbt.internal.LibraryManagement$.$anonfun$cachedUpdate$20(LibraryManagement.scala:146)
[error] at scala.util.control.Exception$Catch.apply(Exception.scala:228)
[error] at sbt.internal.LibraryManagement$.$anonfun$cachedUpdate$11(LibraryManagement.scala:146)
[error] at sbt.internal.LibraryManagement$.$anonfun$cachedUpdate$11$adapted(LibraryManagement.scala:127)
[error] at sbt.util.Tracked$.$anonfun$inputChangedW$1(Tracked.scala:219)
[error] at sbt.internal.LibraryManagement$.cachedUpdate(LibraryManagement.scala:160)
[error] at sbt.Classpaths$.$anonfun$updateTask0$1(Defaults.scala:3687)
[error] at scala.Function1.$anonfun$compose$1(Function1.scala:49)
[error] at sbt.internal.util.$tilde$greater.$anonfun$$u2219$1(TypeFunctions.scala:62)
[error] at sbt.std.Transform$$anon$4.work(Transform.scala:68)
[error] at sbt.Execute.$anonfun$submit$2(Execute.scala:282)
[error] at sbt.internal.util.ErrorHandling$.wideConvert(ErrorHandling.scala:23)
[error] at sbt.Execute.work(Execute.scala:291)
[error] at sbt.Execute.$anonfun$submit$1(Execute.scala:282)
[error] at sbt.ConcurrentRestrictions$$anon$4.$anonfun$submitValid$1(ConcurrentRestrictions.scala:265)
[error] at sbt.CompletionService$$anon$2.call(CompletionService.scala:64)
[error] at java.util.concurrent.FutureTask.run(FutureTask.java:266)
[error] at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
[error] at java.util.concurrent.FutureTask.run(FutureTask.java:266)
[error] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
[error] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
[error] at java.lang.Thread.run(Thread.java:750)
[error] (oldDeps / update) sbt.librarymanagement.ResolveException: Error downloading org.apache.spark:spark-common-utils_2.12:3.4.0
[error] Not found
[error] Not found
[error] not found: /Users/yangjie01/.ivy2/local/org.apache.spark/spark-common-utils_2.12/3.4.0/ivys/ivy.xml
[error] not found: https://repo1.maven.org/maven2/org/apache/spark/spark-common-utils_2.12/3.4.0/spark-common-utils_2.12-3.4.0.pom
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #40931: [SPARK-43265] Move Error framework to a common utils module
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #40931:
URL: https://github.com/apache/spark/pull/40931#issuecomment-1522803587
Looking
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on pull request #40931: [SPARK-43265] Move Error framework to a common utils module
Posted by "amaliujia (via GitHub)" <gi...@apache.org>.
amaliujia commented on PR #40931:
URL: https://github.com/apache/spark/pull/40931#issuecomment-1520403075
@cloud-fan @hvanhovell
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] hvanhovell commented on a diff in pull request #40931: [SPARK-43265] Move Error framework to a common utils module
Posted by "hvanhovell (via GitHub)" <gi...@apache.org>.
hvanhovell commented on code in PR #40931:
URL: https://github.com/apache/spark/pull/40931#discussion_r1175497831
##########
common/utils/src/main/scala/org/apache/spark/ErrorClassesJSONReader.scala:
##########
@@ -30,6 +29,7 @@ import org.apache.commons.text.StringSubstitutor
import org.apache.spark.annotation.DeveloperApi
+
Review Comment:
Remove line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #40931: [SPARK-43265] Move Error framework to a common utils module
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #40931:
URL: https://github.com/apache/spark/pull/40931#issuecomment-1522920925
Yea we have to exclude it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] hvanhovell commented on a diff in pull request #40931: [SPARK-43265] Move Error framework to a common utils module
Posted by "hvanhovell (via GitHub)" <gi...@apache.org>.
hvanhovell commented on code in PR #40931:
URL: https://github.com/apache/spark/pull/40931#discussion_r1176905013
##########
common/utils/src/main/scala/org/apache/spark/SparkException.scala:
##########
@@ -18,14 +18,13 @@
package org.apache.spark
import java.io.FileNotFoundException
+import java.nio.file.FileAlreadyExistsException
import java.sql.{SQLException, SQLFeatureNotSupportedException}
import java.time.DateTimeException
import java.util.ConcurrentModificationException
import scala.collection.JavaConverters._
-import org.apache.hadoop.fs.FileAlreadyExistsException
Review Comment:
SGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #40931: [SPARK-43265] Move Error framework to a common utils module
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #40931:
URL: https://github.com/apache/spark/pull/40931#discussion_r1176020421
##########
common/utils/src/main/scala/org/apache/spark/JsonProtocol.scala:
##########
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark
+
+import java.io.ByteArrayOutputStream
+import java.nio.charset.StandardCharsets
+
+import com.fasterxml.jackson.core.{JsonEncoding, JsonGenerator}
+import com.fasterxml.jackson.databind.{DeserializationFeature, ObjectMapper}
+import com.fasterxml.jackson.module.scala.DefaultScalaModule
+
+
+private[spark] object JsonProtocolUtil {
Review Comment:
the name could be just `JsonUtils`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] hvanhovell commented on a diff in pull request #40931: [SPARK-43265] Move Error framework to a common utils module
Posted by "hvanhovell (via GitHub)" <gi...@apache.org>.
hvanhovell commented on code in PR #40931:
URL: https://github.com/apache/spark/pull/40931#discussion_r1176662886
##########
common/utils/src/main/scala/org/apache/spark/SparkException.scala:
##########
@@ -18,14 +18,13 @@
package org.apache.spark
import java.io.FileNotFoundException
+import java.nio.file.FileAlreadyExistsException
import java.sql.{SQLException, SQLFeatureNotSupportedException}
import java.time.DateTimeException
import java.util.ConcurrentModificationException
import scala.collection.JavaConverters._
-import org.apache.hadoop.fs.FileAlreadyExistsException
Review Comment:
Sort of. IMO it is better to rely on Java's exceptions than on Hadoop's.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on pull request #40931: [SPARK-43265] Move Error framework to a common utils module
Posted by "amaliujia (via GitHub)" <gi...@apache.org>.
amaliujia commented on PR #40931:
URL: https://github.com/apache/spark/pull/40931#issuecomment-1520961265
Trying to exclude the MIMA check for `common-utils`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #40931: [SPARK-43265] Move Error framework to a common utils module
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #40931:
URL: https://github.com/apache/spark/pull/40931#discussion_r1176020179
##########
common/utils/src/main/scala/org/apache/spark/JsonProtocol.scala:
##########
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark
+
+import java.io.ByteArrayOutputStream
+import java.nio.charset.StandardCharsets
+
+import com.fasterxml.jackson.core.{JsonEncoding, JsonGenerator}
+import com.fasterxml.jackson.databind.{DeserializationFeature, ObjectMapper}
+import com.fasterxml.jackson.module.scala.DefaultScalaModule
+
+
+private[spark] object JsonProtocolUtil {
Review Comment:
should this live in the `org.apache.spark.util` package? and can we call this util function in `org.apache.spark.util.JsonProtocol.toJsonString` to avoid duplicated code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on a diff in pull request #40931: [SPARK-43265] Move Error framework to a common utils module
Posted by "amaliujia (via GitHub)" <gi...@apache.org>.
amaliujia commented on code in PR #40931:
URL: https://github.com/apache/spark/pull/40931#discussion_r1176884611
##########
common/utils/src/main/scala/org/apache/spark/SparkException.scala:
##########
@@ -18,14 +18,13 @@
package org.apache.spark
import java.io.FileNotFoundException
+import java.nio.file.FileAlreadyExistsException
import java.sql.{SQLException, SQLFeatureNotSupportedException}
import java.time.DateTimeException
import java.util.ConcurrentModificationException
import scala.collection.JavaConverters._
-import org.apache.hadoop.fs.FileAlreadyExistsException
Review Comment:
Had a chat offline and we may choose to keep `SparkFileAlreadyExistsException` inside SparkCore since only server/spark engine side needs this exception. And then we do not need to add `hadoop` dependency on the common-utils thus avoid that stuff on Spark Connect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on a diff in pull request #40931: [SPARK-43265] Move Error framework to a common utils module
Posted by "amaliujia (via GitHub)" <gi...@apache.org>.
amaliujia commented on code in PR #40931:
URL: https://github.com/apache/spark/pull/40931#discussion_r1176958568
##########
project/MimaExcludes.scala:
##########
@@ -66,6 +66,12 @@ object MimaExcludes {
ProblemFilters.exclude[Problem]("org.sparkproject.spark_core.protobuf.*"),
ProblemFilters.exclude[Problem]("org.apache.spark.status.protobuf.StoreTypes*"),
+ // SPARK-43265: Move Error framework to a common utils module
+ ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.QueryContext"),
+ ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.SparkException"),
+ ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.SparkException$"),
+ ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.SparkThrowable"),
Review Comment:
First all I am thinking existing Mima check just compile the `core` and compare it with previous 3.4.0 so we are moving out classes thus seeing the report is expected.
If we want to do a step further to say even after moving the classes, we can still check the compatibility between core 3.4.0 and `core+common-utils`, probably we can follow what `CheckConnectJvmClientCompatibility` does:
1. Pre-run a command to compile a jar that include both `core` and `common-util` (not sure if SBT can do this).
2. The new suite locates the jar from 1., and then also find the 3.4.0 jar.
3. Then the suite compare two jars.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] hvanhovell commented on a diff in pull request #40931: [SPARK-43265] Move Error framework to a common utils module
Posted by "hvanhovell (via GitHub)" <gi...@apache.org>.
hvanhovell commented on code in PR #40931:
URL: https://github.com/apache/spark/pull/40931#discussion_r1176669281
##########
project/MimaExcludes.scala:
##########
@@ -66,6 +66,12 @@ object MimaExcludes {
ProblemFilters.exclude[Problem]("org.sparkproject.spark_core.protobuf.*"),
ProblemFilters.exclude[Problem]("org.apache.spark.status.protobuf.StoreTypes*"),
+ // SPARK-43265: Move Error framework to a common utils module
+ ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.QueryContext"),
+ ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.SparkException"),
+ ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.SparkException$"),
+ ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.SparkThrowable"),
Review Comment:
Can we spend a bit more time on this? We are going to move quite a few classes, and it would be great if MiMa works to avoid mistakes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org