You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/07/05 15:03:39 UTC

[GitHub] [hbase] HorizonNet commented on a change in pull request #2016: HBASE-24653 Show snapshot owner on Master WebUI

HorizonNet commented on a change in pull request #2016:
URL: https://github.com/apache/hbase/pull/2016#discussion_r449887464



##########
File path: hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon
##########
@@ -673,6 +675,8 @@ AssignmentManager assignmentManager = master.getAssignmentManager();
         <td><a href="table.jsp?name=<% snapshotTable.getNameAsString() %>"><% snapshotTable.getNameAsString() %></a>
         </td>
         <td><% new Date(snapshotDesc.getCreationTime()) %></td>
+        <td><% snapshotDesc.getOwner() %></td>
+        <td><% snapshotDesc.getTtl() %></td>

Review comment:
       Does it make sense to also check if it is 0 and display `FOREVER` as done in `snapshotsStats.jsp`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org