You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "mdedetrich (via GitHub)" <gi...@apache.org> on 2024/01/14 08:07:19 UTC
[PR] Use scope config for compute-engine auth [incubator-pekko-connectors]
mdedetrich opened a new pull request, #313:
URL: https://github.com/apache/incubator-pekko-connectors/pull/313
Currently when getting Google credentials using the `ComputeEngineCredentials` method, it ignores the [`scopes`](https://github.com/apache/incubator-pekko-connectors/blob/1fe3474d654bf48b0e81011d878e541a32409c93/google-common/src/main/resources/reference.conf#L9) variable.
In the official Google SDK, you can see that it also has the same logic for getting the credentials from `ComputeEngine`, see https://github.com/googleapis/google-auth-library-java/blob/a7a8d7a4102b0b7c1b83791947ccb662f060eca7/oauth2_http/java/com/google/auth/oauth2/ComputeEngineCredentials.java#L193-L199 and https://github.com/googleapis/google-auth-library-java/blob/a7a8d7a4102b0b7c1b83791947ccb662f060eca7/oauth2_http/java/com/google/auth/oauth2/ComputeEngineCredentials.java#L480-L483 (which is the same URI as https://github.com/apache/incubator-pekko-connectors/blob/67eea4f1dc7e9e0931322ef5c07f305e995b0eb2/google-common/src/main/scala/org/apache/pekko/stream/connectors/google/auth/GoogleComputeMetadata.scala#L33-L34
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Use scope config for compute-engine auth [incubator-pekko-connectors]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #313:
URL: https://github.com/apache/incubator-pekko-connectors/pull/313#issuecomment-1911115408
@pjfanning @He-Pin You mind re-reviewing this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Use scope config for compute-engine auth [incubator-pekko-connectors]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #313:
URL: https://github.com/apache/incubator-pekko-connectors/pull/313#issuecomment-1890891264
you'll need something like https://github.com/apache/incubator-pekko-connectors/pull/311/files#diff-5634c415cd8c8504fdb973a3ed092300b43c4b8fc1e184f7249eb29a55511f91R16 to get the mima check to work - v1.0.2-RC1 is current latest tag and this is only in staging repo - this PR looks like it could have a small but non-zero mima footprint
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Use scope config for compute-engine auth [incubator-pekko-connectors]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich merged PR #313:
URL: https://github.com/apache/incubator-pekko-connectors/pull/313
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Use scope config for compute-engine auth [incubator-pekko-connectors]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #313:
URL: https://github.com/apache/incubator-pekko-connectors/pull/313#discussion_r1451689930
##########
google-common/src/main/scala/org/apache/pekko/stream/connectors/google/auth/ComputeEngineCredentials.scala:
##########
@@ -25,18 +25,19 @@ import scala.concurrent.Future
@InternalApi
private[auth] object ComputeEngineCredentials {
- def apply()(implicit system: ClassicActorSystemProvider): Future[Credentials] =
+ def apply(scopes: Set[String])(implicit system: ClassicActorSystemProvider): Future[Credentials] = {
Review Comment:
Add a overloaded apply to keep mima happy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Use scope config for compute-engine auth [incubator-pekko-connectors]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #313:
URL: https://github.com/apache/incubator-pekko-connectors/pull/313#discussion_r1451690544
##########
google-common/src/main/scala/org/apache/pekko/stream/connectors/google/auth/ComputeEngineCredentials.scala:
##########
@@ -25,18 +25,19 @@ import scala.concurrent.Future
@InternalApi
private[auth] object ComputeEngineCredentials {
- def apply()(implicit system: ClassicActorSystemProvider): Future[Credentials] =
+ def apply(scopes: Set[String])(implicit system: ClassicActorSystemProvider): Future[Credentials] = {
Review Comment:
This is internal API and its `private`. MiMa is failing for other reasons (see https://github.com/apache/incubator-pekko-connectors/pull/314#issuecomment-1890890839)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org