You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/03/31 01:57:19 UTC
[GitHub] [incubator-apisix] gxthrj opened a new pull request #1372: modify:
specify pool_size and backlog for plugin
gxthrj opened a new pull request #1372: modify: specify pool_size and backlog for plugin
URL: https://github.com/apache/incubator-apisix/pull/1372
### specify pool_size and backlog for plugin
### Issues resolved
Fix #1315
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] moonming commented on a change in pull request
#1372: modify: specify pool_size and backlog for plugin
Posted by GitBox <gi...@apache.org>.
moonming commented on a change in pull request #1372: modify: specify pool_size and backlog for plugin
URL: https://github.com/apache/incubator-apisix/pull/1372#discussion_r400936369
##########
File path: lua/apisix/plugins/limit-count/limit-count-redis.lua
##########
@@ -20,6 +20,8 @@ local resty_lock = require("resty.lock")
local assert = assert
local setmetatable = setmetatable
local tostring = tostring
+local options = {}
+
Review comment:
do we need top level var?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] membphis commented on issue #1372: modify:
specify pool_size and backlog for plugin
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #1372: modify: specify pool_size and backlog for plugin
URL: https://github.com/apache/incubator-apisix/pull/1372#issuecomment-606641992
@spacewander @moonming please take a look when you have time, many thx
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] gxthrj commented on a change in pull request
#1372: modify: specify pool_size and backlog for plugin
Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #1372: modify: specify pool_size and backlog for plugin
URL: https://github.com/apache/incubator-apisix/pull/1372#discussion_r400817477
##########
File path: lua/apisix/plugins/limit-count.lua
##########
@@ -82,6 +88,8 @@ function _M.check_schema(conf)
conf.redis_port = conf.redis_port or 6379
conf.redis_timeout = conf.redis_timeout or 1000
+ conf.redis_pool_size = conf.redis_pool_size or 1000
+ conf.redis_backlog = conf.redis_backlog or 1000
Review comment:
> Please set the backlog to `nil` to disable the feature by default.
> Two reasons:
>
> 1. the backlog feature in cosocket is considered experimental.
> 2. it isn't a smart idea to queue limitation count. This will be make the result incorrect. The operation should be finished ASAP to make the limitation up to date.
thanks，set backlog `nil` by default , done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] moonming commented on a change in pull request
#1372: modify: specify pool_size and backlog for plugin
Posted by GitBox <gi...@apache.org>.
moonming commented on a change in pull request #1372: modify: specify pool_size and backlog for plugin
URL: https://github.com/apache/incubator-apisix/pull/1372#discussion_r400940623
##########
File path: lua/apisix/plugins/limit-count/limit-count-redis.lua
##########
@@ -20,6 +20,8 @@ local resty_lock = require("resty.lock")
local assert = assert
local setmetatable = setmetatable
local tostring = tostring
+local options = {}
+
Review comment:
I think the `options` should be pass from `new` function, just as `conf`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] membphis commented on a change in pull request
#1372: modify: specify pool_size and backlog for plugin
Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #1372: modify: specify pool_size and backlog for plugin
URL: https://github.com/apache/incubator-apisix/pull/1372#discussion_r402054430
##########
File path: lua/apisix/plugins/limit-count/limit-count-redis.lua
##########
@@ -20,6 +20,8 @@ local resty_lock = require("resty.lock")
local assert = assert
local setmetatable = setmetatable
local tostring = tostring
+local options = {}
+
Review comment:
I prefer the current implementation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] gxthrj commented on a change in pull request
#1372: modify: specify pool_size and backlog for plugin
Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #1372: modify: specify pool_size and backlog for plugin
URL: https://github.com/apache/incubator-apisix/pull/1372#discussion_r400604186
##########
File path: lua/apisix/plugins/limit-count/limit-count-redis.lua
##########
@@ -47,7 +47,8 @@ function _M.incoming(self, key)
red:set_timeouts(timeout, timeout, timeout)
- local ok, err = red:connect(conf.redis_host, conf.redis_port or 6379)
+ local options = {pool_size = 1000, backlog = 1000}
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] moonming commented on a change in pull request
#1372: modify: specify pool_size and backlog for plugin
Posted by GitBox <gi...@apache.org>.
moonming commented on a change in pull request #1372: modify: specify pool_size and backlog for plugin
URL: https://github.com/apache/incubator-apisix/pull/1372#discussion_r400604545
##########
File path: lua/apisix/plugins/limit-count/limit-count-redis.lua
##########
@@ -20,6 +20,7 @@ local resty_lock = require("resty.lock")
local assert = assert
local setmetatable = setmetatable
local tostring = tostring
+local options = {pool_size = 1000, backlog = 1000}
Review comment:
hard code options?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] membphis commented on issue #1372: modify:
specify pool_size and backlog for plugin
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #1372: modify: specify pool_size and backlog for plugin
URL: https://github.com/apache/incubator-apisix/pull/1372#issuecomment-606401982
@gxthrj I think we need to update the doc too
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [apisix] moonming closed pull request #1372: modify: specify pool_size and backlog for plugin
Posted by GitBox <gi...@apache.org>.
moonming closed pull request #1372:
URL: https://github.com/apache/apisix/pull/1372
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix] spacewander commented on a change in pull
request #1372: modify: specify pool_size and backlog for plugin
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #1372: modify: specify pool_size and backlog for plugin
URL: https://github.com/apache/incubator-apisix/pull/1372#discussion_r400643075
##########
File path: lua/apisix/plugins/limit-count.lua
##########
@@ -82,6 +88,8 @@ function _M.check_schema(conf)
conf.redis_port = conf.redis_port or 6379
conf.redis_timeout = conf.redis_timeout or 1000
+ conf.redis_pool_size = conf.redis_pool_size or 1000
+ conf.redis_backlog = conf.redis_backlog or 1000
Review comment:
Please set the backlog to `nil` to disable the feature by default.
Two reasons:
1. the backlog feature in cosocket is considered experimental.
2. it isn't a smart idea to queue limitation count. This will be make the result incorrect. The operation should be finished ASAP to make the limitation up to date.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] moonming commented on a change in pull request
#1372: modify: specify pool_size and backlog for plugin
Posted by GitBox <gi...@apache.org>.
moonming commented on a change in pull request #1372: modify: specify pool_size and backlog for plugin
URL: https://github.com/apache/incubator-apisix/pull/1372#discussion_r400941457
##########
File path: lua/apisix/plugins/limit-count/limit-count-redis.lua
##########
@@ -20,6 +20,8 @@ local resty_lock = require("resty.lock")
local assert = assert
local setmetatable = setmetatable
local tostring = tostring
+local options = {}
+
Review comment:
`options` should be processed at compile time, not assembled at run time
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] membphis commented on a change in pull request
#1372: modify: specify pool_size and backlog for plugin
Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #1372: modify: specify pool_size and backlog for plugin
URL: https://github.com/apache/incubator-apisix/pull/1372#discussion_r400609550
##########
File path: lua/apisix/plugins/limit-count/limit-count-redis.lua
##########
@@ -20,6 +20,7 @@ local resty_lock = require("resty.lock")
local assert = assert
local setmetatable = setmetatable
local tostring = tostring
+local options = {pool_size = 1000, backlog = 1000}
Review comment:
yes, that is much better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] gxthrj commented on a change in pull request
#1372: modify: specify pool_size and backlog for plugin
Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #1372: modify: specify pool_size and backlog for plugin
URL: https://github.com/apache/incubator-apisix/pull/1372#discussion_r400608964
##########
File path: lua/apisix/plugins/limit-count/limit-count-redis.lua
##########
@@ -20,6 +20,7 @@ local resty_lock = require("resty.lock")
local assert = assert
local setmetatable = setmetatable
local tostring = tostring
+local options = {pool_size = 1000, backlog = 1000}
Review comment:
> hard code options?
Maybe I can specify pool_size and backlog from plugin ` limit-count`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] moonming commented on a change in pull request
#1372: modify: specify pool_size and backlog for plugin
Posted by GitBox <gi...@apache.org>.
moonming commented on a change in pull request #1372: modify: specify pool_size and backlog for plugin
URL: https://github.com/apache/incubator-apisix/pull/1372#discussion_r400934957
##########
File path: lua/apisix/plugins/limit-count/limit-count-redis.lua
##########
@@ -47,7 +49,9 @@ function _M.incoming(self, key)
red:set_timeouts(timeout, timeout, timeout)
- local ok, err = red:connect(conf.redis_host, conf.redis_port or 6379)
+ options.pool_size = conf.redis_pool_size
+ options.backlog = conf.redis_backlog
+ local ok, err = red:connect(conf.redis_host, conf.redis_port or 6379, options)
Review comment:
I think `conf.redis_port` is enough, ` or 6379` is useless.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] moonming commented on issue #1372: modify:
specify pool_size and backlog for plugin
Posted by GitBox <gi...@apache.org>.
moonming commented on issue #1372: modify: specify pool_size and backlog for plugin
URL: https://github.com/apache/incubator-apisix/pull/1372#issuecomment-606643807
need add doc and test cases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] gxthrj commented on a change in pull request
#1372: modify: specify pool_size and backlog for plugin
Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #1372: modify: specify pool_size and backlog for plugin
URL: https://github.com/apache/incubator-apisix/pull/1372#discussion_r401369512
##########
File path: lua/apisix/plugins/limit-count/limit-count-redis.lua
##########
@@ -47,7 +49,9 @@ function _M.incoming(self, key)
red:set_timeouts(timeout, timeout, timeout)
- local ok, err = red:connect(conf.redis_host, conf.redis_port or 6379)
+ options.pool_size = conf.redis_pool_size
+ options.backlog = conf.redis_backlog
+ local ok, err = red:connect(conf.redis_host, conf.redis_port or 6379, options)
Review comment:
yes, removed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] gxthrj commented on a change in pull request
#1372: modify: specify pool_size and backlog for plugin
Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #1372: modify: specify pool_size and backlog for plugin
URL: https://github.com/apache/incubator-apisix/pull/1372#discussion_r400815509
##########
File path: lua/apisix/plugins/limit-count.lua
##########
@@ -51,6 +51,12 @@ local schema = {
redis_timeout = {
type = "integer", minimum = 1
},
+ redis_pool_size = {
+ type = "ingeger", minimum = 100
Review comment:
-_-|| done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] membphis commented on a change in pull request
#1372: modify: specify pool_size and backlog for plugin
Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #1372: modify: specify pool_size and backlog for plugin
URL: https://github.com/apache/incubator-apisix/pull/1372#discussion_r400620851
##########
File path: lua/apisix/plugins/limit-count.lua
##########
@@ -82,6 +88,8 @@ function _M.check_schema(conf)
conf.redis_port = conf.redis_port or 6379
conf.redis_timeout = conf.redis_timeout or 1000
+ conf.redis_pool_size = conf.redis_pool_size or 1000
Review comment:
we need to add a test case to confirm this step.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] membphis commented on a change in pull request
#1372: modify: specify pool_size and backlog for plugin
Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #1372: modify: specify pool_size and backlog for plugin
URL: https://github.com/apache/incubator-apisix/pull/1372#discussion_r400599270
##########
File path: lua/apisix/plugins/limit-count/limit-count-redis.lua
##########
@@ -47,7 +47,8 @@ function _M.incoming(self, key)
red:set_timeouts(timeout, timeout, timeout)
- local ok, err = red:connect(conf.redis_host, conf.redis_port or 6379)
+ local options = {pool_size = 1000, backlog = 1000}
Review comment:
Module top level local variables for reusing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] membphis commented on a change in pull request
#1372: modify: specify pool_size and backlog for plugin
Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #1372: modify: specify pool_size and backlog for plugin
URL: https://github.com/apache/incubator-apisix/pull/1372#discussion_r400645276
##########
File path: lua/apisix/plugins/limit-count.lua
##########
@@ -82,6 +88,8 @@ function _M.check_schema(conf)
conf.redis_port = conf.redis_port or 6379
conf.redis_timeout = conf.redis_timeout or 1000
+ conf.redis_pool_size = conf.redis_pool_size or 1000
+ conf.redis_backlog = conf.redis_backlog or 1000
Review comment:
Thank you for reminding @spacewander
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] membphis commented on issue #1372: modify:
specify pool_size and backlog for plugin
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #1372: modify: specify pool_size and backlog for plugin
URL: https://github.com/apache/incubator-apisix/pull/1372#issuecomment-610194841
@gxthrj This branch has conflicts that must be resolved, we need to rebase it first
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] gxthrj commented on a change in pull request
#1372: modify: specify pool_size and backlog for plugin
Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #1372: modify: specify pool_size and backlog for plugin
URL: https://github.com/apache/incubator-apisix/pull/1372#discussion_r400619714
##########
File path: lua/apisix/plugins/limit-count/limit-count-redis.lua
##########
@@ -20,6 +20,7 @@ local resty_lock = require("resty.lock")
local assert = assert
local setmetatable = setmetatable
local tostring = tostring
+local options = {pool_size = 1000, backlog = 1000}
Review comment:
> hard code options?
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] membphis commented on a change in pull request
#1372: modify: specify pool_size and backlog for plugin
Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #1372: modify: specify pool_size and backlog for plugin
URL: https://github.com/apache/incubator-apisix/pull/1372#discussion_r400645863
##########
File path: lua/apisix/plugins/limit-count.lua
##########
@@ -51,6 +51,12 @@ local schema = {
redis_timeout = {
type = "integer", minimum = 1
},
+ redis_pool_size = {
+ type = "ingeger", minimum = 100
Review comment:
typo: `ingeger `
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] gxthrj commented on a change in pull request
#1372: modify: specify pool_size and backlog for plugin
Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #1372: modify: specify pool_size and backlog for plugin
URL: https://github.com/apache/incubator-apisix/pull/1372#discussion_r400604186
##########
File path: lua/apisix/plugins/limit-count/limit-count-redis.lua
##########
@@ -47,7 +47,8 @@ function _M.incoming(self, key)
red:set_timeouts(timeout, timeout, timeout)
- local ok, err = red:connect(conf.redis_host, conf.redis_port or 6379)
+ local options = {pool_size = 1000, backlog = 1000}
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] gxthrj commented on a change in pull request
#1372: modify: specify pool_size and backlog for plugin
Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #1372: modify: specify pool_size and backlog for plugin
URL: https://github.com/apache/incubator-apisix/pull/1372#discussion_r400604291
##########
File path: lua/apisix/plugins/limit-count/limit-count-redis.lua
##########
@@ -47,7 +47,8 @@ function _M.incoming(self, key)
red:set_timeouts(timeout, timeout, timeout)
- local ok, err = red:connect(conf.redis_host, conf.redis_port or 6379)
+ local options = {pool_size = 1000, backlog = 1000}
Review comment:
> Module top level local variables for reusing.
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] moonming commented on pull request #1372: modify: specify pool_size and backlog for plugin
Posted by GitBox <gi...@apache.org>.
moonming commented on pull request #1372:
URL: https://github.com/apache/incubator-apisix/pull/1372#issuecomment-661608572
@gxthrj any update?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix] membphis commented on pull request #1372: modify: specify pool_size and backlog for plugin
Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #1372:
URL: https://github.com/apache/incubator-apisix/pull/1372#issuecomment-637285987
@gxthrj please add a test case for this PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-apisix] gxthrj commented on pull request #1372: modify: specify pool_size and backlog for plugin
Posted by GitBox <gi...@apache.org>.
gxthrj commented on pull request #1372:
URL: https://github.com/apache/incubator-apisix/pull/1372#issuecomment-661612531
> @gxthrj any update?
still needed rebase and some test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org