You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "bryancall (via GitHub)" <gi...@apache.org> on 2024/03/06 23:31:57 UTC
[PR] Fixed asan issue with global SSLAPIHooks not being deleted on shutdown [trafficserver]
bryancall opened a new pull request, #11142:
URL: https://github.com/apache/trafficserver/pull/11142
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed asan issue with global SSLAPIHooks not being deleted on shutdown [trafficserver]
Posted by "JosiahWI (via GitHub)" <gi...@apache.org>.
JosiahWI commented on PR #11142:
URL: https://github.com/apache/trafficserver/pull/11142#issuecomment-2026419954
If `init_global_ssl_hooks()` was called multiple times without the null check, that would probably leak memory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed asan issue with global SSLAPIHooks not being deleted on shutdown [trafficserver]
Posted by "JosiahWI (via GitHub)" <gi...@apache.org>.
JosiahWI commented on PR #11142:
URL: https://github.com/apache/trafficserver/pull/11142#issuecomment-2025865623
Was the root problem the multiple allocations of `g_ssl_hooks` overwriting the old ones and leaking them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed asan issue with global SSLAPIHooks not being deleted on shutdown [trafficserver]
Posted by "brbzull0 (via GitHub)" <gi...@apache.org>.
brbzull0 commented on PR #11142:
URL: https://github.com/apache/trafficserver/pull/11142#issuecomment-1983163083
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed asan issue with global SSLAPIHooks not being deleted on shutdown [trafficserver]
Posted by "JosiahWI (via GitHub)" <gi...@apache.org>.
JosiahWI commented on PR #11142:
URL: https://github.com/apache/trafficserver/pull/11142#issuecomment-2025866175
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed asan issue with global SSLAPIHooks not being deleted on shutdown [trafficserver]
Posted by "bryancall (via GitHub)" <gi...@apache.org>.
bryancall commented on PR #11142:
URL: https://github.com/apache/trafficserver/pull/11142#issuecomment-2048159714
Closing - better fix is in #11224
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed asan issue with global SSLAPIHooks not being deleted on shutdown [trafficserver]
Posted by "bryancall (via GitHub)" <gi...@apache.org>.
bryancall commented on PR #11142:
URL: https://github.com/apache/trafficserver/pull/11142#issuecomment-1982195661
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed asan issue with global SSLAPIHooks not being deleted on shutdown [trafficserver]
Posted by "bryancall (via GitHub)" <gi...@apache.org>.
bryancall commented on PR #11142:
URL: https://github.com/apache/trafficserver/pull/11142#issuecomment-1984737067
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed asan issue with global SSLAPIHooks not being deleted on shutdown [trafficserver]
Posted by "bryancall (via GitHub)" <gi...@apache.org>.
bryancall commented on PR #11142:
URL: https://github.com/apache/trafficserver/pull/11142#issuecomment-1983949071
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed asan issue with global SSLAPIHooks not being deleted on shutdown [trafficserver]
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on PR #11142:
URL: https://github.com/apache/trafficserver/pull/11142#issuecomment-2025999815
@JosiahWI and I have talked about this leaked resource in the past. Note that this comment, and another related global hook, has had this comment forever in the corresponding header file:
https://github.com/apache/trafficserver/blob/0fef5a3450a4aaf21a465300d0e15c2d4d43f5fa/include/iocore/net/SSLAPIHooks.h#L57
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed asan issue with global SSLAPIHooks not being deleted on shutdown [trafficserver]
Posted by "bryancall (via GitHub)" <gi...@apache.org>.
bryancall commented on PR #11142:
URL: https://github.com/apache/trafficserver/pull/11142#issuecomment-2026189307
> Was the root problem the multiple allocations of `g_ssl_hooks` overwriting the old ones and leaking them?
The problem was with deleting `g_ssl_hooks` on shutdown.
I saw that we were calling init_global_ssl_hooks() multiple time in autest, so I put the nullptr check there. I also assumed we also needed to delete the global, but it looks like something might already be cleaning it up? According to @bneradt comment it should be leaking, but I am not seeing that myself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed asan issue with global SSLAPIHooks not being deleted on shutdown [trafficserver]
Posted by "bryancall (via GitHub)" <gi...@apache.org>.
bryancall closed pull request #11142: Fixed asan issue with global SSLAPIHooks not being deleted on shutdown
URL: https://github.com/apache/trafficserver/pull/11142
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org