Re: [PR] feat(dashboard): expand all chart descriptions [superset]

["rusackas (via GitHub)" <gi...@apache.org>]

rusackas commented on PR #32958:
URL: https://github.com/apache/superset/pull/32958#issuecomment-4909686318

   @castodius pulled the actual CI logs on this: `lint-frontend` is genuinely broken, not just codecov noise. `tsc` fails with `expandAllSlices` missing from `SaveModalProps` because `useHeaderActionsDropdownMenu.tsx` never got updated to pass it - the branch doesn't compile as pushed.
   
   Also still true: `TOGGLE_EXPAND_SLICE` flips `undefined` to `true`, so with `expand_all_slices` on, clicking "hide description" on a chart with no explicit override doesn't hide anything until you click it twice. That's the same thing you asked about in your very first comment here.
   
   The bot threads about the stringified `"false"` in the test fixtures are pointing at that same class of bug (string vs boolean coercion), worth sorting alongside it. Fix those two and I'll re-review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org