[jira] [Commented] (MINIFICPP-582) Readme constraints not defined in bootstrap

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MINIFICPP-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16565461#comment-16565461 ] 

ASF GitHub Bot commented on MINIFICPP-582:
------------------------------------------

Github user apiri commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/383#discussion_r206919848
  
    --- Diff: linux.sh ---
    @@ -0,0 +1,40 @@
    +# Licensed to the Apache Software Foundation (ASF) under one
    +# or more contributor license agreements.  See the NOTICE file
    +# distributed with this work for additional information
    +# regarding copyright ownership.  The ASF licenses this file
    +# to you under the Apache License, Version 2.0 (the
    +# "License"); you may not use this file except in compliance
    +# with the License.  You may obtain a copy of the License at
    +#
    +#   http://www.apache.org/licenses/LICENSE-2.0
    +#
    +# Unless required by applicable law or agreed to in writing,
    +# software distributed under the License is distributed on an
    +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +# KIND, either express or implied.  See the License for the
    +# specific language governing permissions and limitations
    +# under the License.
    +#!/bin/bash
    +verify_gcc_enable(){
    +  feature="$1"
    +  feature_status=${!1}
    +  if [ "$feature" = "BUSTACHE_ENABLED" ]; then
    --- End diff --
    
    Should we also perform a check for Lua given its constraints in the README?


> Readme constraints not defined in bootstrap
> -------------------------------------------
>
>                 Key: MINIFICPP-582
>                 URL: https://issues.apache.org/jira/browse/MINIFICPP-582
>             Project: NiFi MiNiFi C++
>          Issue Type: Bug
>            Reporter: Mr TheSegfault
>            Assignee: Mr TheSegfault
>            Priority: Blocker
>             Fix For: 0.6.0
>
>
> MINIFICPP-427 and others have added some constraints that aren't captured in the bootstrap. We can make these changes in this ticket 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)