You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2017/03/25 01:20:50 UTC
[kudu-CR] fs: move LBM tests to new test file
Hello Mike Percy, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/6485
to review the following change.
Change subject: fs: move LBM tests to new test file
......................................................................
fs: move LBM tests to new test file
They don't share much with block_manager-test, and I plan on adding more, so
this separation makes sense.
The only substantive change was to the ReopenBlockManager() signature in the
new test file.
Change-Id: I09c3970575134c630994d7dd275b436c5b2fa2bc
---
M src/kudu/fs/CMakeLists.txt
M src/kudu/fs/block_manager-test.cc
A src/kudu/fs/log_block_manager-test.cc
3 files changed, 697 insertions(+), 691 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/85/6485/1
--
To view, visit http://gerrit.cloudera.org:8080/6485
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I09c3970575134c630994d7dd275b436c5b2fa2bc
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] fs: move LBM tests to new test file
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged.
Change subject: fs: move LBM tests to new test file
......................................................................
fs: move LBM tests to new test file
They don't share much with block_manager-test, and I plan on adding more, so
this separation makes sense.
The only substantive change was to the ReopenBlockManager() signature in the
new test file.
Change-Id: I09c3970575134c630994d7dd275b436c5b2fa2bc
Reviewed-on: http://gerrit.cloudera.org:8080/6485
Tested-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: Mike Percy <mp...@apache.org>
---
M src/kudu/fs/CMakeLists.txt
M src/kudu/fs/block_manager-test.cc
A src/kudu/fs/log_block_manager-test.cc
3 files changed, 697 insertions(+), 691 deletions(-)
Approvals:
Mike Percy: Looks good to me, approved
Adar Dembo: Verified
--
To view, visit http://gerrit.cloudera.org:8080/6485
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I09c3970575134c630994d7dd275b436c5b2fa2bc
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] fs: move LBM tests to new test file
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: fs: move LBM tests to new test file
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6485
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I09c3970575134c630994d7dd275b436c5b2fa2bc
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] fs: move LBM tests to new test file
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: fs: move LBM tests to new test file
......................................................................
Patch Set 1: Verified+1
Unrelated test failure, in a new test that's flaky (AdminCliTest.TestUnsafeChangeConfigOnSingleFollower).
--
To view, visit http://gerrit.cloudera.org:8080/6485
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I09c3970575134c630994d7dd275b436c5b2fa2bc
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No