You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@celeborn.apache.org by "HolyLow (via GitHub)" <gi...@apache.org> on 2026/01/05 05:35:41 UTC

Re: [PR] [CELEBORN-2235][CIP-14] Adapt Java end's serialization to CppWriterClient [celeborn]

HolyLow commented on code in PR #3561:
URL: https://github.com/apache/celeborn/pull/3561#discussion_r2660336574


##########
client/src/main/scala/org/apache/celeborn/client/RequestLocationCallContext.scala:
##########
@@ -36,11 +37,12 @@ trait RequestLocationCallContext {
 
 case class ChangeLocationsCallContext(
     context: RpcCallContext,
-    partitionCount: Int)
+    partitionCount: Int,
+    serdeVersion: SerdeVersion)
   extends RequestLocationCallContext with Logging {
-  val endedMapIds = new util.HashSet[Integer]()
+  val endedMapIds = new util.ArrayList[Integer]()

Review Comment:
   ArrayList takes less overhead than HashSet, so here we change to use ArrayList. Besides, it is a bit more complex to operate on HashSet in scala code.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org