You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hop.apache.org by ha...@apache.org on 2020/11/12 17:21:47 UTC
[incubator-hop] branch master updated: HOP-13 Avoid use of the
static modifier for session-unique instances (#374)
This is an automated email from the ASF dual-hosted git repository.
hansva pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-hop.git
The following commit(s) were added to refs/heads/master by this push:
new 856a602 HOP-13 Avoid use of the static modifier for session-unique instances (#374)
856a602 is described below
commit 856a602557abb99093e2ce056d64dcb9be338f13
Author: Hiromu Hota <hi...@gmail.com>
AuthorDate: Thu Nov 12 09:21:41 2020 -0800
HOP-13 Avoid use of the static modifier for session-unique instances (#374)
See https://github.com/HiromuHota/pentaho-kettle/wiki/Dev%3A-Antipatterns-in-webSpoon#example-use-of-the-static-modifier-for-session-unique-instances
---
.../main/java/org/apache/hop/ui/hopgui/dialog/NotePadDialog.java | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/ui/src/main/java/org/apache/hop/ui/hopgui/dialog/NotePadDialog.java b/ui/src/main/java/org/apache/hop/ui/hopgui/dialog/NotePadDialog.java
index ddfbe21..a53004e 100644
--- a/ui/src/main/java/org/apache/hop/ui/hopgui/dialog/NotePadDialog.java
+++ b/ui/src/main/java/org/apache/hop/ui/hopgui/dialog/NotePadDialog.java
@@ -127,11 +127,11 @@ public class NotePadDialog extends Dialog {
private Label wlBorderColor;
private FormData fdlBorderColor;
- private static GuiResource guiresource = GuiResource.getInstance();
+ private GuiResource guiresource = GuiResource.getInstance();
- public static RGB COLOR_RGB_BLACK = guiresource.getColorBlack().getRGB();
- public static RGB COLOR_RGB_YELLOW = guiresource.getColorYellow().getRGB();
- public static RGB COLOR_RGB_GRAY = guiresource.getColorGray().getRGB();
+ public RGB COLOR_RGB_BLACK = guiresource.getColorBlack().getRGB();
+ public RGB COLOR_RGB_YELLOW = guiresource.getColorYellow().getRGB();
+ public RGB COLOR_RGB_GRAY = guiresource.getColorGray().getRGB();
private Color fontColor;
private Color bgColor;