[GitHub] [superset] eschutho edited a comment on issue #12566: [SIP-57] Proposal for Semantic Versioning

[GitBox <gi...@apache.org>]

eschutho edited a comment on issue #12566:
URL: https://github.com/apache/superset/issues/12566#issuecomment-773593136


   >Re: mergeability of PRs, it sounds like PRs that introduce a breaking change will be kept open until such time as there is a major version release branch, unless the change can be put behind a feature flag. Is that the intention? 
   
   The majority of changes will be able to be backward compatible, but if something just can't be made backward compatible, then yes, we should plan to either make the next release a major version or hold on to the PR until we can create a major version release. Another aspect is in planning. If we know in advance that a feature is not going to be backward compatible, it's good to keep that in mind and plan to build it at a time when we know we can do a major version release. 
   
   >Will the same process apply to new features introduced for minor versions, or will these be mergeable to master prior to a release?
   
   Any minor version feature should be able to be merged into master. Minor bumps usually are cherry-picks onto an existing release, so we shouldn't ever need to worry about not merging backward compatible features to master. 
   
   >Separately, I noticed the DB migration sections don't include anything about modifying the data in a table in a backwards-incompatible way. For example, a JSON blob being modified.
   
   Ok, good point. So something like a JSON blob has a schema, and we run a script during the migration that updates the data that changes the schema, and then we push out the code that reads/writes the data according to the new schema, but between the script/migration and the code update, the application will fail? 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org