You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/12/06 21:23:15 UTC

[GitHub] larroy commented on a change in pull request #13564: Enhancement of split op with indices option

larroy commented on a change in pull request #13564: Enhancement of split op with indices option
URL: https://github.com/apache/incubator-mxnet/pull/13564#discussion_r239619284
 
 

 ##########
 File path: src/operator/slice_channel-inl.h
 ##########
 @@ -62,11 +67,63 @@ struct SliceChannelParam : public dmlc::Parameter<SliceChannelParam> {
   }
 };  // struct SliceChannelParam
 
+struct SplitKernel {
+  template<typename DType>
+  static MSHADOW_XINLINE void Map(size_t i,
+                                  const DType *in_data, DType** out_data, const size_t* indices,
+                                  size_t num_sections, size_t axis_size, size_t trailing_size) {
+    // printf("%lu\n", i);
 
 Review comment:
   can we remove this?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services