You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/10/14 07:05:32 UTC

[GitHub] [spark] huaxingao opened a new pull request #34283: [SPARK-36871][SQL][FOLLOWUP] move error checking from create cmd to parser

huaxingao opened a new pull request #34283:
URL: https://github.com/apache/spark/pull/34283


   
   
   ### What changes were proposed in this pull request?
   Move error checking from create cmd to parser
   
   
   ### Why are the changes needed?
   catch error earlier and also make code consistent between parsing CreateFunction and CreateView
   
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   
   ### How was this patch tested?
   Existing tests
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan closed pull request #34283: [SPARK-36871][SQL][FOLLOWUP] Move error checking from create cmd to parser

Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #34283:
URL: https://github.com/apache/spark/pull/34283


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #34283: [SPARK-36871][SQL][FOLLOWUP] Move error checking from create cmd to parser

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34283:
URL: https://github.com/apache/spark/pull/34283#issuecomment-946340241


   **[Test build #144388 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144388/testReport)** for PR 34283 at commit [`b1dae91`](https://github.com/apache/spark/commit/b1dae91dd5279ced7b742c2b0e313e64568d7ae9).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #34283: [SPARK-36871][SQL][FOLLOWUP] Move error checking from create cmd to parser

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34283:
URL: https://github.com/apache/spark/pull/34283#issuecomment-946485079


   **[Test build #144388 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144388/testReport)** for PR 34283 at commit [`b1dae91`](https://github.com/apache/spark/commit/b1dae91dd5279ced7b742c2b0e313e64568d7ae9).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34283: [SPARK-36871][SQL][FOLLOWUP] Move error checking from create cmd to parser

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34283:
URL: https://github.com/apache/spark/pull/34283#issuecomment-946487497


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144388/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #34283: [SPARK-36871][SQL][FOLLOWUP] Move error checking from create cmd to parser

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34283:
URL: https://github.com/apache/spark/pull/34283#issuecomment-943300490


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144242/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] huaxingao commented on pull request #34283: [SPARK-36871][SQL][FOLLOWUP] Move error checking from create cmd to parser

Posted by GitBox <gi...@apache.org>.
huaxingao commented on pull request #34283:
URL: https://github.com/apache/spark/pull/34283#issuecomment-946840275


   Thanks @cloud-fan @HyukjinKwon 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34283: [SPARK-36871][SQL][FOLLOWUP] Move error checking from create cmd to parser

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34283:
URL: https://github.com/apache/spark/pull/34283#issuecomment-946383867


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48862/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on pull request #34283: [SPARK-36871][SQL][FOLLOWUP] Move error checking from create cmd to parser

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #34283:
URL: https://github.com/apache/spark/pull/34283#issuecomment-946410092


   thanks, merging to master!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #34283: [SPARK-36871][SQL][FOLLOWUP] move error checking from create cmd to parser

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34283:
URL: https://github.com/apache/spark/pull/34283#issuecomment-943082224


   **[Test build #144242 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144242/testReport)** for PR 34283 at commit [`1598a9f`](https://github.com/apache/spark/commit/1598a9fc4acfca76f1881ba020e512c353cd9e98).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #34283: [SPARK-36871][SQL][FOLLOWUP] Move error checking from create cmd to parser

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34283:
URL: https://github.com/apache/spark/pull/34283#issuecomment-946340241


   **[Test build #144388 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144388/testReport)** for PR 34283 at commit [`b1dae91`](https://github.com/apache/spark/commit/b1dae91dd5279ced7b742c2b0e313e64568d7ae9).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34283: [SPARK-36871][SQL][FOLLOWUP] Move error checking from create cmd to parser

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34283:
URL: https://github.com/apache/spark/pull/34283#issuecomment-943300490


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144242/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #34283: [SPARK-36871][SQL][FOLLOWUP] Move error checking from create cmd to parser

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34283:
URL: https://github.com/apache/spark/pull/34283#issuecomment-946383867


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48862/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #34283: [SPARK-36871][SQL][FOLLOWUP] Move error checking from create cmd to parser

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34283:
URL: https://github.com/apache/spark/pull/34283#issuecomment-943170836


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48722/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34283: [SPARK-36871][SQL][FOLLOWUP] Move error checking from create cmd to parser

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34283:
URL: https://github.com/apache/spark/pull/34283#issuecomment-943170836


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48722/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #34283: [SPARK-36871][SQL][FOLLOWUP] Move error checking from create cmd to parser

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34283:
URL: https://github.com/apache/spark/pull/34283#issuecomment-946360530


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48862/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #34283: [SPARK-36871][SQL][FOLLOWUP] Move error checking from create cmd to parser

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34283:
URL: https://github.com/apache/spark/pull/34283#issuecomment-946383849


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48862/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #34283: [SPARK-36871][SQL][FOLLOWUP] Move error checking from create cmd to parser

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34283:
URL: https://github.com/apache/spark/pull/34283#issuecomment-943116860


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48722/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on a change in pull request #34283: [SPARK-36871][SQL][FOLLOWUP] Move error checking from create cmd to parser

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #34283:
URL: https://github.com/apache/spark/pull/34283#discussion_r731537585



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala
##########
@@ -467,20 +471,36 @@ class SparkSqlAstBuilder extends AstBuilder {
       LocalTempView
     }
     if (viewType == PersistedView) {
+      val originalText = source(ctx.query)
+      assert(Option(originalText).isDefined,

Review comment:
       is it just `assert(originalText != null, ...)`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #34283: [SPARK-36871][SQL][FOLLOWUP] Move error checking from create cmd to parser

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34283:
URL: https://github.com/apache/spark/pull/34283#issuecomment-946487497


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144388/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #34283: [SPARK-36871][SQL][FOLLOWUP] Move error checking from create cmd to parser

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34283:
URL: https://github.com/apache/spark/pull/34283#issuecomment-943082224


   **[Test build #144242 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144242/testReport)** for PR 34283 at commit [`1598a9f`](https://github.com/apache/spark/commit/1598a9fc4acfca76f1881ba020e512c353cd9e98).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #34283: [SPARK-36871][SQL][FOLLOWUP] Move error checking from create cmd to parser

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34283:
URL: https://github.com/apache/spark/pull/34283#issuecomment-943154394


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48722/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #34283: [SPARK-36871][SQL][FOLLOWUP] Move error checking from create cmd to parser

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34283:
URL: https://github.com/apache/spark/pull/34283#issuecomment-943279572


   **[Test build #144242 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144242/testReport)** for PR 34283 at commit [`1598a9f`](https://github.com/apache/spark/commit/1598a9fc4acfca76f1881ba020e512c353cd9e98).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org