You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/03/26 20:08:43 UTC
[GitHub] [arrow] nevi-me opened a new pull request #9815: MINOR: [Rust] allow Rust 1.51 clippy acronym lint
nevi-me opened a new pull request #9815:
URL: https://github.com/apache/arrow/pull/9815
There's an acronym Rust lint that started failing after 1.51 was announced. The lint is in the `arrow::ffi` and `arrow::ipc::gen` modules, so I'm instead ignoring it and documenting this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nevi-me closed pull request #9815: ARROW-12116: [Rust] Fix and ignore 1.51 clippy lints
Posted by GitBox <gi...@apache.org>.
nevi-me closed pull request #9815:
URL: https://github.com/apache/arrow/pull/9815
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nevi-me commented on pull request #9815: ARROW-12116: [Rust] Fix and ignore 1.51 clippy lints
Posted by GitBox <gi...@apache.org>.
nevi-me commented on pull request #9815:
URL: https://github.com/apache/arrow/pull/9815#issuecomment-808804258
The integration test failure is unrelated (disk space issues)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #9815: ARROW-12116: [Rust] Fix and ignore 1.51 clippy lints
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #9815:
URL: https://github.com/apache/arrow/pull/9815#issuecomment-808813558
Thanks @nevi-me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nevi-me commented on pull request #9815: ARROW-12116: [Rust] Fix and ignore 1.51 clippy lints
Posted by GitBox <gi...@apache.org>.
nevi-me commented on pull request #9815:
URL: https://github.com/apache/arrow/pull/9815#issuecomment-808813415
I'm merging this, it's a minor change that is costing us CI time as long as the clippy lint remains unfixed on master. If there's suggested changes, I'll address them separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nevi-me commented on pull request #9815: MINOR: [Rust] allow Rust 1.51 clippy acronym lint
Posted by GitBox <gi...@apache.org>.
nevi-me commented on pull request #9815:
URL: https://github.com/apache/arrow/pull/9815#issuecomment-808492402
There's more changes needed, so I'll open a JIRA for the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io commented on pull request #9815: ARROW-12116: [Rust] allow Rust 1.51 clippy acronym lint
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #9815:
URL: https://github.com/apache/arrow/pull/9815#issuecomment-808647838
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9815?src=pr&el=h1) Report
> Merging [#9815](https://codecov.io/gh/apache/arrow/pull/9815?src=pr&el=desc) (366d6db) into [master](https://codecov.io/gh/apache/arrow/commit/2c5e26423550d82ab2bd3f7a8f7f1d7eac89cf36?el=desc) (2c5e264) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/arrow/pull/9815?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9815 +/- ##
=======================================
Coverage 82.40% 82.40%
=======================================
Files 252 252
Lines 58961 58960 -1
=======================================
Hits 48586 48586
+ Misses 10375 10374 -1
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9815?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [rust/arrow/src/util/pretty.rs](https://codecov.io/gh/apache/arrow/pull/9815/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvdXRpbC9wcmV0dHkucnM=) | `94.73% <100.00%> (-0.04%)` | :arrow_down: |
| [rust/datafusion/src/logical\_plan/builder.rs](https://codecov.io/gh/apache/arrow/pull/9815/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9sb2dpY2FsX3BsYW4vYnVpbGRlci5ycw==) | `88.18% <100.00%> (ø)` | |
| [rust/parquet/src/encodings/encoding.rs](https://codecov.io/gh/apache/arrow/pull/9815/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9lbmNvZGluZ3MvZW5jb2RpbmcucnM=) | `95.05% <0.00%> (+0.19%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9815?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9815?src=pr&el=footer). Last update [2c5e264...366d6db](https://codecov.io/gh/apache/arrow/pull/9815?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9815: ARROW-12116: [Rust] allow Rust 1.51 clippy acronym lint
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9815:
URL: https://github.com/apache/arrow/pull/9815#issuecomment-808645211
https://issues.apache.org/jira/browse/ARROW-12116
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9815: MINOR: [Rust] allow Rust 1.51 clippy acronym lint
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9815:
URL: https://github.com/apache/arrow/pull/9815#issuecomment-808481759
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org