You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by "Mike Drob (JIRA)" <ji...@apache.org> on 2017/06/20 20:52:00 UTC

[jira] [Commented] (HBASE-18239) Address ruby static analysis for shell module

    [ https://issues.apache.org/jira/browse/HBASE-18239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16056438#comment-16056438 ] 

Mike Drob commented on HBASE-18239:
-----------------------------------

TestShell passes locally for me. Visually reviewed all the changes and didn't find anything too objectionably.

There's some cases where it turned string formatting using % into explicit format method and I'd prefer string interpolation, but that can be a follow up pass.

> Address ruby static analysis for shell module
> ---------------------------------------------
>
>                 Key: HBASE-18239
>                 URL: https://issues.apache.org/jira/browse/HBASE-18239
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Mike Drob
>            Assignee: Mike Drob
>             Fix For: 2.0.0
>
>         Attachments: HBASE-18239.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)