You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/10/23 03:14:46 UTC

[GitHub] [iotdb] neuyilan commented on a change in pull request #1836: [IOTDB-948] Use binary search when checking the follower's match index when catchup

neuyilan commented on a change in pull request #1836:
URL: https://github.com/apache/iotdb/pull/1836#discussion_r510570408



##########
File path: server/src/main/java/org/apache/iotdb/db/service/TSServiceImpl.java
##########
@@ -1691,7 +1693,7 @@ protected TSStatus executeNonQueryPlan(PhysicalPlan plan) {
     } catch (QueryProcessException e) {
       logger.error("meet error while processing non-query. ", e);
       Throwable cause = e;
-      while (cause.getCause() != null){
+      while (cause.getCause() != null && cause.getCause().getCause() != null) {

Review comment:
       this is used to fix the UT tests that the exception only shows the message bug but lacks the exception type. I saw you have fixed in the commit[1], but I think it's better to be consistent with the single server.
   So if you agree with me, I would re-add the exception type you've deleted in [1], otherwise, I'll change the code here as normal.
   [1] https://github.com/apache/iotdb/commit/83e916a9e7bc618f348b7078bd79e62db6d9d546




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org