[GitHub] tzulitai commented on a change in pull request #6537: [FLINK-10122] KafkaConsumer should use partitionable state over union state if partition discovery is not active

[GitBox <gi...@apache.org>]

tzulitai commented on a change in pull request #6537: [FLINK-10122] KafkaConsumer should use partitionable state over union state if partition discovery is not active
URL: https://github.com/apache/flink/pull/6537#discussion_r210808619
 
 

 ##########
 File path: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java
 ##########
 @@ -480,7 +477,7 @@ public void open(Configuration configuration) throws Exception {
 			}
 
 			for (Map.Entry<KafkaTopicPartition, Long> restoredStateEntry : restoredState.entrySet()) {
-				if (!restoredFromOldState) {
+				if (discoveryIntervalMillis != PARTITION_DISCOVERY_DISABLED) {
 
 Review comment:
   This, therefore, is a bit confusing.
   
   If we decide to change it so that whether or not partition discovery is enabled is determined at the very beginning and cannot be changed from them on (even on restarts), then there shouldn't be a case to check `discoveryIntervalMillis != PARTITION_DISCOVERY_DISABLED` here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services