You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/10/06 10:52:04 UTC

[GitHub] [airflow] Taragolis commented on pull request #26886: Adding `preserve_file_name` param to `S3Hook.download_file` method

Taragolis commented on PR #26886:
URL: https://github.com/apache/airflow/pull/26886#issuecomment-1269801626

   IMHO, I thought that this method create more problem rather than solve (also have issue with SSE Encryption https://github.com/apache/airflow/pull/25835), and seem like it main purpose for use in code PythonOperator (and so on), only one operator use this method - [S3ToMySqlOperator](https://github.com/apache/airflow/blob/06acf40a4337759797f666d5bb27a5a393b74fed/airflow/providers/mysql/transfers/s3_to_mysql.py#L80-L81).
   
   Also it have the same name as [boto3.client("s3").download_file](https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/s3.html#S3.Client.download_file) but provide different input arguments, and all other community operators use this boto3 method by `S3Hook(...).get_conn().download_file(...)` or same method from high-level S3 Resource


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org