You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "divyaguduru (via GitHub)" <gi...@apache.org> on 2024/08/27 15:59:35 UTC
[PR] Add “Resources” section in the Airflow website #233 [airflow-site]
divyaguduru opened a new pull request, #1062:
URL: https://github.com/apache/airflow-site/pull/1062
Add “Resources” section in the Airflow website #233
<img width="1463" alt="image" src="https://github.com/user-attachments/assets/48e30902-d9a1-4a43-8344-014e26e53ae3">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add “Resources” section in the Airflow website #233 [airflow-site]
Posted by "divyaguduru (via GitHub)" <gi...@apache.org>.
divyaguduru commented on PR #1062:
URL: https://github.com/apache/airflow-site/pull/1062#issuecomment-2323419625
- Resources section is added in Community page
- Apache Airflow book updated in Ecosystem page
- Sticky sidebar for navigation is added in Community page for desktop view
https://github.com/user-attachments/assets/5fe28d96-a9e5-46c1-885b-1494147629bd
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add “Resources” section in the Airflow website #233 [airflow-site]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #1062:
URL: https://github.com/apache/airflow-site/pull/1062#issuecomment-2323232616
I am not good on the web side of it so maybe someone else.will, but if it works I see no reason for us not.merging it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add “Resources” section in the Airflow website #233 [airflow-site]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on PR #1062:
URL: https://github.com/apache/airflow-site/pull/1062#issuecomment-2345036613
> > @potiuk / @jscheffl / @bbovenzi, Could you let me know if there are any actions required from my end here ?
>
> Removing the whitespace changes?
I would not insist on it. Would be better but.... LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add “Resources” section in the Airflow website #233 [airflow-site]
Posted by "divyaguduru (via GitHub)" <gi...@apache.org>.
divyaguduru commented on PR #1062:
URL: https://github.com/apache/airflow-site/pull/1062#issuecomment-2313391277
pre-commit issues fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add “Resources” section in the Airflow website #233 [airflow-site]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #1062:
URL: https://github.com/apache/airflow-site/pull/1062#issuecomment-2323128441
I am not sure if adding the book to resources is a good idea. Generally whatever we publish (except Ecosystem page) should be PMC "owned" and "controlled" and the book is something written independently (even if one of the authors is a PMC members) -sp I think the right place to mention the book is "ecosystem" page.
The "promo materials" though is a very good idea to add.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add “Resources” section in the Airflow website #233 [airflow-site]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #1062:
URL: https://github.com/apache/airflow-site/pull/1062#issuecomment-2338168371
can someone more familiar with javascript/css etc. review it as well @pierrejeambrun @jscheffl @bbovenzi ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add “Resources” section in the Airflow website #233 [airflow-site]
Posted by "divyaguduru (via GitHub)" <gi...@apache.org>.
divyaguduru commented on PR #1062:
URL: https://github.com/apache/airflow-site/pull/1062#issuecomment-2323160929
@potiuk i will work on the feedback .. could you please review sticky sidebar implementation for "Community" page as well. It is requested on the same issue #233
- Added sticky sidebar on scroll only for desktop, doesn't reflect on mobile or tablet screens.
https://github.com/user-attachments/assets/1e2905e6-a413-4f54-b186-abf5f0d3976c
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add “Resources” section in the Airflow website #233 [airflow-site]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on PR #1062:
URL: https://github.com/apache/airflow-site/pull/1062#issuecomment-2341391206
Could we undo the whitespace changes to html and css? It's hard to tell what actually changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add “Resources” section in the Airflow website #233 [airflow-site]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on PR #1062:
URL: https://github.com/apache/airflow-site/pull/1062#issuecomment-2341566271
> I checked the diff w/o whitespace... 
>
> Is the build testable in a different URL? Actually this PR mixed a bit of sticky layout changes with adding a menu entry. Next time might be easier to separate.
>
> From point of code view... seems reasonable.
Oh I never noticed that option before.
This generally looks good to me. It would still be best not to contribute whitespace changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add “Resources” section in the Airflow website #233 [airflow-site]
Posted by "gdivya6028 (via GitHub)" <gi...@apache.org>.
gdivya6028 commented on PR #1062:
URL: https://github.com/apache/airflow-site/pull/1062#issuecomment-2343659774
@potiuk / @jscheffl / @bbovenzi, Could you let me know if there are any actions required from my end here ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add “Resources” section in the Airflow website #233 [airflow-site]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #1062:
URL: https://github.com/apache/airflow-site/pull/1062#discussion_r1749208542
##########
landing-pages/site/content/en/ecosystem/_index.md:
##########
@@ -31,6 +31,8 @@ If you would you like to be included on this page, please reach out to the [Apac
[Apache Airflow: Complete Hands-On Beginner to Advanced Class](https://www.udemy.com/course/apache-airflow-course) by Alexandra Abbas on Udemy
+[Data Pipelines with Apache Airflow](https://www.manning.com/books/data-pipelines-with-apache-airflow) Apache Airflow Book by Bas P. Harenslak and Julian Rutger de Ruiter on Amazon
Review Comment:
BTW. I believe there is a second edition of that book being written as we speak by different authors, so maybe leaving the details out about the authorship might be a good idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add “Resources” section in the Airflow website #233 [airflow-site]
Posted by "gdivya6028 (via GitHub)" <gi...@apache.org>.
gdivya6028 commented on code in PR #1062:
URL: https://github.com/apache/airflow-site/pull/1062#discussion_r1749276585
##########
landing-pages/site/content/en/ecosystem/_index.md:
##########
@@ -31,6 +31,8 @@ If you would you like to be included on this page, please reach out to the [Apac
[Apache Airflow: Complete Hands-On Beginner to Advanced Class](https://www.udemy.com/course/apache-airflow-course) by Alexandra Abbas on Udemy
+[Data Pipelines with Apache Airflow](https://www.manning.com/books/data-pipelines-with-apache-airflow) Apache Airflow Book by Bas P. Harenslak and Julian Rutger de Ruiter on Amazon
Review Comment:
@potiuk I've removed the authorship details for now .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add “Resources” section in the Airflow website #233 [airflow-site]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #1062:
URL: https://github.com/apache/airflow-site/pull/1062#issuecomment-2345013362
> @potiuk / @jscheffl / @bbovenzi, Could you let me know if there are any actions required from my end here ?
Removing the whitespace?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org