You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "kishankavala (via GitHub)" <gi...@apache.org> on 2023/07/19 04:27:03 UTC
[GitHub] [cloudstack] kishankavala opened a new pull request, #7752: Csos
kishankavala opened a new pull request, #7752:
URL: https://github.com/apache/cloudstack/pull/7752
### Description
This PR adds Object Storage feature to CloudStack.
FS: https://cwiki.apache.org/confluence/display/CLOUDSTACK/%5BDRAFT%5D+CloudStack+Object+Store
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [X] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [X] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7752: ObjectStore Framework with MinIO and Simulator plugins
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1678546349
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6776
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7752: ObjectStore Framework with MinIO and Simulator plugins
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1698888075
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6940
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1787433821
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1813883411
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1826232849
<b>[SF] Trillian test result (tid-8389)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 72883 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7752-t8389-kvm-centos7.zip
Smoke tests completed. 113 look OK, 7 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_list_cpvm_vm | `Failure` | 0.03 | test_ssvm.py
test_04_cpvm_internals | `Failure` | 0.04 | test_ssvm.py
test_01_create_iso_with_checksum_sha1 | `Error` | 66.46 | test_iso.py
test_02_create_iso_with_checksum_sha256 | `Error` | 66.48 | test_iso.py
test_03_create_iso_with_checksum_md5 | `Error` | 66.48 | test_iso.py
test_04_create_iso_with_no_checksum | `Error` | 66.48 | test_iso.py
test_13_retrieve_vr_default_files | `Error` | 1.10 | test_diagnostics.py
test_14_retrieve_vr_one_file | `Error` | 1.10 | test_diagnostics.py
test_15_retrieve_ssvm_default_files | `Error` | 1.10 | test_diagnostics.py
test_16_retrieve_ssvm_single_file | `Error` | 1.09 | test_diagnostics.py
test_17_retrieve_cpvm_default_files | `Error` | 1.12 | test_diagnostics.py
test_18_retrieve_cpvm_single_file | `Error` | 1.09 | test_diagnostics.py
test_01_invalid_upgrade_kubernetes_cluster | `Failure` | 3621.01 | test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 645.52 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 84.95 | test_kubernetes_clusters.py
test_01_create_template | `Error` | 10.43 | test_templates.py
test_CreateTemplateWithDuplicateName | `Error` | 20.68 | test_templates.py
test_02_create_template_with_checksum_sha1 | `Error` | 65.52 | test_templates.py
test_03_create_template_with_checksum_sha256 | `Error` | 65.48 | test_templates.py
test_04_create_template_with_checksum_md5 | `Error` | 65.50 | test_templates.py
test_05_create_template_with_no_checksum | `Error` | 65.51 | test_templates.py
test_04_extract_template | `Error` | 1.07 | test_templates.py
test_05_template_permissions | `Failure` | 0.04 | test_templates.py
test_09_list_templates_download_details | `Failure` | 0.07 | test_templates.py
ContextSuite context=TestVPCNics>:setup | `Error` | 0.00 | test_vpc_router_nics.py
ContextSuite context=TestRVPCSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVpcRemoteAccessVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVpcSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1790513152
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7609
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1831470482
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "kishankavala (via GitHub)" <gi...@apache.org>.
kishankavala commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1783465318
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1754585320
@vladimirpetrov a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1798536909
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7660
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1834452051
@kishankavala a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1772410126
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7752: ObjectStore Framework with MinIO and Simulator plugins
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1738637003
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7145
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1813883629
@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1813949126
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7767
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] kishankavala commented on pull request #7752: ObjectStore Framework with MinIO and Simulator plugins
Posted by "kishankavala (via GitHub)" <gi...@apache.org>.
kishankavala commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1670888982
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7752: ObjectStore Framework with MinIO and Simulator plugins
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1681808923
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6813
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7752: ObjectStore Framework with MinIO and Simulator plugins
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1698810841
@kishankavala a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7752: ObjectStore Framework with MinIO and Simulator plugins
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1672332680
<b>[SF] Trillian test result (tid-7330)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 54391 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7752-t7330-kvm-centos7.zip
Smoke tests completed. 113 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_trigger_shutdown | `Failure` | 336.84 | test_safe_shutdown.py
test_01_migrate_VM_and_root_volume | `Error` | 82.80 | test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks | `Error` | 56.49 | test_vm_life_cycle.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1798393978
Packaging result [SF]: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: el9 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 7657
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "vladimirpetrov (via GitHub)" <gi...@apache.org>.
vladimirpetrov commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1798338478
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1816266602
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "kishankavala (via GitHub)" <gi...@apache.org>.
kishankavala commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1823896408
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on code in PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#discussion_r1409071289
##########
.github/workflows/ci.yml:
##########
@@ -90,6 +90,7 @@ jobs:
smoke/test_nic
smoke/test_nic_adapter_type
smoke/test_non_contigiousvlan
+ smoke/test_object_stores.py
Review Comment:
```suggestion
smoke/test_object_stores
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1834452947
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7879
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] vladimirpetrov commented on pull request #7752: ObjectStore Framework with MinIO and Simulator plugins
Posted by "vladimirpetrov (via GitHub)" <gi...@apache.org>.
vladimirpetrov commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1678491376
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7752: ObjectStore Framework with MinIO and Simulator plugins
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1641595503
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6507
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1782380364
@vladimirpetrov a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] kishankavala commented on pull request #7752: ObjectStore Framework with MinIO and Simulator plugins
Posted by "kishankavala (via GitHub)" <gi...@apache.org>.
kishankavala commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1641595939
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] kishankavala commented on pull request #7752: ObjectStore Framework with MinIO and Simulator plugins
Posted by "kishankavala (via GitHub)" <gi...@apache.org>.
kishankavala commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1670716623
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] kishankavala commented on pull request #7752: ObjectStore Framework with MinIO and Simulator plugins
Posted by "kishankavala (via GitHub)" <gi...@apache.org>.
kishankavala commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1698809393
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] vladimirpetrov commented on pull request #7752: ObjectStore Framework with MinIO and Simulator plugins
Posted by "vladimirpetrov (via GitHub)" <gi...@apache.org>.
vladimirpetrov commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1711405891
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] vladimirpetrov commented on pull request #7752: ObjectStore Framework with MinIO and Simulator plugins
Posted by "vladimirpetrov (via GitHub)" <gi...@apache.org>.
vladimirpetrov commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1738542335
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1823897811
@kishankavala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1798414054
@kishankavala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1777131077
@vladimirpetrov a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1782439345
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7537
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1783481917
@kishankavala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1783536142
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7550
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "vishesh92 (via GitHub)" <gi...@apache.org>.
vishesh92 commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1829621197
Not sure but probably because of the below line:
```python
from marvin.cloudstackTestCase import *
```
Changing it to below might fix it.
```python
from marvin.cloudstackTestCase import cloudstackTestCase
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1825432882
@kishankavala a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1831563212
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7866
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1777221468
Packaging result [SF]: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: el9 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 7484
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1777321387
Packaging result [SF]: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: el9 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 7486
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "vladimirpetrov (via GitHub)" <gi...@apache.org>.
vladimirpetrov commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1782379488
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1836030365
Merging this based on reviews and testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1786966373
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7752: ObjectStore Framework with MinIO and Simulator plugins
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1670891549
@kishankavala a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on a diff in pull request #7752: ObjectStore Framework with MinIO and Simulator plugins
Posted by "harikrishna-patnala (via GitHub)" <gi...@apache.org>.
harikrishna-patnala commented on code in PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#discussion_r1274717934
##########
api/src/main/java/org/apache/cloudstack/api/BaseCmd.java:
##########
@@ -29,6 +29,7 @@
import javax.inject.Inject;
+import com.cloud.storage.object.BucketApiService;
Review Comment:
reorder this please
##########
api/src/main/java/org/apache/cloudstack/api/command/admin/storage/UpdateObjectStoragePoolCmd.java:
##########
@@ -0,0 +1,93 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.cloudstack.api.command.admin.storage;
+
+import com.cloud.storage.ObjectStore;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.ObjectStoreResponse;
+import org.apache.cloudstack.context.CallContext;
+
+@APICommand(name = UpdateObjectStoragePoolCmd.APINAME, description = "Updates object storage pool", responseObject = ObjectStoreResponse.class, entityType = {ObjectStore.class},
+ requestHasSensitiveInfo = false, responseHasSensitiveInfo = false, since = "4.19.0")
+public class UpdateObjectStoragePoolCmd extends BaseCmd {
Review Comment:
extra tab here in the class
##########
api/src/main/java/org/apache/cloudstack/api/ResponseGenerator.java:
##########
@@ -22,6 +22,8 @@
import java.util.Map;
import java.util.Set;
+import com.cloud.storage.Bucket;
Review Comment:
reorder this please
##########
api/src/main/java/org/apache/cloudstack/api/command/user/bucket/ListBucketsCmd.java:
##########
@@ -0,0 +1,99 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.api.command.user.bucket;
+
+import com.cloud.storage.Bucket;
+import org.apache.cloudstack.acl.RoleType;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiCommandResourceType;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.BaseListTaggedResourcesCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ResponseObject.ResponseView;
+import org.apache.cloudstack.api.command.user.UserCmd;
+import org.apache.cloudstack.api.response.BucketResponse;
+import org.apache.cloudstack.api.response.ListResponse;
+import org.apache.cloudstack.api.response.StoragePoolResponse;
+import org.apache.log4j.Logger;
+
+import java.util.List;
+
+@APICommand(name = "listBuckets", description = "Lists all Buckets.", responseObject = BucketResponse.class, responseView = ResponseView.Restricted, entityType = {
Review Comment:
since = "4.19.0" is missing here
##########
api/src/main/java/org/apache/cloudstack/api/command/user/bucket/CreateBucketCmd.java:
##########
@@ -0,0 +1,194 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.api.command.user.bucket;
+
+import com.cloud.event.EventTypes;
+import com.cloud.exception.ResourceAllocationException;
+import com.cloud.storage.Bucket;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiCommandResourceType;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseAsyncCreateCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ResponseObject.ResponseView;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.command.user.UserCmd;
+import org.apache.cloudstack.api.response.BucketResponse;
+import org.apache.cloudstack.api.response.DomainResponse;
+import org.apache.cloudstack.api.response.ObjectStoreResponse;
+import org.apache.cloudstack.api.response.ProjectResponse;
+import org.apache.cloudstack.context.CallContext;
+import org.apache.log4j.Logger;
+
+@APICommand(name = "createBucket", responseObject = BucketResponse.class,
Review Comment:
since = "4.19.0" is missing here
##########
api/src/main/java/org/apache/cloudstack/api/command/user/bucket/DeleteBucketCmd.java:
##########
@@ -0,0 +1,92 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.api.command.user.bucket;
+
+import com.cloud.exception.ConcurrentOperationException;
+import com.cloud.storage.Bucket;
+import com.cloud.user.Account;
+import org.apache.cloudstack.acl.SecurityChecker.AccessType;
+import org.apache.cloudstack.api.ACL;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiCommandResourceType;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.response.BucketResponse;
+import org.apache.cloudstack.api.response.SuccessResponse;
+import org.apache.cloudstack.context.CallContext;
+import org.apache.log4j.Logger;
+
+@APICommand(name = "deleteBucket", description = "Deletes an empty Bucket.", responseObject = SuccessResponse.class, entityType = {Bucket.class},
Review Comment:
since = "4.19.0" is missing here
##########
ui/public/locales/en.json:
##########
@@ -2242,6 +2248,18 @@
"label.zonenamelabel": "Zone name",
"label.zones": "Zones",
"label.zonewizard.traffictype.storage": "Storage: Traffic between primary and secondary storage servers, such as VM templates and snapshots.",
+"label.buckets": "Buckets",
+"label.objectstorageid": "Object Storage Pool",
+"label.bucket.update": "Update Bucket",
+"label.bucket.delete": "Delete Bucket",
+"label.quota": "Quota",
Review Comment:
Quota is already there I think, please check
##########
server/src/main/java/com/cloud/api/ApiResponseHelper.java:
##########
@@ -37,6 +37,9 @@
import javax.inject.Inject;
+import com.cloud.storage.Bucket;
Review Comment:
reorder this please
##########
api/src/main/java/org/apache/cloudstack/api/command/user/bucket/UpdateBucketCmd.java:
##########
@@ -0,0 +1,125 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.api.command.user.bucket;
+
+import com.cloud.exception.ConcurrentOperationException;
+import com.cloud.storage.Bucket;
+import com.cloud.user.Account;
+import org.apache.cloudstack.acl.SecurityChecker.AccessType;
+import org.apache.cloudstack.api.ACL;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiCommandResourceType;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.BucketResponse;
+import org.apache.cloudstack.api.response.SuccessResponse;
+import org.apache.cloudstack.context.CallContext;
+import org.apache.log4j.Logger;
+
+@APICommand(name = "updateBucket", description = "Updates Bucket properties", responseObject = SuccessResponse.class, entityType = {Bucket.class},
Review Comment:
since = "4.19.0" is missing here
##########
plugins/storage/object/minio/src/main/java/org/apache/cloudstack/storage/datastore/driver/MinIOObjectStoreDriverImpl.java:
##########
@@ -0,0 +1,431 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.cloudstack.storage.datastore.driver;
+
+import com.amazonaws.services.s3.model.AccessControlList;
+import com.amazonaws.services.s3.model.BucketPolicy;
+import com.cloud.agent.api.to.DataStoreTO;
+import com.cloud.storage.Bucket;
+import com.cloud.storage.BucketVO;
+import com.cloud.storage.dao.BucketDao;
+import com.cloud.user.Account;
+import com.cloud.user.AccountDetailsDao;
+import com.cloud.user.dao.AccountDao;
+import com.cloud.utils.exception.CloudRuntimeException;
+import io.minio.BucketExistsArgs;
+import io.minio.DeleteBucketEncryptionArgs;
+import io.minio.MakeBucketArgs;
+import io.minio.MinioClient;
+import io.minio.RemoveBucketArgs;
+import io.minio.SetBucketEncryptionArgs;
+import io.minio.SetBucketPolicyArgs;
+import io.minio.SetBucketVersioningArgs;
+import io.minio.admin.MinioAdminClient;
+import io.minio.admin.QuotaUnit;
+import io.minio.admin.UserInfo;
+import io.minio.admin.messages.DataUsageInfo;
+import io.minio.messages.SseConfiguration;
+import io.minio.messages.VersioningConfiguration;
+import org.apache.cloudstack.engine.subsystem.api.storage.DataStore;
+import org.apache.cloudstack.storage.datastore.db.ObjectStoreDao;
+import org.apache.cloudstack.storage.datastore.db.ObjectStoreDetailsDao;
+import org.apache.cloudstack.storage.datastore.db.ObjectStoreVO;
+import org.apache.cloudstack.storage.object.BaseObjectStoreDriverImpl;
+import org.apache.cloudstack.storage.object.BucketObject;
+import org.apache.commons.codec.binary.Base64;
+import org.apache.log4j.Logger;
+
+import javax.crypto.KeyGenerator;
+import javax.crypto.SecretKey;
+import javax.inject.Inject;
+import java.security.NoSuchAlgorithmException;
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+
+public class MinIOObjectStoreDriverImpl extends BaseObjectStoreDriverImpl {
+ private static final Logger s_logger = Logger.getLogger(MinIOObjectStoreDriverImpl.class);
+
+ @Inject
+ AccountDao _accountDao;
+
+ @Inject
+ AccountDetailsDao _accountDetailsDao;
+
+ @Inject
+ ObjectStoreDao _storeDao;
+
+ @Inject
+ BucketDao _bucketDao;
+
+ @Inject
+ ObjectStoreDetailsDao _storeDetailsDao;
+
+ private static final String ACCESS_KEY = "accesskey";
+ private static final String SECRET_KEY = "secretkey";
+
+ private static final String MINIO_ACCESS_KEY = "minio-accesskey";
+ private static final String MINIO_SECRET_KEY = "minio-secretkey";
+
+ @Override
+ public DataStoreTO getStoreTO(DataStore store) {
+ return null;
+ }
+
+ @Override
+ public Bucket createBucket(Bucket bucket, boolean objectLock) {
+ //ToDo Client pool mgmt
+ String bucketName = bucket.getName();
+ long storeId = bucket.getObjectStoreId();
+ long accountId = bucket.getAccountId();
+ MinioClient minioClient = getMinIOClient(storeId);
+ Account account = _accountDao.findById(accountId);
+ try {
+ if(minioClient.bucketExists(BucketExistsArgs.builder().bucket(bucketName).build())) {
+ throw new CloudRuntimeException("Bucket already exists with name "+ bucketName);
+ }
+ } catch (Exception e) {
+ throw new CloudRuntimeException(e);
+ }
+ try {
+ minioClient.makeBucket(MakeBucketArgs.builder().bucket(bucketName).objectLock(objectLock).build());
+ } catch (Exception e) {
+ throw new CloudRuntimeException(e);
+ }
+
+ String policy = " {\n" +
+ " \"Statement\": [\n" +
+ " {\n" +
+ " \"Action\": \"s3:*\",\n" +
+ " \"Effect\": \"Allow\",\n" +
+ " \"Principal\": \"*\",\n" +
+ " \"Resource\": \"arn:aws:s3:::"+bucketName+"/*\"\n" +
+ " }\n" +
+ " ],\n" +
+ " \"Version\": \"2012-10-17\"\n" +
+ " }";
+ MinioAdminClient minioAdminClient = getMinIOAdminClient(storeId);
+ String policyName = "acs-"+account.getAccountName()+"-policy";
+ String userName = "acs-"+account.getAccountName();
+ try {
+ minioAdminClient.addCannedPolicy(policyName, policy);
+ minioAdminClient.setPolicy(userName, false, policyName);
+ } catch (Exception e) {
+ throw new CloudRuntimeException(e);
+ }
+ String accessKey = _accountDetailsDao.findDetail(accountId, MINIO_ACCESS_KEY).getValue();
+ String secretKey = _accountDetailsDao.findDetail(accountId, MINIO_SECRET_KEY).getValue();
+ ObjectStoreVO store = _storeDao.findById(storeId);
+ BucketVO bucketVO = _bucketDao.findById(bucket.getId());
+ bucketVO.setAccessKey(accessKey);
+ bucketVO.setSecretKey(secretKey);
+ bucketVO.setBucketURL(store.getUrl()+"/"+bucketName);
+ _bucketDao.update(bucket.getId(), bucketVO);
+ return bucket;
+ }
+
+ @Override
+ public List<Bucket> listBuckets(long storeId) {
+ MinioClient minioClient = getMinIOClient(storeId);
+ List<Bucket> bucketsList = new ArrayList<>();
+ try {
+ List<io.minio.messages.Bucket> minIOBuckets = minioClient.listBuckets();
+ for(io.minio.messages.Bucket minIObucket : minIOBuckets) {
+ Bucket bucket = new BucketObject();
+ bucket.setName(minIObucket.name());
+ bucketsList.add(bucket);
+ }
+ } catch (Exception e) {
+ throw new CloudRuntimeException(e);
+ }
+ return bucketsList;
+ }
+
+ @Override
+ public boolean deleteBucket(String bucketName, long storeId) {
+ MinioClient minioClient = getMinIOClient(storeId);
+ try {
+ if(!minioClient.bucketExists(BucketExistsArgs.builder().bucket(bucketName).build())) {
+ throw new CloudRuntimeException("Bucket doesn't exist: "+ bucketName);
+ }
+ } catch (Exception e) {
+ throw new CloudRuntimeException(e);
+ }
+ //ToDo: check bucket empty
+ try {
+ minioClient.removeBucket(RemoveBucketArgs.builder().bucket(bucketName).build());
+ } catch (Exception e) {
+ throw new CloudRuntimeException(e);
+ }
+ return true;
+ }
+
+ @Override
+ public AccessControlList getBucketAcl(String bucketName, long storeId) {
+ return null;
+ }
+
+ @Override
+ public void setBucketAcl(String bucketName, AccessControlList acl, long storeId) {
+
+ }
+
+ @Override
+ public void setBucketPolicy(String bucketName, String policy, long storeId) {
+ String privatePolicy = "{\"Version\":\"2012-10-17\",\"Statement\":[]}";
+
+ StringBuilder builder = new StringBuilder();
+ builder.append("{\n");
+ builder.append(" \"Statement\": [\n");
+ builder.append(" {\n");
+ builder.append(" \"Action\": [\n");
+ builder.append(" \"s3:GetBucketLocation\",\n");
+ builder.append(" \"s3:ListBucket\"\n");
+ builder.append(" ],\n");
+ builder.append(" \"Effect\": \"Allow\",\n");
+ builder.append(" \"Principal\": \"*\",\n");
+ builder.append(" \"Resource\": \"arn:aws:s3:::"+bucketName+"\"\n");
+ builder.append(" },\n");
+ builder.append(" {\n");
+ builder.append(" \"Action\": \"s3:GetObject\",\n");
+ builder.append(" \"Effect\": \"Allow\",\n");
+ builder.append(" \"Principal\": \"*\",\n");
+ builder.append(" \"Resource\": \"arn:aws:s3:::"+bucketName+"/*\"\n");
+ builder.append(" }\n");
+ builder.append(" ],\n");
+ builder.append(" \"Version\": \"2012-10-17\"\n");
+ builder.append("}\n");
+
+ String publicPolicy = builder.toString();
+
+ //ToDo Support custom policy
+ String policyConfig = (policy.equalsIgnoreCase("public"))? publicPolicy : privatePolicy;
+
+ MinioClient minioClient = getMinIOClient(storeId);
+ try {
+ minioClient.setBucketPolicy(
+ SetBucketPolicyArgs.builder().bucket(bucketName).config(policyConfig).build());
+ } catch (Exception e) {
+ throw new CloudRuntimeException(e);
+ }
+ }
+
+ @Override
+ public BucketPolicy getBucketPolicy(String bucketName, long storeId) {
+ return null;
+ }
+
+ @Override
+ public void deleteBucketPolicy(String bucketName, long storeId) {
+
+ }
+
+ @Override
+ public boolean createUser(long accountId, long storeId) {
+ Account account = _accountDao.findById(accountId);
+ MinioAdminClient minioAdminClient = getMinIOAdminClient(storeId);
+ String accessKey = "acs-"+account.getAccountName();
+ // Check user exists
+ try {
+ UserInfo userInfo = minioAdminClient.getUserInfo(accessKey);
+ if(userInfo != null) {
+ s_logger.debug("User already exists in MinIO store: "+accessKey);
+ return true;
+ }
+ } catch (Exception e) {
+ s_logger.debug("User does not exist. Creating user: "+accessKey);
+ }
+
+ KeyGenerator generator = null;
+ try {
+ generator = KeyGenerator.getInstance("HmacSHA1");
+ } catch (NoSuchAlgorithmException e) {
+ throw new CloudRuntimeException(e);
+ }
+ SecretKey key = generator.generateKey();
+ String secretKey = Base64.encodeBase64URLSafeString(key.getEncoded());
+ try {
+ minioAdminClient.addUser(accessKey, UserInfo.Status.ENABLED, secretKey, "", new ArrayList<String>());
+ } catch (Exception e) {
+ throw new CloudRuntimeException(e);
+ }
+ // Store user credentials
+ Map<String, String> details = new HashMap<>();
+ details.put(MINIO_ACCESS_KEY, accessKey);
+ details.put(MINIO_SECRET_KEY, secretKey);
+ _accountDetailsDao.persist(accountId, details);
+ return true;
+ }
+
+ @Override
+ public boolean setBucketEncryption(String bucketName, long storeId) {
+ MinioClient minioClient = getMinIOClient(storeId);
+ try {
+ minioClient.setBucketEncryption(SetBucketEncryptionArgs.builder()
+ .bucket(bucketName)
+ .config(SseConfiguration.newConfigWithSseS3Rule())
+ .build()
+ );
+ } catch (Exception e) {
+ throw new CloudRuntimeException(e);
+ }
+ return true;
+ }
+
+ @Override
+ public boolean deleteBucketEncryption(String bucketName, long storeId) {
+ MinioClient minioClient = getMinIOClient(storeId);
+ try {
+ minioClient.deleteBucketEncryption(DeleteBucketEncryptionArgs.builder()
+ .bucket(bucketName)
+ .build()
+ );
+ } catch (Exception e) {
+ throw new CloudRuntimeException(e);
+ }
+ return true;
+ }
+
+ @Override
+ public boolean setBucketVersioning(String bucketName, long storeId) {
+ MinioClient minioClient = getMinIOClient(storeId);
+ try {
+ minioClient.setBucketVersioning(SetBucketVersioningArgs.builder()
+ .bucket(bucketName)
+ .config(new VersioningConfiguration(VersioningConfiguration.Status.ENABLED, null))
+ .build()
+ );
+ } catch (Exception e) {
+ throw new CloudRuntimeException(e);
+ }
+ return true;
+ }
+
+ @Override
+ public boolean deleteBucketVersioning(String bucketName, long storeId) {
+ MinioClient minioClient = getMinIOClient(storeId);
+ try {
+ minioClient.setBucketVersioning(SetBucketVersioningArgs.builder()
+ .bucket(bucketName)
+ .config(new VersioningConfiguration(VersioningConfiguration.Status.SUSPENDED, null))
+ .build()
+ );
+ } catch (Exception e) {
+ throw new CloudRuntimeException(e);
+ }
+ return true;
+ }
+
+ /*
+ public void setBucketPolicy(String bucketName, long storeId, String policy) {
Review Comment:
Do we need to delete this ?
##########
ui/src/config/section/storage.js:
##########
@@ -443,54 +443,37 @@ export default {
]
},
{
- name: 'backup',
Review Comment:
We need backup also right! may be by mistake. Can you keep this and add new sections for buckets
##########
plugins/storage/object/minio/src/main/java/org/apache/cloudstack/storage/datastore/driver/MinIOObjectStoreDriverImpl.java:
##########
@@ -0,0 +1,431 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.cloudstack.storage.datastore.driver;
+
+import com.amazonaws.services.s3.model.AccessControlList;
+import com.amazonaws.services.s3.model.BucketPolicy;
+import com.cloud.agent.api.to.DataStoreTO;
+import com.cloud.storage.Bucket;
+import com.cloud.storage.BucketVO;
+import com.cloud.storage.dao.BucketDao;
+import com.cloud.user.Account;
+import com.cloud.user.AccountDetailsDao;
+import com.cloud.user.dao.AccountDao;
+import com.cloud.utils.exception.CloudRuntimeException;
+import io.minio.BucketExistsArgs;
+import io.minio.DeleteBucketEncryptionArgs;
+import io.minio.MakeBucketArgs;
+import io.minio.MinioClient;
+import io.minio.RemoveBucketArgs;
+import io.minio.SetBucketEncryptionArgs;
+import io.minio.SetBucketPolicyArgs;
+import io.minio.SetBucketVersioningArgs;
+import io.minio.admin.MinioAdminClient;
+import io.minio.admin.QuotaUnit;
+import io.minio.admin.UserInfo;
+import io.minio.admin.messages.DataUsageInfo;
+import io.minio.messages.SseConfiguration;
+import io.minio.messages.VersioningConfiguration;
+import org.apache.cloudstack.engine.subsystem.api.storage.DataStore;
+import org.apache.cloudstack.storage.datastore.db.ObjectStoreDao;
+import org.apache.cloudstack.storage.datastore.db.ObjectStoreDetailsDao;
+import org.apache.cloudstack.storage.datastore.db.ObjectStoreVO;
+import org.apache.cloudstack.storage.object.BaseObjectStoreDriverImpl;
+import org.apache.cloudstack.storage.object.BucketObject;
+import org.apache.commons.codec.binary.Base64;
+import org.apache.log4j.Logger;
+
+import javax.crypto.KeyGenerator;
+import javax.crypto.SecretKey;
+import javax.inject.Inject;
+import java.security.NoSuchAlgorithmException;
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+
+public class MinIOObjectStoreDriverImpl extends BaseObjectStoreDriverImpl {
+ private static final Logger s_logger = Logger.getLogger(MinIOObjectStoreDriverImpl.class);
+
+ @Inject
+ AccountDao _accountDao;
+
+ @Inject
+ AccountDetailsDao _accountDetailsDao;
+
+ @Inject
+ ObjectStoreDao _storeDao;
+
+ @Inject
+ BucketDao _bucketDao;
+
+ @Inject
+ ObjectStoreDetailsDao _storeDetailsDao;
+
+ private static final String ACCESS_KEY = "accesskey";
+ private static final String SECRET_KEY = "secretkey";
+
+ private static final String MINIO_ACCESS_KEY = "minio-accesskey";
+ private static final String MINIO_SECRET_KEY = "minio-secretkey";
+
+ @Override
+ public DataStoreTO getStoreTO(DataStore store) {
+ return null;
+ }
+
+ @Override
+ public Bucket createBucket(Bucket bucket, boolean objectLock) {
+ //ToDo Client pool mgmt
+ String bucketName = bucket.getName();
+ long storeId = bucket.getObjectStoreId();
+ long accountId = bucket.getAccountId();
+ MinioClient minioClient = getMinIOClient(storeId);
+ Account account = _accountDao.findById(accountId);
+ try {
+ if(minioClient.bucketExists(BucketExistsArgs.builder().bucket(bucketName).build())) {
+ throw new CloudRuntimeException("Bucket already exists with name "+ bucketName);
+ }
+ } catch (Exception e) {
+ throw new CloudRuntimeException(e);
+ }
+ try {
+ minioClient.makeBucket(MakeBucketArgs.builder().bucket(bucketName).objectLock(objectLock).build());
+ } catch (Exception e) {
+ throw new CloudRuntimeException(e);
+ }
+
+ String policy = " {\n" +
+ " \"Statement\": [\n" +
+ " {\n" +
+ " \"Action\": \"s3:*\",\n" +
+ " \"Effect\": \"Allow\",\n" +
+ " \"Principal\": \"*\",\n" +
+ " \"Resource\": \"arn:aws:s3:::"+bucketName+"/*\"\n" +
+ " }\n" +
+ " ],\n" +
+ " \"Version\": \"2012-10-17\"\n" +
+ " }";
+ MinioAdminClient minioAdminClient = getMinIOAdminClient(storeId);
+ String policyName = "acs-"+account.getAccountName()+"-policy";
+ String userName = "acs-"+account.getAccountName();
+ try {
+ minioAdminClient.addCannedPolicy(policyName, policy);
+ minioAdminClient.setPolicy(userName, false, policyName);
+ } catch (Exception e) {
+ throw new CloudRuntimeException(e);
+ }
+ String accessKey = _accountDetailsDao.findDetail(accountId, MINIO_ACCESS_KEY).getValue();
+ String secretKey = _accountDetailsDao.findDetail(accountId, MINIO_SECRET_KEY).getValue();
+ ObjectStoreVO store = _storeDao.findById(storeId);
+ BucketVO bucketVO = _bucketDao.findById(bucket.getId());
+ bucketVO.setAccessKey(accessKey);
+ bucketVO.setSecretKey(secretKey);
+ bucketVO.setBucketURL(store.getUrl()+"/"+bucketName);
+ _bucketDao.update(bucket.getId(), bucketVO);
+ return bucket;
+ }
+
+ @Override
+ public List<Bucket> listBuckets(long storeId) {
+ MinioClient minioClient = getMinIOClient(storeId);
+ List<Bucket> bucketsList = new ArrayList<>();
+ try {
+ List<io.minio.messages.Bucket> minIOBuckets = minioClient.listBuckets();
+ for(io.minio.messages.Bucket minIObucket : minIOBuckets) {
+ Bucket bucket = new BucketObject();
+ bucket.setName(minIObucket.name());
+ bucketsList.add(bucket);
+ }
+ } catch (Exception e) {
+ throw new CloudRuntimeException(e);
+ }
+ return bucketsList;
+ }
+
+ @Override
+ public boolean deleteBucket(String bucketName, long storeId) {
+ MinioClient minioClient = getMinIOClient(storeId);
+ try {
+ if(!minioClient.bucketExists(BucketExistsArgs.builder().bucket(bucketName).build())) {
+ throw new CloudRuntimeException("Bucket doesn't exist: "+ bucketName);
+ }
+ } catch (Exception e) {
+ throw new CloudRuntimeException(e);
+ }
+ //ToDo: check bucket empty
+ try {
+ minioClient.removeBucket(RemoveBucketArgs.builder().bucket(bucketName).build());
+ } catch (Exception e) {
+ throw new CloudRuntimeException(e);
+ }
+ return true;
+ }
+
+ @Override
+ public AccessControlList getBucketAcl(String bucketName, long storeId) {
+ return null;
+ }
+
+ @Override
+ public void setBucketAcl(String bucketName, AccessControlList acl, long storeId) {
+
+ }
+
+ @Override
+ public void setBucketPolicy(String bucketName, String policy, long storeId) {
+ String privatePolicy = "{\"Version\":\"2012-10-17\",\"Statement\":[]}";
+
+ StringBuilder builder = new StringBuilder();
+ builder.append("{\n");
+ builder.append(" \"Statement\": [\n");
+ builder.append(" {\n");
+ builder.append(" \"Action\": [\n");
+ builder.append(" \"s3:GetBucketLocation\",\n");
+ builder.append(" \"s3:ListBucket\"\n");
+ builder.append(" ],\n");
+ builder.append(" \"Effect\": \"Allow\",\n");
+ builder.append(" \"Principal\": \"*\",\n");
+ builder.append(" \"Resource\": \"arn:aws:s3:::"+bucketName+"\"\n");
+ builder.append(" },\n");
+ builder.append(" {\n");
+ builder.append(" \"Action\": \"s3:GetObject\",\n");
+ builder.append(" \"Effect\": \"Allow\",\n");
+ builder.append(" \"Principal\": \"*\",\n");
+ builder.append(" \"Resource\": \"arn:aws:s3:::"+bucketName+"/*\"\n");
+ builder.append(" }\n");
+ builder.append(" ],\n");
+ builder.append(" \"Version\": \"2012-10-17\"\n");
+ builder.append("}\n");
+
+ String publicPolicy = builder.toString();
+
+ //ToDo Support custom policy
+ String policyConfig = (policy.equalsIgnoreCase("public"))? publicPolicy : privatePolicy;
+
+ MinioClient minioClient = getMinIOClient(storeId);
+ try {
+ minioClient.setBucketPolicy(
+ SetBucketPolicyArgs.builder().bucket(bucketName).config(policyConfig).build());
+ } catch (Exception e) {
+ throw new CloudRuntimeException(e);
+ }
+ }
+
+ @Override
+ public BucketPolicy getBucketPolicy(String bucketName, long storeId) {
+ return null;
+ }
+
+ @Override
+ public void deleteBucketPolicy(String bucketName, long storeId) {
+
+ }
+
+ @Override
+ public boolean createUser(long accountId, long storeId) {
+ Account account = _accountDao.findById(accountId);
+ MinioAdminClient minioAdminClient = getMinIOAdminClient(storeId);
+ String accessKey = "acs-"+account.getAccountName();
+ // Check user exists
+ try {
+ UserInfo userInfo = minioAdminClient.getUserInfo(accessKey);
+ if(userInfo != null) {
+ s_logger.debug("User already exists in MinIO store: "+accessKey);
+ return true;
+ }
+ } catch (Exception e) {
+ s_logger.debug("User does not exist. Creating user: "+accessKey);
+ }
+
+ KeyGenerator generator = null;
+ try {
+ generator = KeyGenerator.getInstance("HmacSHA1");
+ } catch (NoSuchAlgorithmException e) {
+ throw new CloudRuntimeException(e);
+ }
+ SecretKey key = generator.generateKey();
+ String secretKey = Base64.encodeBase64URLSafeString(key.getEncoded());
+ try {
+ minioAdminClient.addUser(accessKey, UserInfo.Status.ENABLED, secretKey, "", new ArrayList<String>());
+ } catch (Exception e) {
+ throw new CloudRuntimeException(e);
+ }
+ // Store user credentials
+ Map<String, String> details = new HashMap<>();
+ details.put(MINIO_ACCESS_KEY, accessKey);
+ details.put(MINIO_SECRET_KEY, secretKey);
+ _accountDetailsDao.persist(accountId, details);
+ return true;
+ }
+
+ @Override
+ public boolean setBucketEncryption(String bucketName, long storeId) {
+ MinioClient minioClient = getMinIOClient(storeId);
+ try {
+ minioClient.setBucketEncryption(SetBucketEncryptionArgs.builder()
+ .bucket(bucketName)
+ .config(SseConfiguration.newConfigWithSseS3Rule())
+ .build()
+ );
+ } catch (Exception e) {
+ throw new CloudRuntimeException(e);
+ }
+ return true;
+ }
+
+ @Override
+ public boolean deleteBucketEncryption(String bucketName, long storeId) {
+ MinioClient minioClient = getMinIOClient(storeId);
+ try {
+ minioClient.deleteBucketEncryption(DeleteBucketEncryptionArgs.builder()
+ .bucket(bucketName)
+ .build()
+ );
+ } catch (Exception e) {
+ throw new CloudRuntimeException(e);
+ }
+ return true;
+ }
+
+ @Override
+ public boolean setBucketVersioning(String bucketName, long storeId) {
+ MinioClient minioClient = getMinIOClient(storeId);
+ try {
+ minioClient.setBucketVersioning(SetBucketVersioningArgs.builder()
+ .bucket(bucketName)
+ .config(new VersioningConfiguration(VersioningConfiguration.Status.ENABLED, null))
+ .build()
+ );
+ } catch (Exception e) {
+ throw new CloudRuntimeException(e);
+ }
+ return true;
+ }
+
+ @Override
+ public boolean deleteBucketVersioning(String bucketName, long storeId) {
+ MinioClient minioClient = getMinIOClient(storeId);
+ try {
+ minioClient.setBucketVersioning(SetBucketVersioningArgs.builder()
+ .bucket(bucketName)
+ .config(new VersioningConfiguration(VersioningConfiguration.Status.SUSPENDED, null))
+ .build()
+ );
+ } catch (Exception e) {
+ throw new CloudRuntimeException(e);
+ }
+ return true;
+ }
+
+ /*
+ public void setBucketPolicy(String bucketName, long storeId, String policy) {
+
+ String privatePolicy = "{\"Version\":\"2012-10-17\",\"Statement\":[]}";
+
+ StringBuilder builder = new StringBuilder();
+ builder.append("{\n");
+ builder.append(" \"Statement\": [\n");
+ builder.append(" {\n");
+ builder.append(" \"Action\": [\n");
+ builder.append(" \"s3:GetBucketLocation\",\n");
+ builder.append(" \"s3:ListBucket\"\n");
+ builder.append(" ],\n");
+ builder.append(" \"Effect\": \"Allow\",\n");
+ builder.append(" \"Principal\": \"*\",\n");
+ builder.append(" \"Resource\": \"arn:aws:s3:::"+bucketName+"\"\n");
+ builder.append(" },\n");
+ builder.append(" {\n");
+ builder.append(" \"Action\": \"s3:GetObject\",\n");
+ builder.append(" \"Effect\": \"Allow\",\n");
+ builder.append(" \"Principal\": \"*\",\n");
+ builder.append(" \"Resource\": \"arn:aws:s3:::"+bucketName+"/*\"\n");
+ builder.append(" }\n");
+ builder.append(" ],\n");
+ builder.append(" \"Version\": \"2012-10-17\"\n");
+ builder.append("}\n");
+
+ String publicPolicy = builder.toString();
+ //Default to private policy
+ //ToDo Support custom policy
+ String policyConfig = privatePolicy;
+
+ if(policy.equals("public")) {
+ policyConfig = publicPolicy;
+ }
+
+ MinioClient minioClient = getMinIOClient(storeId);
+ try {
+ minioClient.setBucketPolicy(
+ SetBucketPolicyArgs.builder().bucket(bucketName).config(policyConfig).build());
+
+ } catch (Exception e) {
+ throw new CloudRuntimeException(e);
+ }
+ } */
+
+ @Override
Review Comment:
Can you please add null checks for all the return objects in the below methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1759714749
@vladimirpetrov a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1829550881
> > @kishankavala @vladimirpetrov @NuxRo is this ready or are you still testing?
> > @kishankavala can you please check test failure in Github CI?
> > ```
> > Run echo -e "Simulator CI Test Results: (only failures listed)\n"
> > Simulator CI Test Results: (only failures listed)
> >
> > +---------+----------------------+-------+-----------------------+
> > | Test | Result | Time | Test file |
> > +=========+======================+=======+=======================+
> > | runTest | builtins.ImportError | 0.001 | test_object_stores.py |
> > +---------+----------------------+-------+-----------------------+
> > Error: Process completed with exit code 1.
> > ```
>
> @shwstppr I'm not able to repo this failure in my env. Couldn't find error details in Simulator CI Test Results log. blueorangutan test did not report error for the same test.
@kishankavala I don't have any suggestions here. I tested locally as well and couldn't reproduce it locally.
```
abhishek@ghost ~/lab/shapeblue/cloudstack (pr-7752) $ nosetests --with-xunit --xunit-file=results.xml --with-marvin --marvin-config=./setup/dev/advanced.cfg -s -a tags=advanced --hypervisor=Simulator test/integration/smoke/test_object_stores.py
==== Marvin Init Started ====
=== Marvin Parse Config Successful ===
=== Marvin Setting TestData Successful===
==== Log Folder Path: /tmp/MarvinLogs/Nov_28_2023_15_41_17_VY6V9C All logs will be available here ====
=== Marvin Init Logging Successful===
==== Marvin Init Successful ====
=== Final results are now copied to: /tmp/MarvinLogs/test_suite_8GPUBI ===
```
I've restarted GH actions. If it continues to fail should we remove the new test from ci.yml for now?
Any suggestions @DaanHoogland @weizhouapache @rohityadavcloud?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr closed pull request #7752: ObjectStore Framework with MinIO and Simulator plugins
URL: https://github.com/apache/cloudstack/pull/7752
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1836007882
<b>[SF] Trillian test result (tid-8439)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 56645 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7752-t8439-kvm-centos7.zip
Smoke tests completed. 120 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_invalid_upgrade_kubernetes_cluster | `Failure` | 3604.30 | test_kubernetes_clusters.py
test_02_upgrade_kubernetes_cluster | `Failure` | 3609.15 | test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_05_basic_lifecycle_kubernetes_cluster | `Failure` | 0.05 | test_kubernetes_clusters.py
test_06_delete_kubernetes_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 0.05 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_10_vpc_tier_kubernetes_cluster | `Failure` | 45.96 | test_kubernetes_clusters.py
test_11_test_unmanaged_cluster_lifecycle | `Error` | 1.25 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 59.83 | test_kubernetes_clusters.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] vladimirpetrov commented on pull request #7752: ObjectStore Framework with MinIO and Simulator plugins
Posted by "vladimirpetrov (via GitHub)" <gi...@apache.org>.
vladimirpetrov commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1695277767
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1812111211
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1783775711
@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1782508355
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7752: ObjectStore Framework with MinIO and Simulator plugins
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1681732261
@kishankavala a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] kishankavala commented on pull request #7752: ObjectStore Framework with MinIO and Simulator plugins
Posted by "kishankavala (via GitHub)" <gi...@apache.org>.
kishankavala commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1681731682
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7752: ObjectStore Framework with MinIO and Simulator plugins
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1641521400
@kishankavala a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7752: ObjectStore Framework with MinIO and Simulator plugins
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1641598972
@kishankavala a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7752: ObjectStore Framework with MinIO and Simulator plugins
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1695281008
@vladimirpetrov a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1832139443
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7868
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "kishankavala (via GitHub)" <gi...@apache.org>.
kishankavala commented on code in PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#discussion_r1410221912
##########
.github/workflows/ci.yml:
##########
@@ -90,6 +90,7 @@ jobs:
smoke/test_nic
smoke/test_nic_adapter_type
smoke/test_non_contigiousvlan
+ smoke/test_object_stores.py
Review Comment:
Thanks @weizhouapache. That worked
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "kishankavala (via GitHub)" <gi...@apache.org>.
kishankavala commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1834372591
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "vladimirpetrov (via GitHub)" <gi...@apache.org>.
vladimirpetrov commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1754583835
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1820420734
@kishankavala @vladimirpetrov @NuxRo is this ready or are you still testing?
@kishankavala can you please check test failure in Github CI?
```
Run echo -e "Simulator CI Test Results: (only failures listed)\n"
Simulator CI Test Results: (only failures listed)
+---------+----------------------+-------+-----------------------+
| Test | Result | Time | Test file |
+=========+======================+=======+=======================+
| runTest | builtins.ImportError | 0.001 | test_object_stores.py |
+---------+----------------------+-------+-----------------------+
Error: Process completed with exit code 1.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #7752: ObjectStore Framework with MinIO and Simulator plugins
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1688028489
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "vladimirpetrov (via GitHub)" <gi...@apache.org>.
vladimirpetrov commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1759694348
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1754697924
@vladimirpetrov a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1786769164
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1786964069
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1777231829
@vladimirpetrov a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1783787300
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7556
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "vishesh92 (via GitHub)" <gi...@apache.org>.
vishesh92 commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1783775618
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "vladimirpetrov (via GitHub)" <gi...@apache.org>.
vladimirpetrov commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1777129320
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "kishankavala (via GitHub)" <gi...@apache.org>.
kishankavala commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1798412497
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1829563971
> Any suggestions @DaanHoogland @weizhouapache @rohityadavcloud?
not yet, I have started reviewing this, but don't want all of us to work on the same feature. As for the failure the only thing I can think of is that it not really doesn´t require hardware (sorry for the double negative) and succeeds locally but not on the gh provided virtual machine, so your sugestion would make sense @shwstppr .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1834374468
@kishankavala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "kishankavala (via GitHub)" <gi...@apache.org>.
kishankavala commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1834451014
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr merged PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7752: ObjectStore Framework with MinIO and Simulator plugins
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1678491787
@vladimirpetrov a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7752: ObjectStore Framework with MinIO and Simulator plugins
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1738547408
@vladimirpetrov a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1759855379
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7343
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "vladimirpetrov (via GitHub)" <gi...@apache.org>.
vladimirpetrov commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1760396881
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1832009111
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1832005515
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1833421974
@kishankavala conflicts here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "kishankavala (via GitHub)" <gi...@apache.org>.
kishankavala commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1827188255
> @kishankavala @vladimirpetrov @NuxRo is this ready or are you still testing?
>
> @kishankavala can you please check test failure in Github CI?
>
> ```
> Run echo -e "Simulator CI Test Results: (only failures listed)\n"
> Simulator CI Test Results: (only failures listed)
>
> +---------+----------------------+-------+-----------------------+
> | Test | Result | Time | Test file |
> +=========+======================+=======+=======================+
> | runTest | builtins.ImportError | 0.001 | test_object_stores.py |
> +---------+----------------------+-------+-----------------------+
> Error: Process completed with exit code 1.
> ```
@shwstppr I'm not able to repo this failure in my env. Couldn't find error details in Simulator CI Test Results log.
blueorangutan test did not report error for the same test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1787465090
@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1790420478
@vladimirpetrov a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1792438892
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "NuxRo (via GitHub)" <gi...@apache.org>.
NuxRo commented on code in PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#discussion_r1393925385
##########
ui/public/locales/en.json:
##########
@@ -1406,6 +1412,16 @@
"label.oauth.configuration": "OAuth configuration",
"label.oauth.verification": "OAuth verification",
"label.ocfs2": "OCFS2",
+"label.object.storage" : "Object Storage",
+"label.object.presigned.url": "Presigned URL",
+"label.object.presigned.url.description" : "Presigned of the object to access the object without authentication",
Review Comment:
```suggestion
"label.object.presigned.url.description" : "Presigned URL of the object in order to access it without authentication.",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7752: ObjectStore Framework with MinIO and Simulator plugins
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1670765643
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6717
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "vladimirpetrov (via GitHub)" <gi...@apache.org>.
vladimirpetrov commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1754695566
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1754691087
Packaging result [SF]: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7295
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7752: ObjectStore Framework with MinIO and Simulator plugins
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1695303441
Packaging result [SF]: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: el9 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 6912
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #7752: ObjectStore Framework with MinIO and Simulator plugins
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1641453510
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/7752?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#7752](https://app.codecov.io/gh/apache/cloudstack/pull/7752?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (b56685b) into [main](https://app.codecov.io/gh/apache/cloudstack/commit/b5eebc4347aa2387afc7aa1028cb0fcf5f83678d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (b5eebc4) will **decrease** coverage by `0.06%`.
> The diff coverage is `0.19%`.
```diff
@@ Coverage Diff @@
## main #7752 +/- ##
============================================
- Coverage 13.41% 13.36% -0.06%
Complexity 9368 9368
============================================
Files 2745 2766 +21
Lines 258683 259707 +1024
Branches 40291 40366 +75
============================================
Hits 34700 34700
- Misses 219607 220631 +1024
Partials 4376 4376
```
| [Impacted Files](https://app.codecov.io/gh/apache/cloudstack/pull/7752?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...ngine/subsystem/api/storage/DataStoreProvider.java](https://app.codecov.io/gh/apache/cloudstack/pull/7752?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZW5naW5lL2FwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvY2xvdWRzdGFjay9lbmdpbmUvc3Vic3lzdGVtL2FwaS9zdG9yYWdlL0RhdGFTdG9yZVByb3ZpZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...hema/src/main/java/com/cloud/storage/BucketVO.java](https://app.codecov.io/gh/apache/cloudstack/pull/7752?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC9zdG9yYWdlL0J1Y2tldFZPLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../main/java/com/cloud/usage/BucketStatisticsVO.java](https://app.codecov.io/gh/apache/cloudstack/pull/7752?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC91c2FnZS9CdWNrZXRTdGF0aXN0aWNzVk8uamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...a/com/cloud/usage/dao/BucketStatisticsDaoImpl.java](https://app.codecov.io/gh/apache/cloudstack/pull/7752?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC91c2FnZS9kYW8vQnVja2V0U3RhdGlzdGljc0Rhb0ltcGwuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...rc/main/java/com/cloud/usage/dao/UsageDaoImpl.java](https://app.codecov.io/gh/apache/cloudstack/pull/7752?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC91c2FnZS9kYW8vVXNhZ2VEYW9JbXBsLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...stack/storage/datastore/db/ObjectStoreDaoImpl.java](https://app.codecov.io/gh/apache/cloudstack/pull/7752?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvY2xvdWRzdGFjay9zdG9yYWdlL2RhdGFzdG9yZS9kYi9PYmplY3RTdG9yZURhb0ltcGwuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...tack/storage/datastore/db/ObjectStoreDetailVO.java](https://app.codecov.io/gh/apache/cloudstack/pull/7752?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvY2xvdWRzdGFjay9zdG9yYWdlL2RhdGFzdG9yZS9kYi9PYmplY3RTdG9yZURldGFpbFZPLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...torage/datastore/db/ObjectStoreDetailsDaoImpl.java](https://app.codecov.io/gh/apache/cloudstack/pull/7752?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvY2xvdWRzdGFjay9zdG9yYWdlL2RhdGFzdG9yZS9kYi9PYmplY3RTdG9yZURldGFpbHNEYW9JbXBsLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...cloudstack/storage/datastore/db/ObjectStoreVO.java](https://app.codecov.io/gh/apache/cloudstack/pull/7752?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvY2xvdWRzdGFjay9zdG9yYWdlL2RhdGFzdG9yZS9kYi9PYmplY3RTdG9yZVZPLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...apache/cloudstack/storage/object/BucketObject.java](https://app.codecov.io/gh/apache/cloudstack/pull/7752?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZW5naW5lL3N0b3JhZ2Uvb2JqZWN0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL3N0b3JhZ2Uvb2JqZWN0L0J1Y2tldE9iamVjdC5qYXZh) | `0.00% <0.00%> (ø)` | |
| ... and [22 more](https://app.codecov.io/gh/apache/cloudstack/pull/7752?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1 file with indirect coverage changes](https://app.codecov.io/gh/apache/cloudstack/pull/7752/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7752: ObjectStore Framework with MinIO and Simulator plugins
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1711406250
@vladimirpetrov a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1754829706
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7298
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #7752: ObjectStore Framework with MinIO and Simulator plugins
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1739713255
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] kishankavala commented on pull request #7752: ObjectStore Framework with MinIO and Simulator plugins
Posted by "kishankavala (via GitHub)" <gi...@apache.org>.
kishankavala commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1641519929
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7752: ObjectStore Framework with MinIO and Simulator plugins
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1670717407
@kishankavala a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7752: ObjectStore Framework with MinIO and Simulator plugins
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1711483559
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7001
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1823948410
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7822
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "kishankavala (via GitHub)" <gi...@apache.org>.
kishankavala commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1825431904
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "vladimirpetrov (via GitHub)" <gi...@apache.org>.
vladimirpetrov commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1777229068
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1831466345
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "kishankavala (via GitHub)" <gi...@apache.org>.
kishankavala commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1833203499
Smoke tests are successful now. But build is failing intermittently:
2023-11-16T08:19:39.0577230Z [ERROR] Tests run: 9, Failures: 0, Errors: 9, Skipped: 0, Time elapsed: 1.525 s <<< FAILURE! - in org.apache.backup.networker.NetworkerClientTest
2023-11-16T08:19:39.0579306Z [ERROR] testListPolicies(org.apache.backup.networker.NetworkerClientTest) Time elapsed: 1.139 s <<< ERROR!
2023-11-16T08:19:39.0583560Z com.github.tomakehurst.wiremock.common.FatalStartupException: java.lang.RuntimeException: java.net.BindException: Address already in use
2023-11-16T08:19:39.0585977Z Caused by: java.lang.RuntimeException: java.net.BindException: Address already in use
2023-11-16T08:19:39.0587336Z Caused by: java.net.BindException: Address already in use
Multiple builds running on the same host could be the reason or some other process is using port 9399 which NetworkerClientTest is trying to use
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1833559248
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1788347297
<b>[SF] Trillian test result (tid-8183)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40954 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7752-t8183-kvm-centos7.zip
Smoke tests completed. 117 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1787065268
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7575
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "vladimirpetrov (via GitHub)" <gi...@apache.org>.
vladimirpetrov commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1790400161
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7752:
URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1798340669
@vladimirpetrov a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org