You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/06/01 17:31:01 UTC
[GitHub] [spark] MaxGekk opened a new pull request #28696: [SPARK-31888][SQL] Support `java.time.Instant` in Parquet filter pushdown
MaxGekk opened a new pull request #28696:
URL: https://github.com/apache/spark/pull/28696
### What changes were proposed in this pull request?
1. Modified `ParquetFilters.valueCanMakeFilterOn()` to accept filters with `java.time.Instant` attributes.
2. Added `ParquetFilters.timestampToMicros()` to support both types `java.sql.Timestamp` and `java.time.Instant` in conversions to microseconds.
3. Re-used `timestampToMicros` in constructing of Parquet filters.
### Why are the changes needed?
To support pushed down filters with `java.time.Instant` attributes. Before the changes, date filters are not pushed down to Parquet datasource when `spark.sql.datetime.java8API.enabled` is `true`.
### Does this PR introduce any user-facing change?
No
### How was this patch tested?
Modified tests to `ParquetFilterSuite` to check the case when Java 8 API is enabled.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28696: [SPARK-31888][SQL] Support `java.time.Instant` in Parquet filter pushdown
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28696:
URL: https://github.com/apache/spark/pull/28696#issuecomment-637335317
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28696: [SPARK-31888][SQL] Support `java.time.Instant` in Parquet filter pushdown
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28696:
URL: https://github.com/apache/spark/pull/28696#issuecomment-637295139
**[Test build #123420 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123420/testReport)** for PR 28696 at commit [`a0a5923`](https://github.com/apache/spark/commit/a0a5923325592424ce78f5881573b337b8e4e300).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28696: [SPARK-31888][SQL] Support `java.time.Instant` in Parquet filter pushdown
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28696:
URL: https://github.com/apache/spark/pull/28696#issuecomment-637183349
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28696: [SPARK-31888][SQL] Support `java.time.Instant` in Parquet filter pushdown
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28696:
URL: https://github.com/apache/spark/pull/28696#issuecomment-637488316
**[Test build #123422 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123422/testReport)** for PR 28696 at commit [`a0a5923`](https://github.com/apache/spark/commit/a0a5923325592424ce78f5881573b337b8e4e300).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #28696: [SPARK-31888][SQL] Support `java.time.Instant` in Parquet filter pushdown
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #28696:
URL: https://github.com/apache/spark/pull/28696#issuecomment-637003249
The changes are similar to https://github.com/apache/spark/pull/28259. @cloud-fan @HyukjinKwon Please, review this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28696: [SPARK-31888][SQL] Support `java.time.Instant` in Parquet filter pushdown
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28696:
URL: https://github.com/apache/spark/pull/28696#issuecomment-637003082
**[Test build #123385 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123385/testReport)** for PR 28696 at commit [`eca11d4`](https://github.com/apache/spark/commit/eca11d474873ad58b5a1f057e6a46cea4cf50c58).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28696: [SPARK-31888][SQL] Support `java.time.Instant` in Parquet filter pushdown
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28696:
URL: https://github.com/apache/spark/pull/28696#issuecomment-637183349
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28696: [SPARK-31888][SQL] Support `java.time.Instant` in Parquet filter pushdown
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28696:
URL: https://github.com/apache/spark/pull/28696#issuecomment-637003691
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #28696: [SPARK-31888][SQL] Support `java.time.Instant` in Parquet filter pushdown
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #28696:
URL: https://github.com/apache/spark/pull/28696#issuecomment-637339865
jenkins, retest this, please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28696: [SPARK-31888][SQL] Support `java.time.Instant` in Parquet filter pushdown
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28696:
URL: https://github.com/apache/spark/pull/28696#issuecomment-637342883
**[Test build #123422 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123422/testReport)** for PR 28696 at commit [`a0a5923`](https://github.com/apache/spark/commit/a0a5923325592424ce78f5881573b337b8e4e300).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28696: [SPARK-31888][SQL] Support `java.time.Instant` in Parquet filter pushdown
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28696:
URL: https://github.com/apache/spark/pull/28696#issuecomment-637489395
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28696: [SPARK-31888][SQL] Support `java.time.Instant` in Parquet filter pushdown
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28696:
URL: https://github.com/apache/spark/pull/28696#issuecomment-637335205
**[Test build #123420 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123420/testReport)** for PR 28696 at commit [`a0a5923`](https://github.com/apache/spark/commit/a0a5923325592424ce78f5881573b337b8e4e300).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28696: [SPARK-31888][SQL] Support `java.time.Instant` in Parquet filter pushdown
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28696:
URL: https://github.com/apache/spark/pull/28696#issuecomment-637335317
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28696: [SPARK-31888][SQL] Support `java.time.Instant` in Parquet filter pushdown
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28696:
URL: https://github.com/apache/spark/pull/28696#issuecomment-637003082
**[Test build #123385 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123385/testReport)** for PR 28696 at commit [`eca11d4`](https://github.com/apache/spark/commit/eca11d474873ad58b5a1f057e6a46cea4cf50c58).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28696: [SPARK-31888][SQL] Support `java.time.Instant` in Parquet filter pushdown
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28696:
URL: https://github.com/apache/spark/pull/28696#issuecomment-637343444
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #28696: [SPARK-31888][SQL] Support `java.time.Instant` in Parquet filter pushdown
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #28696:
URL: https://github.com/apache/spark/pull/28696#issuecomment-637490443
thanks, merging to master!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28696: [SPARK-31888][SQL] Support `java.time.Instant` in Parquet filter pushdown
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28696:
URL: https://github.com/apache/spark/pull/28696#issuecomment-637182509
**[Test build #123385 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123385/testReport)** for PR 28696 at commit [`eca11d4`](https://github.com/apache/spark/commit/eca11d474873ad58b5a1f057e6a46cea4cf50c58).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28696: [SPARK-31888][SQL] Support `java.time.Instant` in Parquet filter pushdown
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28696:
URL: https://github.com/apache/spark/pull/28696#issuecomment-637342883
**[Test build #123422 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123422/testReport)** for PR 28696 at commit [`a0a5923`](https://github.com/apache/spark/commit/a0a5923325592424ce78f5881573b337b8e4e300).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan edited a comment on pull request #28696: [SPARK-31888][SQL] Support `java.time.Instant` in Parquet filter pushdown
Posted by GitBox <gi...@apache.org>.
cloud-fan edited a comment on pull request #28696:
URL: https://github.com/apache/spark/pull/28696#issuecomment-637490443
thanks, merging to master/3.0!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28696: [SPARK-31888][SQL] Support `java.time.Instant` in Parquet filter pushdown
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28696:
URL: https://github.com/apache/spark/pull/28696#issuecomment-637003691
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28696: [SPARK-31888][SQL] Support `java.time.Instant` in Parquet filter pushdown
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28696:
URL: https://github.com/apache/spark/pull/28696#issuecomment-637335324
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123420/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28696: [SPARK-31888][SQL] Support `java.time.Instant` in Parquet filter pushdown
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28696:
URL: https://github.com/apache/spark/pull/28696#issuecomment-637295421
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28696: [SPARK-31888][SQL] Support `java.time.Instant` in Parquet filter pushdown
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28696:
URL: https://github.com/apache/spark/pull/28696#issuecomment-637489395
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #28696: [SPARK-31888][SQL] Support `java.time.Instant` in Parquet filter pushdown
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #28696:
URL: https://github.com/apache/spark/pull/28696
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28696: [SPARK-31888][SQL] Support `java.time.Instant` in Parquet filter pushdown
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28696:
URL: https://github.com/apache/spark/pull/28696#issuecomment-637343433
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #28696: [SPARK-31888][SQL] Support `java.time.Instant` in Parquet filter pushdown
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #28696:
URL: https://github.com/apache/spark/pull/28696#discussion_r433580261
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala
##########
@@ -588,36 +602,41 @@ abstract class ParquetFilterSuite extends QueryTest with ParquetTest with Shared
}
test("filter pushdown - timestamp") {
- // spark.sql.parquet.outputTimestampType = TIMESTAMP_MILLIS
- val millisData = Seq(
- Timestamp.valueOf("1000-06-14 08:28:53.123"),
- Timestamp.valueOf("1582-06-15 08:28:53.001"),
- Timestamp.valueOf("1900-06-16 08:28:53.0"),
- Timestamp.valueOf("2018-06-17 08:28:53.999"))
- withSQLConf(SQLConf.PARQUET_OUTPUT_TIMESTAMP_TYPE.key ->
- ParquetOutputTimestampType.TIMESTAMP_MILLIS.toString) {
- testTimestampPushdown(millisData)
- }
-
- // spark.sql.parquet.outputTimestampType = TIMESTAMP_MICROS
- val microsData = Seq(
- Timestamp.valueOf("1000-06-14 08:28:53.123456"),
- Timestamp.valueOf("1582-06-15 08:28:53.123456"),
- Timestamp.valueOf("1900-06-16 08:28:53.123456"),
- Timestamp.valueOf("2018-06-17 08:28:53.123456"))
- withSQLConf(SQLConf.PARQUET_OUTPUT_TIMESTAMP_TYPE.key ->
- ParquetOutputTimestampType.TIMESTAMP_MICROS.toString) {
- testTimestampPushdown(microsData)
- }
-
- // spark.sql.parquet.outputTimestampType = INT96 doesn't support pushdown
- withSQLConf(SQLConf.PARQUET_OUTPUT_TIMESTAMP_TYPE.key ->
- ParquetOutputTimestampType.INT96.toString) {
- import testImplicits._
- withParquetDataFrame(millisData.map(i => Tuple1(i)).toDF()) { implicit df =>
- val schema = new SparkToParquetSchemaConverter(conf).convert(df.schema)
- assertResult(None) {
- createParquetFilters(schema).createFilter(sources.IsNull("_1"))
+ Seq(true).foreach { java8Api =>
Review comment:
Seq(true, false)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28696: [SPARK-31888][SQL] Support `java.time.Instant` in Parquet filter pushdown
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28696:
URL: https://github.com/apache/spark/pull/28696#issuecomment-637295421
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28696: [SPARK-31888][SQL] Support `java.time.Instant` in Parquet filter pushdown
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28696:
URL: https://github.com/apache/spark/pull/28696#issuecomment-637295139
**[Test build #123420 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123420/testReport)** for PR 28696 at commit [`a0a5923`](https://github.com/apache/spark/commit/a0a5923325592424ce78f5881573b337b8e4e300).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org