You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/06/11 02:48:25 UTC

[GitHub] [pulsar] zymap commented on a change in pull request #7228: Protobuf-shaded package can not update version

zymap commented on a change in pull request #7228:
URL: https://github.com/apache/pulsar/pull/7228#discussion_r438512883



##########
File path: src/set-project-version.sh
##########
@@ -30,12 +30,13 @@ NEW_VERSION=$1
 # Go to top level project directory
 pushd $(dirname "$0")/..
 
+# Get the current version
+OLD_VERSION=`mvn -q -Dexec.executable=echo -Dexec.args='${project.version}' --non-recursive exec:exec`

Review comment:
       Thanks for reminding me. I change to use the script to get the version. PTAL. Thanks.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org