[GitHub] [cordova-plugin-camera] breautek edited a comment on issue #345: Camera plugin crashes app on some android phones when an image is taken

[GitBox <gi...@apache.org>]

breautek edited a comment on issue #345: Camera plugin crashes app on some android phones when an image is taken
URL: https://github.com/apache/cordova-plugin-camera/issues/345#issuecomment-547929746
 
 
   It's only an issue if using `DATA_URL` destination. `DATA_URL` is useful for representing small binary data, it's not reasonable to use it to represent large binary. And that will only get worse as phones support larger resolutions which will only make the data larger. I can also make an educated guess to say that's why videos never supported `DATA_URL` destination at all.
   
   Using the `FILE_URI` destination type will save/stream the data to a temporary location, where you can read a file into a blob, which is the proper way of handling binary data in javascript. Using blobs will also keep the binary data allocated outside of the JS virtual machine (similar to how Buffers work in NodeJS), which helps JS performance by not requiring frequent garbage collections.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org